01cc7a996b
Use reference to constant in functions
2019-07-10 11:54:12 +02:00
9a77d748c0
Fixes minor issues found by static analyzer
2019-07-07 23:08:51 +02:00
b0ce9401ff
Merge pull request #30126 from qarmin/remove_unnecessary_code
...
Remove unnecessary code and add some error explanations
2019-07-01 14:32:04 +02:00
3c154eb93b
Remove unnecessary code and add some error explanations
2019-07-01 12:59:42 +02:00
d17eac735c
Merge pull request #29815 from NilsIrl/plus_file_1
...
Replace ` + "/" + ` with `String::file_add()`
2019-07-01 12:06:35 +02:00
c540411a7f
Fix ip_unix.cpp inclusion order for OpenBSD.
2019-06-28 18:42:21 +02:00
4517db75b5
Properly disable SIGPIPE on OSX network sockets.
...
Disable SO_NOSIGPIPE socket option when avaiable.
Use MSG_NOSIGNAL send flag on systems that support it.
2019-06-28 18:42:21 +02:00
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
...
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
4e5310cc60
Some code changed with Clang-Tidy
2019-06-26 15:08:25 +02:00
d2833d4f4d
Replace ` + "/" + ` with `String::file_add()`
2019-06-23 13:33:50 +01:00
1e833cadbc
Merge pull request #29935 from Faless/net/get_if_multicast_pr
...
Multicast, more network interfaces info
2019-06-21 10:21:01 +02:00
e5e3f86648
Multicast support in NetSocket/PacketPeerUDP
2019-06-21 00:14:42 +02:00
b574e476ec
Implement IP.get_local_interfaces.
...
Allow getting interfaces names and assigned names.
On UWP this is not supported, and the function will return one interface
for each local address (with interface name the local address itself).
2019-06-21 00:14:42 +02:00
5c66771e3e
Merge pull request #29283 from qarmin/fix_some_always_same_values
...
Remove always true/false values
2019-06-20 21:10:10 +02:00
072e40368e
Fix always true/false values
2019-06-20 16:59:48 +02:00
68735d2a88
Fix compilation warnings in JS and Windows builds
...
Warnings raised by Emscripten 1.38.0 and MinGW64 5.0.4 / GCC 8.3.0.
JS can now build with `werror=yes warnings=extra`.
MinGW64 still has a few warnings to resolve with `warnings=extra`,
and only one with `warnings=all`.
Part of #29033 and #29801 .
2019-06-15 14:40:45 +02:00
f78baa5f93
added a const keyword for a methods that return constant literal...
2019-05-21 02:16:30 -04:00
cdf54d6c5f
Ignore a warning in _get_socket_error (-Wlogical-op).
...
drivers/unix/net_socket_posix.cpp: In member function 'NetSocketPosix::NetError NetSocketPosix::_get_socket_error()':
drivers/unix/net_socket_posix.cpp:197:22: warning: logical 'or' of equal expressions [-Wlogical-op]
197 | if (errno == EAGAIN || errno == EWOULDBLOCK)
| ^
and:
modules/mono/utils/string_utils.cpp: In function 'int {anonymous}::sfind(const String&, int)':
modules/mono/utils/string_utils.cpp:68:48: error: logical 'or' of collectively exhaustive tests is always true [-Werror=logical-op]
found = src[read_pos] == 's' || (c >= '0' || c <= '4');
~~~~~~~~~^~~~~~~~~~~
2019-05-02 11:11:52 +02:00
cd4449e7ab
Add FileAccess::set_unix_permissions for Unix platforms
2019-04-07 15:45:30 -03:00
65f3a953de
Remove SIGCHILD handle in OS_Unix, interferes with pclose()
2019-04-07 15:45:00 -03:00
0bcf0314f7
Fix jump over uninitialized value in OS Unix/X11
2019-04-09 15:12:55 +02:00
9c3ddf05cb
Revert accidental commits
...
This reverts commit fb37284c024db0f51b9a
2019-03-20 21:43:55 +01:00
fb37284c02
Create class for shared memory blocks [wip]
2019-03-20 20:44:43 +01:00
372152220b
Merge pull request #26159 from marxin/fix-Wsuggest-attribute=format
...
Fix -Wsuggest-attribute=format warnings.
2019-02-27 09:23:26 +01:00
e5f665c718
Fix -Wsign-compare warnings.
...
I decided to modify code in a defensive way. Ideally functions
like size() or length() should return an unsigned type.
2019-02-27 07:45:57 +01:00
aff84ec55d
Fix -Wsuggest-attribute=format warnings.
2019-02-27 06:56:50 +01:00
5fc86026ca
Fix typos with codespell
...
Using codespell 1.14.0.
Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
doubleclick
lod
nd
numer
que
te
unselect
EOF
$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-02-13 09:23:29 +01:00
9bd9d21358
Fix OS_Unix::set_environment
2019-02-04 00:44:37 +01:00
41873ffa88
Added set_environment to OS class
2019-02-03 05:38:47 +01:00
c3b0ee5941
Fix code style issues
2019-01-26 22:35:31 +01:00
6de04cf04c
Improve custom thread numbering for POSIX
...
We lazily assign new IDs to threads that do not have one. This is the case for threads not created by the Godot API.
2019-01-25 00:59:07 +01:00
6fa632b821
Add function to obtain filesystem type from DirAccess.
...
Change EditorFileSystem to not use directory modification times on FAT32, fixes #20946
2019-01-21 18:06:14 -03:00
b16c309f82
Update copyright statements to 2019
...
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
6770357e47
Android: Better identify thirdparty C/C++ code
...
- The `cpu-features.{c,h}` code was only used by chance by the webm
(libvpx) code, so I moved it there. It was actually introduced before
that and wasn't in use, and libvpx just happened to be able to
compile thanks to it being bundled.
It could potentially be compiled on the fly from the Android NDK, but
since we plan to replace the webm module by a GDNative plugin in the
near future, I went the bundling route.
- `ifaddrs_android.h` is already provided in the Android NDK as
`ifaddrs.h`, same as on other Unixes. Yet we cannot use it until we
up the min API level to 24, where `getifaddrs` is first defined.
I moved the files to `thirdparty/misc` and synced them with upstream
WebRTC (only indentation changes and removal of `static` qualifiers).
Also removes dropped thirdparty files from COPYRIGHT.txt after changes
in #24105 and #24145 .
2018-12-20 13:07:54 +01:00
84d060c768
Added OS.get_system_time_msecs()
2018-12-20 18:50:50 +09:00
08f22f1cf0
Moved member variables to initializer list
2018-12-11 18:33:01 -05:00
f2ae14f309
Attempt to avoid breaking people's workflows on the change from 8ba0d513fa
2018-11-27 18:13:36 -03:00
8ba0d513fa
Added missing path verification on Unix, closes #20762
2018-11-22 23:21:03 -03:00
1ef9e9ef6a
Properly accept wildcard when binding IPv4 socket.
...
Also never return null for is_ipv4 to avoid crashes due to engine bug.
(better to get an error and a broken socket then seeing your game crash)
2018-11-18 14:54:40 +01:00
7771fe5d4a
Merge pull request #23388 from eska014/html5-stubexec
...
Add proper stubs for OS_JavaScript::execute(), get_process_id(), kill()
2018-10-29 23:40:17 +01:00
5c2c47a174
Add proper stubs for OS_JavaScript::execute(), get_process_id(), kill()
...
Avoids linker warnings and errors about undefined references.
2018-10-29 21:41:59 +01:00
fe93bb03fe
Server platform works on OS X too
2018-10-29 12:54:51 -03:00
12124d2d44
Safer getcwd in DirAccess
...
Fix [-Wunused-result]
2018-10-07 14:50:14 +02:00
5393e7310d
Avoid possible overflow in OS_Unix readlink
...
Also fix [-Wunused-result]
2018-10-07 12:56:07 +02:00
5f45476dc1
Fix warnings in HTML5 build outside platform files
2018-10-06 00:08:17 +02:00
97b9697ea2
Fix some OSX and iOS Clang warnings
...
Fixes the following XCode 9.4.1 warnings:
```
core/os/memory.cpp:175:13: warning: unused variable 's' [-Wunused-variable]
drivers/coremidi/core_midi.cpp:68:14: warning: comparison between NULL and non-pointer ('MIDIEndpointRef' (aka 'unsigned int') and NULL) [-Wnull-arithmetic]
drivers/gles2/rasterizer_gles2.cpp:77:24: warning: unused function '_gl_debug_print' [-Wunused-function,34]
drivers/unix/thread_posix.cpp:106:12: warning: unused variable 'running_thread' [-Wunused-variable,34]
modules/gdnative/nativescript/nativescript.h:371:16: warning: in-class initialization of non-static data member is a C++11 extension [-Wc++11-extensions]
platform/iphone/gl_view.mm:56:14: warning: unused variable 'video_previous_volume' [-Wunused-variable,34]
platform/iphone/gl_view.mm:251:12: warning: unused function 'get_first_id' [-Wunused-function,34]
platform/iphone/main.m:45:15: warning: unused variable 'app' [-Wunused-variable,34]
platform/osx/os_osx.mm:79:15: warning: unused function 'convertRectToBacking' [-Wunused-function]
```
2018-10-04 11:50:16 +02:00
d952126caf
Fix warnings in Android platform
...
Fixes the following Clang 7 warnings:
```
platform/android/os_android.h:240:16: warning: 'OS_Android::native_video_play' hides overloaded virtual function [-Woverloaded-virtual]
platform/android/os_android.h:241:15: warning: 'OS_Android::native_video_is_playing' hides overloaded virtual function [-Woverloaded-virtual]
platform/android/audio_driver_opensl.cpp:104:3: warning: suggest braces around initialization of subobject [-Wmissing-braces]
platform/android/audio_driver_opensl.cpp:129:10: warning: unused variable 'numOutputs' [-Wunused-variable]
platform/android/audio_driver_opensl.cpp:130:11: warning: unused variable 'deviceID' [-Wunused-variable]
platform/android/java_glue.cpp:795:10: warning: unused variable 'clsio' [-Wunused-variable]
platform/android/java_glue.cpp:890:12: warning: unused variable 'gob' [-Wunused-variable]
platform/android/java_glue.cpp:592:13: warning: unused variable 'resized' [-Wunused-variable]
platform/android/java_glue.cpp:593:13: warning: unused variable 'resized_reload' [-Wunused-variable]
modules/mobile_vr/mobile_vr_interface.cpp:401:8: warning: unused variable 'aspect_ratio' [-Wunused-variable]
drivers/unix/dir_access_unix.cpp:394:2: warning: THIS IS BROKEN [-W#warnings]
```
2018-10-03 15:17:00 +02:00
d0a5ac577f
Fix OS X get_ticks_usec return value after #22424
2018-09-30 13:06:46 -03:00
460e3376a4
Use monotonic clock for get_ticks_usec
...
Static _clock_start and _clock_setup function.
Use clock_gettime on Unix, mach_absolute_time on Mac.
2018-09-29 21:54:48 +02:00
3a2ca68af3
SCons: Build thirdparty code in own env, disable warnings
...
Also remove unnecessary `Export('env')` in other SCsubs,
Export should only be used when exporting *new* objects.
2018-09-28 14:07:39 +02:00
9d9a14e289
Remove socket_helper.h after NetSocket refactor
2018-09-28 02:03:23 +02:00
bca2d3ad40
Fix invalid comparison warnings: [-Wbool-compare] and [-Wenum-compare]
...
Fixes the following GCC 5 warnings and actual bugs:
```
drivers/unix/net_socket_posix.cpp:562:28: warning: comparison between 'enum IP::Type' and 'enum NetSocket::Type' [-Wenum-compare]
modules/gdscript/gdscript_function.cpp:792:26: warning: comparison of constant '17' with boolean expression is always true [-Wbool-compare]
modules/gdscript/gdscript_function.cpp:792:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
modules/gdscript/gdscript_parser.cpp:5082:58: warning: comparison of constant '6' with boolean expression is always false [-Wbool-compare]
modules/gdscript/gdscript_parser.cpp:5082:58: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
modules/mbedtls/stream_peer_mbed_tls.cpp:286:45: warning: comparison between 'enum StreamPeerTCP::Status' and 'enum StreamPeerSSL::Status' [-Wenum-compare]
modules/mbedtls/stream_peer_mbed_tls.cpp:313:45: warning: comparison between 'enum StreamPeerTCP::Status' and 'enum StreamPeerSSL::Status' [-Wenum-compare]
```
2018-09-27 16:25:24 +02:00
c37442ef00
Fix Winsock UDP ECONNRESET/ENETRESET bug
...
Since Windows 2000:
Calling recv/recvfrom when an ICMP reply was received from a previous
send/sendto, may result in a WSAECONNRESET error.
Since Windows Vista(?)/Windows Server 2008:
Calling recv/recvfrom when an ICMP reply was received from a previous
send/sendto, may also result in a WSAENETRESET error.
Both those features are disabled by this commit using disabling
SIO_UDP_CONNRESET and SIO_UDP_NETRESET on newly created UDP sockets.
2018-09-22 04:09:42 +02:00
479d4fb741
Detect POLLERR revents too in NetSocketPosix.
...
Usually indicate an RST was received by a TCP socket.
2018-09-22 01:40:58 +02:00
a15db2d2b6
Use select instead of WSAPoll on Windows.
...
WSAPoll is broken by design.
It was announced as the new way to introduce compatibility to posix
sockets, their implementation was broken, and they decided not to fix it.
You can read the full story here:
https://daniel.haxx.se/blog/2012/10/10/wsapoll-is-broken/
2018-09-22 01:40:58 +02:00
01c3c1a07b
Properly initialize Winsock on startup
...
Also fix typo in _get_last_error which caused Winsock connect to fail.
2018-09-13 16:05:47 +02:00
1a16dabfb5
Merge pull request #21982 from luzpaz/misc-typos
...
Misc. typos
2018-09-13 10:59:00 +02:00
08bde5b2de
Misc. typos
...
Found via `codespell -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"`
2018-09-12 21:39:17 -04:00
30327872e0
Unify StreamPeerTCP/TCP_Server with NetSocket API
2018-09-12 15:56:20 +02:00
1b99806b47
Unify PacketPeerUDP using NetSocket
2018-09-12 15:56:16 +02:00
b4e3be7519
New NetSocket interface, BSD/Win implementation
...
Unified BSD and Winsock sockets into a single implementation of a
generic NetSocket interface.
This is some ground work for few network improvements:
- Reuse as much code as possible between Posix and Windows.
- Provide a single point of implementation for exotic sdks (consoles).
- Provide platform agnostic StreamPeerTCP and PacketPeerUDP in core.
- Implement connect for UDP allowing for DTLS implementation.
2018-09-12 15:46:37 +02:00
7de28be764
ENet wrapper properly detect disconnect on poll
...
Now PacketPeerUDP.get_available_packet_count() return -1 if the socket
is in error state.
2018-09-12 12:50:53 +02:00
d3108985e0
Properly reset socket blocking state on close
2018-09-12 12:50:53 +02:00
277b24dfb7
Make core/ includes absolute, remove subfolders from include path
...
This allows more consistency in the manner we include core headers,
where previously there would be a mix of absolute, relative and
include path-dependent includes.
2018-09-12 09:52:22 +02:00
72996df656
Revert "Try closing gracefully before terminating process"
2018-08-27 17:32:43 +02:00
de59fe04e7
Add print_verbose to print to stdout only in verbose mode
...
Equivalent of the cumbersome:
if (OS::get_singleton()->is_stdout_verbose())
print_line(msg);
2018-08-24 09:23:20 +02:00
ca1c851dbd
Try closing gracefully before terminating process
...
Use a Microsoft recommended way of process termination for the project
process run from the editor. This allows loaded DLLs to receive and handle
DLL_PROCESS_DETACH notification and cleanup any global state before the
process actually exits.
2018-08-20 22:41:06 +02:00
ea3d997f9d
Revert "added get_creation_time function for gdscript"
2018-08-10 13:29:49 -03:00
275e0d5ee4
Merge pull request #18914 from notwarp/master
...
added get_creation_time function for gdscript
2018-08-10 13:28:47 -03:00
69817232ff
Set SO_BROADCAST socket option for UDP sockets.
2018-06-05 12:14:18 +02:00
130fd6bcb8
Merge pull request #18279 from RandomShaper/allow-naive-http
...
Allow body-up-to-EOF HTTP responses
2018-05-26 19:58:39 +02:00
2587fcccee
Allow body-up-to-EOF HTTP responses
...
Implements the same heuristic as Curl (and web browsers): if no `Content-Length`, no `Connection: keep-alive` and no chunked transfer encoding, assume th rest of the data until EOF is the body, gracefully setting the HTTP client back to the disconnected state.
Theoretically, this is not compliant with HTTP 1.1, by which `keep-alive` is the default, but in practice, an explicit header is sent by servers.
2018-05-22 15:08:31 +02:00
d315b0fb8a
added get_creation_time function for gdscript
2018-05-16 00:50:57 +02:00
ce64c2a32e
Fix Linux/X11 build on ARMs.
2018-05-11 17:34:43 +03:00
c45f44d856
Local debugger fixes and extensions
...
- Adds q/quit option to console debugging
- Adds options (variable_prefix)
- Breaks into debugger with Ctrl-C in local debug mode (Unix/Windows)
- Added option to list all breakpoints
- Fixes add/remove breakpoint bug (invalid path parsing)
- Minor cleanup
2018-05-07 23:17:06 -04:00
cfd950382f
Merge pull request #18372 from Gamblify/largePckFix
...
Fix for large .pck files
2018-05-03 10:37:47 +02:00
8a7840a304
Fix for large .pck files
...
An error in unix file IO was causing crashes when getting the size of a file larger than max integer size
As ftell returns a long the fix is trivial
2018-05-03 10:13:25 +02:00
9834b690ae
Merge pull request #18334 from Faless/coverity_net
...
Various coverity scan fixes, WS FreeBSD fixes
2018-05-01 08:44:11 +02:00
8287441955
GDNative Unix: fix shared lib loading, dlopen expects leading ./ to interpret as relative path.
2018-04-28 14:36:35 +02:00
1c419531a0
Change ".." punctuation for "..." in editor strings ( #16507 )
2018-04-22 19:36:01 +02:00
03bf783f3c
Various coverity scan fixes for networking
...
Fix FreeBSD websocket compilation error
2018-04-21 15:36:41 +02:00
f05e24ed18
[DOCS] add HTTPRequest.request return values
2018-04-20 16:34:30 +07:00
25800ffb0e
Add RWLockDummy for NO_THREADS builds
2018-03-20 05:37:42 +01:00
9bc0503c91
Merge pull request #17376 from marcelofg55/file_get_path
...
Added File.get_path and File.get_path_absolute functions
2018-03-15 22:21:21 +01:00
a4e64c5454
Added File.get_path and File.get_path_absolute functions
2018-03-13 12:07:37 -03:00
a5476f8562
Merge pull request #16895 from Noshyaar/bmk
...
Fix get_drive (bookmarks) in linux not working
2018-03-13 14:01:21 +01:00
d780d774aa
Clean and expose get_audio/video_driver_* funcs on OS class
2018-03-04 14:18:05 -03:00
7e5b10b7d3
Fix get_drive (bookmarks) in linux not working
2018-02-21 23:31:50 +07:00
268d7c7c5b
[X11] Improving error detection in move_to_trash
2018-02-18 17:02:19 +01:00
d35e486228
Clean up some bad words from code comments
2018-02-17 16:00:39 +03:00
8315aa40cc
fix buffer write performance on Windows and Unix
2018-02-04 13:23:23 +01:00
87adf9cfba
Display set_nodelay to GDScript
...
Pass enabled arg
Rename set_nodelay to set_no_delay
Add description to the method
Change description
2018-01-30 13:22:15 -02:00
384055c86f
Fix use of execvp, earlier fix was short sighted and only worked
...
when godot could be found in PATH.
The correct fix is to use sysctl to get the path to the current executable
this also fixes the ability to call external commands.
2018-01-08 12:07:28 +10:30
e4213e66b2
Add missing copyright headers and fix formatting
...
Using `misc/scripts/fix_headers.py` on all Godot files.
Some missing header guards were added, and the header inclusion order
was fixed in the Bullet module.
2018-01-05 01:22:23 +01:00
6e2ed15ff1
Add support from properly exporting shared objects, needed for GDNative export
2018-01-04 15:43:06 -03:00
e315c94900
Change OS::initialize signature to return Error (fix segfault on x11)
2018-01-04 15:15:55 +01:00
d65ac7378c
Fix crash in OS::execute on FreeBSD
...
As spotted by @robfram, closes #15288 .
Also reviewed other uses of `if (String.find(.*))` for potential similar mistakes, found a wrong (and useless) one in ScriptEditorDialog.
2018-01-04 01:20:20 +01:00
b50a9114b1
Update copyright statements to 2018
...
Happy new year to the wonderful Godot community!
2018-01-01 14:40:47 +01:00
92067b4714
Remove "const" from PacketPeer get_packet/get_var
...
They are NOT constant methods, as state by the comment message,
they fetch the last packet and then forget about it, actively
changing the state of the object.
2017-12-15 17:14:17 +01:00
7908dc322a
Drop unused OS_Unix::has_data and related logic
...
Closes #5536 .
2017-12-10 17:05:24 +01:00
qarmin
Rémi Verschelde
Fabio Alessandrelli
Nils ANDRÉ-CHANG
hbina085
marxin
Juan Linietsky
Pedro J. Estébanez
Ignacio Etcheverry
volzhs
Wilson E. Alvarez
Leon Krause
Marcelo Fernandez
luz.paz
Marcin Zawiejski
Max Hilbrunner
Daniele Giuliani
bruvzg
Blazej Floch
Gustav Lund
Robin Hübner
Hugo Locurcio
Poommetee Ketson
Hein-Pieter van Braam
Iskustvo
Artem Varaksa
Marlon Henry Schweigert
sambler
Emmanuel Leblond