39ef611a7d
Fix theming code in Panel, SplitContainer, RichTextLabel
2022-09-06 22:53:19 +03:00
43f03e2ce6
Improve naming of theme properties throughout GUI code
...
Rename ItemList's bg -> panel
Rename ItemList's bg_focus -> focus
Rename ProgressBar's bg -> background
Rename ProgressBar's fg -> fill
Rename Tree's bg -> panel
Rename Tree's bg_focus -> focus
Rename ScrollContainer's bg -> panel
Rename FileDialog's *_icon_modulate -> *_icon_color
Rename FileDialog's files_disabled -> file_disabled_color
Rename CheckButton's on/off -> checked/unchecked
Rename check_v_adjust -> check_v_offset
2022-09-06 22:53:17 +03:00
dd26ecdd31
Rename CONNECT_ONESHOT TO CONNECT_ONE_SHOT
...
For consistency. Every other exposed `one_shot` is spaced out like this.
2022-09-06 19:00:33 +02:00
6dbd283ae5
Rename every instance of `caret_blink_speed` to `caret_blink_interval`
...
It's been changed in EditorSettings, LineEdit, TextEdit.
Affects setters and getters, and passed parameters, too.
2022-09-06 18:37:17 +02:00
49d18f0725
Merge pull request #65423 from YeldhamDev/i_want_to_ride_my_bycicle
...
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 17:00:58 +02:00
5062aafc2d
Merge pull request #64417 from aaronfranke/has-space
...
Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods
2022-09-06 17:00:44 +02:00
9507e91c07
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 10:51:14 -03:00
b6daad8d4b
Rename `range_lerp` to `remap`
2022-09-06 07:19:20 +02:00
b5c053321c
Merge pull request #64840 from maximkulkin/graph-edit-node-selection
...
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 08:36:10 +02:00
9a35ede23f
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 02:32:06 -04:00
1499840f75
Merge pull request #65028 from groud/fix_split_container
...
Improve SplitContainer behavior, keeping asked split position whenever possible
2022-09-05 08:30:11 +02:00
995b9f94e8
Replace Rect2(i) has_no_area with has_area
2022-09-04 23:03:36 -05:00
597bc949a4
Merge pull request #65250 from YuriSizov/theme-owner-rises
2022-09-02 23:20:49 +02:00
77ca96fd73
Merge pull request #59589 from Calinou/rename-or-lesser-range-property-hint
2022-09-02 23:13:20 +02:00
8b128081e8
Un-defer the initial theme changed notification
...
Co-authored-by: Rindbee <idleman@yeah.net>
2022-09-02 23:44:23 +03:00
ddc55ef746
Add ThemeOwner type for managing theme propagation and lookup
2022-09-02 23:44:23 +03:00
33b4153764
Merge pull request #64917 from Tim-Fronsee/fix/add-gutter-total-width
2022-09-02 20:52:11 +02:00
2ddda13339
Improve SplitContainer behavior, keeping asked split whenever possible
2022-09-02 20:48:50 +02:00
f7292dbeb3
Rename `or_lesser` range property hint to `or_less`
...
"less" should be used for quantity, rather than "lesser".
Existing scripts that use `or_lesser` in `_get_property_list()`
will need to be updated to account for this change.
2022-09-02 19:08:20 +02:00
fe2cf6e406
Merge pull request #65210 from YuriSizov/control-customizable-cache-p3
2022-09-02 13:51:52 +02:00
c82bbc38a5
Merge pull request #64952 from Chaosus/vs_rename_uniform_to_param
2022-09-02 13:49:53 +02:00
fc7cef8dec
Fix theme propagation in various parts of the editor
2022-09-02 13:18:31 +03:00
5a136ee490
Merge pull request #64724 from KoBeWi/HVBoxContainer
2022-09-02 08:44:42 +02:00
15d057c521
Add `is_zero_approx` methods to `Vector2`, `3`, and `4`
2022-09-02 00:29:50 -04:00
7e3afc3d09
Merge pull request #65213 from Mickeon/fix-label-visible-ratio
2022-09-01 23:49:28 +02:00
5263fd5343
Merge pull request #64198 from Geometror/add-bitmap-tests
2022-09-01 23:46:38 +02:00
73929bef73
Rework oriented containers
2022-09-01 22:13:46 +02:00
511134f55f
Fix Label & RichTextLabel's visible_ratio not working
2022-09-01 19:22:12 +02:00
8c7be63588
Merge pull request #65192 from YuriSizov/control-customizable-cache-p2
2022-09-01 19:09:33 +02:00
dcd74563b6
Merge pull request #65156 from YuriSizov/control-customizable-cache-p1
2022-09-01 19:08:02 +02:00
ea0472fecf
Refactor BitMap and add tests
...
Co-authored-by: Resul Çelik <resul_celik@hotmail.com>
2022-09-01 18:39:17 +02:00
027415312e
Merge pull request #65132 from bruvzg/global_menu_shortcuts_context
2022-09-01 17:02:04 +02:00
3b1aa240dc
Add a lifecycle method for manual theme item caching to Control
2022-09-01 16:35:36 +03:00
15fd025f90
Add dumb and manual theme caching systems to Window
2022-09-01 16:05:02 +03:00
8191b3c110
Rename `uniform` to `parameter` across the engine
2022-09-01 11:42:57 +03:00
0a34994720
Merge pull request #65117 from YeldhamDev/menubar_key_fix
...
Fix switching `MenuBar`'s menus with the keys while mouse hovering
2022-09-01 08:46:01 +02:00
d22f2612f9
Merge pull request #65162 from YuriSizov/editor-gradients-united
...
Unite `GradientEdit` and `GradientEditor` as editor-only widget
2022-09-01 08:30:16 +02:00
b85a4c5d79
[macOS] Handle accelerator and click events of the global menu items separately.
2022-09-01 08:13:56 +03:00
7aad14a4b6
[TextServer] Add support for trimming edge spaces on line break.
2022-09-01 08:11:55 +03:00
93078ea551
Unite GradientEdit and GradientEditor as editor-only widget
2022-08-31 23:45:04 +03:00
97c0b0c74a
Fixes #64962 that cause program run into infinite loop
2022-09-01 01:26:08 +07:00
e5c183b01e
Fix TextEdit::gutters_width (total gutter width) when adding & removing a gutter by calling TextEdit::_update_gutter_width in TextEdit::add_gutter & TextEdit::remove_gutter
...
Update TextEdit gutters subcase, gutter add and remove to ensure gutter total width is correct
Fix test_code_edit symbol lookup test case to include padding (+2)
2022-08-31 10:01:40 +09:00
9e0de4e2cb
Fix switching `MenuBar`'s menus with the keys while mouse hovering
2022-08-30 20:18:35 -03:00
e27b61d291
Merge pull request #65042 from YuriSizov/editor-docks-tabbar-bg
2022-08-30 18:53:54 +02:00
ae349d8227
Merge pull request #64377 from Mickeon/rename-canvas-redraw
...
Rename `CanvasItem.update()` to `queue_redraw()`
2022-08-30 14:47:41 +02:00
ebe4f8d3a4
Merge pull request #65039 from Mickeon/rename-treeitem-tooltip
2022-08-30 14:05:08 +02:00
97f8c9b97c
Rename TreeItem's `set_tooltip` to `set_tooltip_text`
...
`set_tooltip` -> `set_tooltip_text`
`get_tooltip` -> `get_tooltip_text`
For consistency:
`get_button_tooltip` -> `get_button_tooltip_text`
And the `tooltip` parameter in `add_button` was renamed to `tooltip_text`
2022-08-30 11:16:23 +02:00
10a56981dc
Rename String `plus_file` to `path_join`
2022-08-29 19:38:13 -05:00
8b196be855
Add background to TabContainer's tabbar and editor docks
2022-08-29 23:43:32 +03:00
e31bb5ffeb
Rename `CanvasItem.update()` to `queue_redraw()`
...
Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on.
Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency.
Just a few comments have also been changed to say "redraw".
In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-29 14:59:47 +02:00
e60086f98b
Merge pull request #64119 from YuriSizov/theme-init-database
2022-08-29 14:02:21 +02:00
fd6453c45e
Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED"
...
This reverts commit 4b817a565cFixes #64988 .
Fixes #64997 .
This caused several regressions (#64988 , #64997 ,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605 )
which point at a flaw in the current logic:
- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
`NOTIFCATION_THEME_CHANGED` as introduced in #62845 .
- Some classes use their `THEME_CHANGED` to cache theme items in
member variables (e.g. `style_normal`, etc.), and use those member
variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
notification is now deferred, they end up accessing invalid state and this
can lead to not applying theme properly (e.g. for EditorHelp) or crashing
(e.g. for EditorLog or CodeEdit).
So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?
Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
does arrive for the first time. But that means having a temporary invalid
(and possibly still crashing) state, and doing some computations twice
which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-29 11:11:29 +02:00
223e083d36
Merge pull request #64964 from MewPurPur/reorganize-label-properties
...
Reorganize Label and RichTextLabel properties
2022-08-29 09:52:04 +02:00
f647292df5
Merge pull request #64960 from YeldhamDev/more_hl_stuff
2022-08-29 08:05:33 +02:00
34f45d7b28
Merge pull request #64967 from YeldhamDev/pm_up_fix
2022-08-29 07:56:03 +02:00
93cf259834
Merge pull request #64972 from YeldhamDev/you_too_menubar
2022-08-29 07:55:46 +02:00
f7f8af232c
Merge pull request #64885 from Mickeon/rename-tooltip-hint
...
Rename `hint_tooltip` to `tooltip_text` & setter getter
2022-08-28 17:43:01 +02:00
832950d1f2
Reorganized Label and RichTextLabel properties
2022-08-28 10:26:04 +02:00
44c64b912f
Add item auto-highlighting to `MenuBar`
2022-08-28 01:49:22 -03:00
221344b9e2
Fix some corner cases in the `Menu/OptionButton` item auto-highlight
2022-08-28 01:15:03 -03:00
06df59887b
Fix crash when pressing up on an empty `PopupMenu`
2022-08-27 18:13:27 -03:00
d3db8bbebd
Merge pull request #62846 from AaronRecord/remove_redundant_theme_updates_in_enter_tree
...
Remove `NOTIFICATION_ENTER_TREE` when paired with `NOTIFICATION_THEME_CHANGED`
2022-08-27 21:56:14 +02:00
4b817a565c
Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED
2022-08-27 11:52:29 -06:00
f9998455ce
Merge pull request #63249 from V-Sekai/animation_tree_editor_read_only
...
Add read-only mode to AnimationTreeEditor plugins
2022-08-27 08:14:30 +02:00
ef5b9a06a9
Rename `hint_tooltip` to `tooltip_text` & setget
...
`hint_tooltip` -> `tooltip_text`
`set_tooltip` -> `set_tooltip_text`
`_get_tooltip` -> `get_tooltip_text`
Updates documentation, too.
2022-08-27 01:35:01 +02:00
f9f2446972
Merge pull request #64367 from Mickeon/rename-var-to-str
...
Rename `str2var` to `str_to_var` and similar
2022-08-26 23:04:06 +02:00
4f60fd0480
Merge pull request #64777 from bruvzg/extend_to_title
...
[macOS] Extend editor contents to the window title bar for better space usage.
2022-08-26 23:03:31 +02:00
6320a0fc18
Add ThemeDB, expose previously static Theme methods
2022-08-26 19:23:05 +03:00
ecfff5b75e
Revert SplitContainer minimum size splitting changes ( #64676 and #64800 )
...
This reverts commits 185b1a5bd319ad31b89f#43749 .
Fixes #64785 .
Fixes #64851 .
Fixes #64866 .
2022-08-26 15:57:17 +02:00
59e11934d8
Rename `str2var` to `str_to_var` and similar
...
Affects the Math class, a good chunk of the audio code, and a lot of other miscellaneous classes, too.
- `var2str` -> `var_to_str`
- `str2var` -> `str_to_var`
- `bytes2var` -> `bytes_to_var`
- `bytes2var_with_objects` -> `bytes_to_var_with_objects`
- `var2bytes` -> `var_to_bytes`
- `var2bytes_with_objects` -> `var_to_bytes_with_objects`
- `linear2db` -> `linear_to_db`
- `db2linear` -> `db_to_linear`
- `deg2rad` -> `deg_to_rad`
- `rad2deg` -> `rad_to_deg`
- `dict2inst` -> `dict_to_inst`
- `inst2dict` -> `inst_to_dict`
2022-08-26 14:58:22 +02:00
c8ef12a03a
Merge pull request #64665 from Mickeon/rename-label-visible
2022-08-26 14:54:37 +02:00
bc4ba6cb78
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-26 15:12:43 +03:00
ff612b6916
Merge pull request #64574 from Begah/fix_transient_window_wrap_mouse
2022-08-26 13:54:23 +02:00
0c639428dd
Merge pull request #64529 from KoBeWi/suffix_begone
2022-08-26 13:39:14 +02:00
64bd36ecee
Rename Label & RichTextLabel.`percent_visible` to `visible_ratio`
...
Also updates the documentation of both `visible_characters` and `visible_ratio` to, better describe what they do and improve consistency between the two Classes.
2022-08-26 12:15:57 +02:00
ac7b5111f5
Merge pull request #64768 from bruvzg/popups_hide_if_visible
2022-08-26 11:59:50 +02:00
fed1189099
Merge pull request #62771 from bruvzg/line_edit_trim
2022-08-26 11:43:28 +02:00
74eb2a70bd
Refactor and remove excessive calls of `NOTIFICATION_THEME_CHANGED`
2022-08-25 14:50:49 -06:00
75f1357ced
Add read-only mode to AnimationTreeEditor plugins
2022-08-25 16:29:36 +01:00
5ac5c8bc06
Fix warp_mouse for transient windows, smoother mouse positioning when releasing mouse for spinbox
2022-08-25 11:30:49 +02:00
0a5f5c8558
Merge pull request #64536 from Mickeon/editor-tree-icon-size
...
Account for TreeItem's Cell icon and center the text Popup vertically
2022-08-25 09:56:08 +02:00
1adcd0327f
Merge pull request #64806 from Zylann/graph_node_protected_validate_property
...
Make GraphNode::_validate_property protected so GraphNode can be inherited
2022-08-25 07:30:42 +02:00
efedef8eb1
Merge pull request #64837 from YuriSizov/control-disconnect-from-everything-and-free-yourself
...
Disconnect Control from theme resources to avoid issues on destruction
2022-08-25 00:04:17 +02:00
22fcdffd17
Make GraphNode::_validate_property protected so GraphNode can be inherited.
...
It's not about overriding or accessing `_validate_property`,
but since `_validate_property` became a multilevel method,
the GDCLASS macro now tries to access the one from the parent class,
which causes a compiling error if the parent class declares
`_validate_property` as private.
2022-08-24 21:29:32 +01:00
b7d2ba12c8
Merge pull request #64635 from YeldhamDev/menu_buttons_popup_fix
...
Make `Menu/OptionButton` item auto-highlight behave better
2022-08-24 19:07:25 +02:00
bb5fa91a6b
Disconnect Control from theme resources to avoid issues on destruction
2022-08-24 18:50:04 +03:00
4698dc67b5
Merge pull request #64082 from KoBeWi/array3k
2022-08-24 16:05:59 +02:00
5d14d08702
Merge pull request #59226 from Rindbee/better-setters-in-gui-controls
...
Improve the setters in gui, return directly if the value does not change.
2022-08-24 17:03:54 +03:00
78f3e4cb6a
Merge pull request #64369 from derammo/derammo_tree_right_click_title
...
Replace Tree control left click on title signal with new signal for either left or right click
2022-08-24 16:16:53 +03:00
0ba2e999df
implemented right click on Tree control header
2022-08-24 08:10:40 -04:00
f7f4873ed0
Replace Array return types with TypedArray 3
2022-08-24 12:53:36 +02:00
c3a8ec3cbb
Merge pull request #64800 from KoBeWi/split_hax
...
Handle child control size changes in SplitContainer
2022-08-24 09:50:46 +02:00
854eb58074
Merge pull request #64783 from bruvzg/fix_rtl_min_size
...
Fix RTL min. size not triggering text cache update.
2022-08-24 09:49:00 +02:00
91e5f48ea7
Merge pull request #64009 from KoBeWi/arrayy_lmao
...
Replace Array return types with TypedArray (part 2)
2022-08-24 08:18:56 +02:00
1abdffe7a0
Replace Array return types with TypedArray 2
2022-08-23 23:21:32 +02:00
19ad31b89f
Handle child control size changes in SplitContainer
2022-08-23 20:41:10 +02:00
bbe8d2b03e
Merge pull request #64767 from bruvzg/meta_click
2022-08-23 18:15:44 +02:00
e561c68256
Add some codes, returnes directly if the value is not changed.
...
Avoid executing the following value-changed logics if the value does not really change.
2022-08-23 23:25:22 +08:00
f02d45ce0c
Fix RTL min. size not triggering text cache update.
2022-08-23 16:27:45 +03:00
11506eb24d
Merge pull request #64676 from KoBeWi/split_and_conquer
2022-08-23 10:28:09 +02:00
Yuri Sizov
Micky
Rémi Verschelde
Michael Alexsander
Maxim Kulkin
Aaron Franke
Rémi Verschelde
Gilles Roudière
Hugo Locurcio
Jonathan Nicholl
kobewi
Hendrik Brucker
Yuri Rubinsky
bruvzg
Nong Van Tinh
Tim Fronsee
VolTer
Aaron Record
SaracenOne
MathieuRoux
Marc Gilleron
Yuri Sizov
derammo
风青山