8dad5f1e10
Update controls when a stylebox or icon override changes; change to CONNECT_REFERENCE_COUNTED
...
Also, cleanup unnessesary calls to update() and NOTIFICATION_THEME_CHANGED.
Fixes #25904 .
2019-02-25 17:42:38 +02:00
74d0ed2236
Many separate fixes to ensure non power of 2 textures work on GLES2, closes #25897 and many others
2019-02-24 22:36:53 -03:00
bffe97c110
Use sun energy for ProceduralSky generation
2019-02-24 17:12:35 -08:00
a83e77fded
Explicitly use floating point numbers in the our shaders
...
We need to be explicit about using floating point numbers in our shaders
for compatibility with mobile GLES drivers.
2019-02-24 23:35:10 +00:00
3ea04c1366
Prevent circular references to scene being saved, fixes #24384
2019-02-24 10:48:38 -03:00
bfa9be85d3
Remove copy and use instance material override in gizmos, fixes #23783
2019-02-23 20:20:54 -03:00
6cd4006fb3
Do not crash on empty path, closes #23701
2019-02-23 20:07:16 -03:00
fd68bb2596
-Treat scalar conversions when calling functions as error, closes #24261
...
-Make shader editor display errors if exist when just opening it
-Make ShaderMaterial not lose parameters if opened in error.
2019-02-23 17:55:09 -03:00
9dfe3b6d9e
Ensure move and slide snap respects stop on slope, fixes #26180
2019-02-23 10:24:21 -03:00
a291c837f0
Merge pull request #26157 from YeldhamDev/splitcont_update_check
...
Make 'SplitContainer' update drawing only if actually needs to
2019-02-23 10:36:09 +01:00
4f697f73a5
Change MAX for MIN, fixes #26170
2019-02-22 21:19:31 -03:00
7f63b0e8cd
Added a workaround to avoid crashes due to how TileSet editor works, fixes #23672
...
Also fixed a few uninitialized memory variables.
2019-02-22 17:42:29 -03:00
aab8f443f9
-Support DEPTH_TEXTURE in GLES2, fixes #25106
...
-Fix use of transparent framebuffers in GLES2
-Fix use of ambient color clearing in GLES2 when no environment exists.
2019-02-22 11:35:39 -03:00
52abab5aa7
Make 'SplitContainer' update drawing only if actually needs to
2019-02-22 10:12:39 -03:00
edbf1d0ea4
Check that area is inside tree besides checking that queries are flushed, fixes #26148
2019-02-22 09:05:34 -03:00
5f5f338e3f
Merge pull request #26146 from YeldhamDev/splitcont_hover_fix
...
Fix 'SplitContainer's showing their handles when they shouldn't
2019-02-22 10:02:06 +01:00
c4b736d7ad
Fix code style issues
2019-02-22 09:52:27 +01:00
60fe9321ac
Merge pull request #26099 from marxin/fix-Wtype-limits-warnings
...
Fix all -Wtype-limits warnings.
2019-02-22 09:44:59 +01:00
f2f09f00b7
Fix 'SplitContainer's showing their handles when they shouldn't
...
Fixes #25735 .
2019-02-21 23:01:30 -03:00
8b231b96e3
Implement a cleaner (and better) way to save imagedata from ImageTexture, fixes #18801
2019-02-21 20:49:42 -03:00
05f5774592
Use correct meta item in rich text.
...
Prevent incorrect static cast and unnecesarry meta_hover_ended/started
events.
2019-02-22 00:23:05 +02:00
87b303aa95
Fixed bugs in test body motion and removed unnecesary test in move_and_slide. Fixes #25968
2019-02-21 17:21:36 -03:00
7de7f0ef17
Fix all -Wtype-limits warnings.
2019-02-21 19:34:35 +01:00
47c4ec7f1d
Merge pull request #26105 from nekomatata/texture-button-mask-fix
...
TextureButton with click mask only can be clicked
2019-02-21 14:48:43 +01:00
f07dfe8a3f
Fixed TextureButton click mask when no other texture is set
2019-02-21 01:11:56 +01:00
16934c7411
Merge pull request #26068 from luizcarlos1405/master
...
Fix AnimationPlayer jumping to the beggining after ending on editor.
2019-02-20 22:30:41 +01:00
e27bbb075a
Fix AnimationPlayer jumping to the beggining after ending on editor.
2019-02-20 14:58:53 -04:00
8d51618949
Add -Wshadow=local to warnings and fix reported issues.
...
Fixes #25316 .
2019-02-20 19:44:12 +01:00
9714f701c5
Merge pull request #26089 from ianb96/word_wrap_cutoff_fix
...
Fix word wrap cutoff and tab wrapping issue
2019-02-20 16:28:43 +01:00
6709ff6a96
Merge pull request #26049 from vixelz/textureprogress-nineslice-fill-fix
...
Truncate first segment in TextureProgress 9slices
2019-02-20 15:23:31 +01:00
39f537e481
Fix word wrap cutoff and tab wrapping issue
2019-02-20 08:52:33 -05:00
86374c0431
Allow moving LineEdit visible window left by more than one symbol.
2019-02-19 23:59:09 +02:00
559b8fd236
Truncate first segment in TextureProgress 9slices
...
Much in the way that TextureProgress was truncating the last segment
of the nine slice when the value wasn't close to the end, perform
similar work on the beginning segment. This fixes the beginning segment
always being drawn, sometimes in the incorrect location.
2019-02-19 08:28:32 +00:00
0fa3b80850
Merge pull request #26025 from clayjohn/particles_lifetime
...
Allowing setting particles lifetime greater than 600
2019-02-18 21:20:24 +01:00
0fec83bc92
allowing setting particles lifetime greater than 600
2019-02-18 10:46:41 -08:00
b31e1b84fc
Fix AudioStreams::stop possibly causing a small noise
2019-02-17 11:20:10 -03:00
623f7b64ae
Updat polygons when skeleton setup changes, fixes #25949
2019-02-16 20:08:17 -03:00
a034cac583
Merge pull request #25953 from nekomatata/fix-radial-texture-progress
...
Fixed TextureProgress in Radial Mode when using center offset
2019-02-16 22:26:06 +01:00
1974f6995f
Fixed radial progress with center offset by taking distance to edge into account in uv calculation
2019-02-16 21:02:29 +01:00
bf53132217
Merge pull request #25931 from qarmin/fix_copy_readonly
...
Fix copy text when TextEdit is readonly
2019-02-16 20:00:24 +01:00
0cee7ab4c9
Change snapping to only happen when the floor normal remains as floor, fixes #22312
2019-02-16 15:50:31 -03:00
ee464f56c4
Add a minimum treshold for acquiring rest contacts to avoid numerical precision issues. Fixes #25074
2019-02-16 13:45:01 -03:00
c54330c6b0
Make sure stop on slope can have a tiny bit of precision edge.
2019-02-16 11:19:47 -03:00
2293559c9f
Merge pull request #25888 from marxin/fix-25217-part-2
...
Fix 2 more UBSAN issues (#25217 ).
2019-02-16 12:45:18 +01:00
7a254b303b
Fix copy text when TextEdit is readonly
2019-02-16 07:56:24 +01:00
fe7d2dc4d3
Revert "Fix MenuButton item label disappearing when setting shortcut."
2019-02-15 11:44:27 +01:00
3f74a54cd4
Merge pull request #25894 from marcelofg55/last_mouse_focus_crash
...
Fix possible crash with an invalid last_mouse_focus pointer
2019-02-15 09:27:32 +01:00
e7e4d41a29
Merge pull request #25841 from Awkor/menubutton-fix
...
Fix MenuButton item label disappearing when setting shortcut.
2019-02-15 09:10:05 +01:00
761caac0b2
Fix possible crash with an invalid last_mouse_focus pointer
2019-02-14 22:16:56 -03:00
3236c9a0e7
Fix MenuButton item label disappearing when setting shortcut.
2019-02-14 23:17:29 +01:00
7ae160f661
Fix 2 more UBSAN issues ( #25217 ).
2019-02-14 20:47:35 +01:00
5ec4f14a24
Fix AnimationPlayer bug where it wouldn't reset its position when finished
2019-02-14 15:32:29 -03:00
4a24ba6e77
-Fixes to undo redo to avoid crash, closes #24251
...
-Changed Animation to have a special signal when tracks are changed, to avoid unnecesary track cache rebuilds in AnimationPlayer
-Added missing emit_changed whe modifying keys to Animation
-Changed AnimationPlayer to use the new refcounted connections instead of the previous hacky way to keep references
-Changed AnimationEditor to update the current track when keys are edited
-Fixed bug where undo/redo did not work with AnimationKeyEdit (was not being updated)
-Made sure UndoRedo does not mind deleted objects in undo/redo history, this would corrupt the history or clear it without need.
2019-02-14 10:22:34 -03:00
6b184e4d3b
Merge pull request #25717 from nekomatata/dynamic-font-settings-fix
...
Fixed undefined behavior when loading dynamic font settings
2019-02-14 12:54:33 +01:00
325efb60b7
Merge pull request #25776 from luizcarlos1405/master
...
Fixes some AnimationPlayer bugs
2019-02-13 20:34:35 +01:00
b340b7e804
Merge pull request #25422 from azagaya/optionbutton
...
Fix docs about item_selected and item_focused . Fixes #25273
2019-02-13 20:31:53 +01:00
06a0a29711
Fix some AnimationPlayer bugs and update documentation
2019-02-13 14:40:22 -03:00
f48829d1a4
Fix button alignment of Package Installer on OSX
...
This problem occurs only in the HiDPI environment.
2019-02-13 23:52:14 +09:00
5fc86026ca
Fix typos with codespell
...
Using codespell 1.14.0.
Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
doubleclick
lod
nd
numer
que
te
unselect
EOF
$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-02-13 09:23:29 +01:00
55ca2a7c88
Merge pull request #25821 from akien-mga/sync-class-and-filenames
...
Ensure classes match their header filename
2019-02-13 08:49:39 +01:00
9418f6a557
Fixed undefined setting values when loading dynamic fonts
2019-02-12 23:21:48 +01:00
67eda1d4dd
Fix state machine priority for auto advance
2019-02-12 15:57:26 -02:00
c5dcbeb160
Scene: Ensure classes match their header filename
...
Also drop some unused files.
Renamed:
- `scene/2d/navigation2d.h` -> `navigation_2d.h`
- `scene/2d/screen_button.h` -> `touch_screen_button.h`
- `scene/3d/scenario_fx.h` -> `world_environment.h`
- `scene/audio/audio_player.h` -> `audio_stream_player.h`
- `scene/resources/bit_mask.h` -> `bit_map.h`
- `scene/resources/color_ramp.h` -> `gradient.h`
- `scene/resources/shape_line_2d.h` -> `line_shape_2d.h`
- `scene/resources/scene_format_text.h` -> `resource_format_text.h`
- `scene/resources/sky_box.h` -> `sky.h`
Dropped:
- `scene/resources/bounds.h`
2019-02-12 17:21:48 +01:00
dfe4990b18
Merge pull request #25496 from ptrojahn/lookat
...
Fix look_at with non uniform scaling
2019-02-12 13:41:42 +01:00
b7cc2bb1e2
Core: Ensure classes match their header filename
...
Also drop some unused files.
Renamed:
- `core/dvector.h` -> `pool_vector.h`
- `core/io/resource_import.h` -> `resource_importer.h`
- `core/sort.h` -> `sort_array.h`
- `core/string_db.h` -> `string_name.h`
Dropped:
- `core/allocators.h`
- `core/os/shell.h`
- `core/variant_construct_string.cpp`
2019-02-12 13:34:25 +01:00
fb8dce3e2e
Merge pull request #25602 from mcccclean/dont-ignore-listener-nodes
...
Fix 3D Listener nodes not being used
2019-02-12 12:30:50 +01:00
13c50e8aa5
Merge pull request #25481 from hpvb/fix-ubsan-asan-reports
...
Fix many asan and ubsan reported issues
2019-02-12 12:21:01 +01:00
f60e5efadd
Merge pull request #25725 from clayjohn/multimesh_transform_2d
...
Added ability to set_instance_transform_2d in multimesh
2019-02-12 11:35:42 +01:00
9c6f19117c
Merge pull request #25754 from JFonS/fix_25567
...
Fix canvas particle material for old GLSL versions
2019-02-12 11:25:32 +01:00
4d933b1530
Fix canvas particle material for old GLSL versions
2019-02-11 14:56:23 +01:00
7051685a77
Fixes differences between docs and item_selected and item_focused signals in optionbutton
...
Description in docs about item_selected and item_focused signals in optionbutton is fixed to match the real behaviour. Also, get_item_index function is added.
2019-02-11 08:52:09 -03:00
e322fd140e
Add disabled tab style
2019-02-10 18:12:17 -02:00
4fd7115e13
General cleanup of script and doc search bars
2019-02-10 14:18:08 -02:00
1aa7fc09eb
TSCN: Remove extra newline after [resource]/[ext_resource]
...
Some cases had been handled in #17602 , but those two were missed.
Fixes #24677 .
2019-02-10 16:58:45 +01:00
034cd62a77
Warn when using GPU particles with GLES2
...
Closes #25733 .
2019-02-09 20:49:58 +01:00
8908bdc7f2
Merge pull request #25653 from BastiaanOlij/fix_hide_skyrotation
...
Hide new sky properties if we don't have sky as a background
2019-02-09 13:09:39 +01:00
6d98ce281f
Merge pull request #25671 from vnen/physics-material-2d
...
Include PhysicsMaterial when 3D is disabled
2019-02-09 12:10:12 +01:00
20ff01b8e4
added ability to set instance_transform_2d in multimesh
2019-02-08 20:59:09 -08:00
e190589f3d
Merge pull request #25627 from clayjohn/visual_shader_texture_bug
...
Change hint_color to hint_albedo for sampler2ds
2019-02-08 20:19:28 +01:00
163cdb8954
Fix look_at with non uniform scaling
...
The angle function doesn't consider the scaling of the local coordinates,
so it needs to be removed first. Fixes #23247
2019-02-08 18:00:54 +01:00
17d92c2b09
Merge pull request #25551 from JFonS/fix_rogue_cpu_particles
...
Fix local_delta when resetting CPUParticles
2019-02-08 12:17:16 +01:00
3dd00e77b4
Merge pull request #25524 from Calinou/fix-font-oversampling-warning
...
Fix a font oversampling warning being printed when it shouldn't
2019-02-08 11:52:45 +01:00
9523403192
Merge pull request #25509 from bojidar-bg/25504-update-bitmask-crash
...
Fix crashes when calling update_bitmask_area
2019-02-08 11:16:38 +01:00
4ddefe9142
Merge pull request #25467 from fire/folding_spam
...
Add check in folding to see if the nodepath exists to avoid message spam and expose get_node_or_null
2019-02-08 10:13:36 +01:00
5743c7910a
Include PhysicsMaterial when 3D is disabled
...
It's still needed by 2D physics.
2019-02-06 19:23:44 -02:00
a7a21bd9fe
Fix particles animation on GLES2
2019-02-06 16:00:22 +01:00
8159ee93a7
Prefer a viewport's listener over a camera where available
...
Fix clang formatting issue
2019-02-06 21:43:57 +11:00
edc5628541
Hide new sky properties if we don't have sky as a background
2019-02-06 21:27:31 +11:00
25027d60f7
Merge pull request #25606 from Paulb23/fix_textedit_scroll_selection
...
Fixed selection being activated when using scroll lines.
2019-02-06 11:27:16 +01:00
b78a384921
change hint_color to hint_albedo for sampler2ds
2019-02-04 22:12:25 -08:00
1e3e770073
Add frame support for Sprite3D with region enabled
2019-02-04 20:31:45 -02:00
69374cd378
Fixed selection being activated when using scroll lines
2019-02-04 10:55:45 +00:00
fe6123fca4
Fix local_delta when resetting CPUParticles
2019-02-01 17:16:09 +01:00
37aa06bf8a
When an animationplayer sets a property on itself recreate the caches
...
this fixes #25507
2019-02-01 16:15:39 +01:00
355d65aa8d
Fix a font oversampling warning being printed when it shouldn't
2019-01-31 19:49:10 +01:00
abfeba8d12
Fix crashes when calling update_bitmask_area
...
Fixes #25504
2019-01-31 11:48:37 +02:00
b83c3827f3
Add check in folding to see if the nodepath exists to avoid message spam.
2019-01-30 20:19:44 -08:00
d308eb091a
Fix many asan and ubsan reported issues
...
This allows most demos to run without any ubsan or asan errors. There
are still some things in thirdpart/ and some things in AudioServer that
needs a look but this fixes a lot of issues. This should help debug less
obvious issues, hopefully.
This fixes #25217 and fixes #25218
2019-01-30 06:43:56 +01:00
308e66442e
Merge pull request #25439 from YeldhamDev/color_picker_toggle_fixup
...
Small fixup on button toggle behaviour in ColorPicker
2019-01-29 08:57:45 +01:00
a7e6a31d7f
binding for get_frustum() of camera class
2019-01-28 21:43:59 +03:00
8d3ae29e8f
Small fixup on button toggle behaviour in ColorPicker
2019-01-28 15:51:57 -02:00
402cfa983d
Fix recursive assignment of Textures and BitMapFont
...
Fixes #24213 .
2019-01-28 15:10:34 +01:00
7e99ac22ae
Merge pull request #25366 from clayjohn/visual_shader_builtins
...
Updated visual shader builtins
2019-01-27 22:23:32 +01:00
45a400d90e
Do not restrict light texture type (wont work with atlas, though)
2019-01-27 16:58:18 -03:00
70d6d0fa69
Fix problem blending from state to state in statemachine node, closes #21944
2019-01-27 15:21:54 -03:00
4cfce99955
Merge pull request #25355 from YeldhamDev/color_picker_changes
...
Make some small enhancements to the ColorPicker
2019-01-27 18:37:48 +01:00
30dd1815e4
Change the frame number before triggering the animation_finished signal
2019-01-27 17:31:55 +01:00
182f26fe5e
Make some small enhancements to the ColorPicker
2019-01-27 12:44:39 -02:00
17b2b17471
Document AnimatedTexture and bind MAX_FRAMES constant
...
Closes #24935 .
2019-01-27 13:11:57 +01:00
c4db6ce2b2
updated visual shader builtins
2019-01-27 01:27:09 -08:00
c3b0ee5941
Fix code style issues
2019-01-26 22:35:31 +01:00
433b8ee526
doc: Sync classref with current source
2019-01-26 22:21:53 +01:00
c2f59de212
Warn of invalid pointer when converting object to RID, closes #19023
2019-01-26 15:41:26 -03:00
b203f80dfc
Rewrite how font oversampling is updated more carefully, fixes #24338
2019-01-26 14:57:17 -03:00
5fcb03f6b6
Changed ImageTexture image cache type to the correct one, fixes #24971
...
The original attempt to fix the issue was accidentally using the wrong
type for the image cache. This change fixes that.
2019-01-26 09:12:38 +01:00
b3335e943b
Implement missing autorestart in oneshot node, closes #22238
2019-01-25 18:15:29 -03:00
32fa136cc7
Ability to keep images in ImageTexture cached while using editor, fixes #25243
2019-01-25 13:40:23 -03:00
c743da100d
Avoid crashing in #23302
2019-01-25 09:09:32 -03:00
01170c911c
Added copy_theme and fixed bugs in copy theme introduced by #2e0a94e
2019-01-25 13:14:06 +10:30
6ad4f16b1d
Merge pull request #25298 from groud/fix_separation_update
...
Updates containers minimum size when some constants are modified
2019-01-24 23:39:32 +01:00
a1f955a1d3
Updates containers minimum size when some constants are modified
2019-01-24 22:31:33 +01:00
a280bd0c85
Removed dangerous and useless function, closes #22884
2019-01-24 17:56:19 -03:00
d0b736f7e5
Ability to get the current canvas item being drawn from stylebox.
2019-01-24 10:22:41 -03:00
a29b10cced
ProgressBar: Set default step to 0.01
...
Fixes #22655 .
2019-01-24 12:58:58 +01:00
63b487e49c
Fix PhysicsBody ignoring set_friction/bounce with default value
...
The intent was to avoid creating a physics override to set a default value
that doesn't make a difference, but as #22406 shows it can be necessary to
set the default value *back* after an override was created to set a non-default
value.
Fixes #22406 .
2019-01-24 12:15:54 +01:00
0577f93cf6
Fixing textures not triggering _change_notify
2019-01-23 21:48:58 +01:00
bbc9e91043
Fix warning when setting out of range outline_size
...
Fixes the warning mentioned in #25046
2019-01-23 14:44:16 +01:00
51c67a386d
Merge pull request #25190 from 99alfie/master
...
Fix ButtonGroup.get_pressed_button bug
2019-01-23 12:30:23 +01:00
e081cec69f
Fix collision margin being wrongly read by default, fixes #25181
2019-01-22 10:15:18 -03:00
7c8f55f857
Merge pull request #25207 from clayjohn/cpu_particle_2d_aligny_bug
...
Fix bug with CpuParticles2D AlignY
2019-01-22 12:19:00 +01:00
34d0585618
Merge pull request #25208 from clayjohn/angular_velocity_cpu_2d
...
Properly initialize angular_velocity in cpuparticles2d
2019-01-22 07:45:00 +01:00
af92ade728
properly initialize angular_velocity in cpuparticles2d
2019-01-21 21:00:00 -08:00
fbde851641
fix bug with cpu_particle_2d_align_y
2019-01-21 20:11:48 -08:00
3eb0757552
Modified code generation to be more friendly to previews, fixes #25094
2019-01-21 16:10:23 -03:00
055456d5fc
Merge pull request #25064 from homer666/itemlist-adjust-ui_select-precedence
...
ItemList: ignore `ui_select` action if Select Mode is not "Multi"
2019-01-21 17:45:30 +01:00
ea211af412
ButtonGroup.get_pressed_button bugfix, fixes issue #25057
2019-01-21 16:46:09 +01:00
769341e180
Cleanup after @reduz :)
...
Fixes #25172 .
2019-01-21 11:12:55 +01:00
d10f8027a4
Merge pull request #25114 from Calinou/fix-colorpicker-rounding
...
Fix a rounding error in ColorPicker
2019-01-19 10:00:42 +01:00
d27ca7eb73
Fixed Bone Transform Order
...
The bone index being passed to the visual server is not using the process order and results in incorrect skin deformation if the calculated process order is different from the unordered bones Vector.
Incidentally, this never showed when I exported rigged characters from blender using the Better Collada exporter. This bug only materialised when experimenting with the glTF pipeline from Maya.
2019-01-18 22:26:13 +00:00
4b78306459
Fix a rounding error in ColorPicker
...
This closes #25063 .
2019-01-18 22:19:19 +01:00
93d8f3cdd5
respect mouse mode when setting enter/exit notifications and signals, fixes #19785
2019-01-18 17:53:36 -03:00
0c54e6344b
Fix capture interpolation mode in Animation, closes #24015
2019-01-18 17:07:45 -03:00
d8b702b566
-Re-added margins in one way collision (made in a more user friendly way than in Godot 2.1), fixes #23860
...
-Fixed potential bug in OWC (i dont think anyone had it but..)
2019-01-18 14:15:05 -03:00
1efd37f1b7
Fix uninitialized memory error.
2019-01-17 19:12:01 -03:00
e0336996ce
Add some checks to avoid disaster when making a node the scene root. Fixes #24484
2019-01-17 15:26:38 -03:00
5e709baba1
Fix keying resource properties, closes #24690
2019-01-17 12:30:34 -03:00
56d4b9b1ae
Fix functions to get direct contacts from shapes, closes #19618
2019-01-17 12:01:09 -03:00
5f47e18b0f
ItemList: ignore `ui_select` action if Select Mode is not "Multi"
2019-01-18 01:54:24 +11:00
6d7dfa6df8
Avoid crashing GIProbe bake with broken UV data, closes #25028
2019-01-17 10:58:34 -03:00
7478f468b2
Fixes to 2D lights, closes #24750
2019-01-17 10:40:36 -03:00
Bojidar Marinov
Juan Linietsky
KaadmY
Hein-Pieter van Braam
Rémi Verschelde
Michael Alexsander Silva Dias
Kārlis Seņko
marxin
PouleyKetchoupp
Luiz
ianb96
Vixelz
clayjohn
Marcelo Fernandez
Juan Linietsky
qarmin
Unknown
Naoto Kondo
Guilherme Felipe
JFonS
azagaya
Paul Trojahn
George Marques
Tom McLean
Bastiaan Olij
Paulb23
Hugo Locurcio
K. S. Ernest (iFire) Lee
Yusuf
Gilles Roudiere
Daniel Rakos
Fabian
Marcin Zawiejski
Kraus
Grant Clarke
homer666