Commit Graph

20180 Commits

Author SHA1 Message Date
Rémi Verschelde
fc370b3feb Fix -Wimplicit-fallthrough warnings from GCC 8
Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional.
Can be replaced by `[[fallthrough]]` if/when we switch to C++17.

The warning is now enabled by default for GCC on `extra` warnings level
(part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet,
but we could enable it manually once we switch to C++11. There's no
equivalent feature in MSVC for now.

Fixes #26135.
2019-04-05 15:14:53 +02:00
toasteater
7cbfce7a8c Respect keep_3d_linear when transparent_bg is on.
When transparent_bg is on, or the render target is too small,
Godot would skip postprocessing and disregard keep_3d_linear.

This fixes #26817.
2019-04-05 20:42:59 +08:00
Rémi Verschelde
4011429e57
Merge pull request #27683 from Xrayez/fix-bitmap-true-bit-count
Fix BitMap calculating incorrect true bit count
2019-04-05 14:40:49 +02:00
Mariano Javier Suligoy
bfc3ba5af0
Merge pull request #27365 from Byteron/tile_map_negative_offset
TileMap, negative Y and X Offset
2019-04-05 09:24:32 -03:00
Chaosus
8d12dfa24d Fix File opened with READ_WRITE on Windows
To allows use read and write anytime and in any order
2019-04-05 15:15:40 +03:00
Rémi Verschelde
e4a96164b6 SCons: add methods.using_clang to check used compiler
Also rename `use_gcc` to `using_gcc` to make it clear that it returns
a config but does not alter it.
2019-04-05 12:51:15 +02:00
Bastiaan Olij
b2c0a687f1 Restructuring glue code to make it easier to extend 2019-04-05 21:44:06 +11:00
Rémi Verschelde
6a33727cb1
Merge pull request #27687 from Zylann/fix_heightmap_shape_min_max
Fix wrong heights data used to compute min and max heights
2019-04-05 11:52:22 +02:00
Aaron Winter
63e0fd7675 added negative X and negative Y offset to TileMap
clang-format

added negative X and negative Y offset to TileMap
2019-04-05 10:37:35 +02:00
Andrii Doroshenko (Xrayez)
34e6737413 Reorder reverse caps characters table for string lower case conversion
The binary search algorithm used to lookup character codes in the table
relies that the data must be ordered. This fixes `to_lower()` string
method to convert upper case to lower case properly, so that the
algorithm doesn't terminate prematurely.

Co-authored-by: AndreevAndrei (avandrei) <avandrei@MacBookAAV.local>
2019-04-05 11:10:15 +03:00
Mariano Javier Suligoy
1ab9b86a21
Merge pull request #27500 from samdze/master
Allow TileMap to override set_cell behaviour while using TileMap editor
2019-04-04 23:17:29 -03:00
Mariano Javier Suligoy
60fbbba398
Merge pull request #27201 from siddharth952/issue1
Fixed Tileset Editor bug related to polygon size
2019-04-04 23:09:50 -03:00
Mariano Javier Suligoy
a6e9af7222
Merge pull request #27122 from LATRio/fix_texture_region_zoom
Fix zooming in TextureRegion
2019-04-04 23:09:25 -03:00
Ignacio Roldán Etcheverry
9cf81271f6
Merge pull request #27688 from ForLoveOfCats/master
Mono: Make missing default constructor error more foolproof
2019-04-04 23:22:30 +02:00
ForLoveOfCats
444242a080 Mono: Make missing default constructor error more foolproof 2019-04-04 16:56:02 -04:00
Marc Gilleron
cdcdba704b Fix wrong heights data used to compute min and max heights 2019-04-04 21:22:18 +01:00
Ignacio Roldán Etcheverry
21da74b514
Merge pull request #27686 from ForLoveOfCats/master
Mono: Make GD.Convert take Variant.Type instead of int
2019-04-04 22:17:25 +02:00
ForLoveOfCats
46e79e6fad Mono: Makes GD.Convert take Variant.Type instead of int 2019-04-04 16:07:48 -04:00
Michael Alexsander Silva Dias
e63e3875d7 Fix 'UndoRedo' increasing its version on actions that should be merged 2019-04-04 14:37:45 -03:00
Rémi Verschelde
6d27226134
Merge pull request #27469 from Calinou/text-selection-use-accent-color
Use the accent color to highlight selected text
2019-04-04 18:27:54 +02:00
Andrii Doroshenko (Xrayez)
b16946dea6 Fix BitMap calculating incorrect true bit count 2019-04-04 19:11:39 +03:00
Rémi Verschelde
d9b9c9f98a
Merge pull request #27567 from Calinou/selection-boxes-use-accent-color
Use the editor theme's accent color for 2D/3D selections and rotations
2019-04-04 17:45:01 +02:00
Rémi Verschelde
3a7a1cd4c9
Merge pull request #27596 from mo7sener/master
Fix: RichTextLabel Crash - meta_hover_ended
2019-04-04 17:27:34 +02:00
Theis Egeberg
26cc521d55 -Added trim limit constant at top of file, defining at which db trimming should occur (moved from being in the code itself)
-Added fade out frames constant at top of file, defining how many frames should have fade out applied (to avoid pops at the end of trim)
-Rewrote parts of the trimming logic to use an average of volume across all channels instead of any particular channel
-Added fade-out to trimming
2019-04-04 16:37:58 +02:00
Juan Linietsky
a18989602b Clean up notifications and merge Node and MainLoop ones for clarity, closes #27614 2019-04-04 10:34:41 -03:00
Rémi Verschelde
2ce022af7e
Merge pull request #27671 from akien-mga/scons-opus-arm
SCons: Fix OPUS_ARM_OPT flag applied for all android/iphone arches
2019-04-04 12:36:52 +02:00
Rémi Verschelde
c2fb1c9f01 SCons: Fix OPUS_ARM_OPT flag applied for all android/iphone arches
The first 'if' always evaluated to true, as it evaluated values which are the default
ones for Android and iOS respectively, so even if one of them was overridden, the other
one would be true.

Fixes #27658.
2019-04-04 12:01:52 +02:00
Rémi Verschelde
c2c11fc063
Merge pull request #27655 from Faless/mp/err_explain_fix
Properly explain RPC/RSET mode failure.
2019-04-03 23:36:33 +02:00
Fabio Alessandrelli
95ad747dea Properly explain RPC/RSET mode failure.
_can_call_mode used to call is_network_master/get_network_master
internally.
This would reset any potential last error set via ERR_EXPLAIN,
preventing it from being displayed correctly.
_can_call_mode now expects the node master ID to be passed instead.
2019-04-03 21:55:42 +02:00
Angeloss
40acc3ecdc Fix: Keep custom tracks option now keeps animation loop property and value track update mode.
(cherry picked from commit 589c5698a0)
2019-04-03 16:59:34 +02:00
Juan Linietsky
ed3586afa1 Add documentation about nested YSort nodes. 2019-04-03 11:42:42 -03:00
PouleyKetchoupp
66d3a8a11e Updated StyleBoxFlat documentation 2019-04-03 15:27:48 +02:00
Rémi Verschelde
620dd79e71
Merge pull request #27636 from Jayman2000/contributing-these
Minor English fix
2019-04-03 15:13:34 +02:00
Rémi Verschelde
f9b145d27f
Merge pull request #27634 from akien-mga/dist-linux-mime
dist: Rename Linux mime type to follow system convention
2019-04-03 15:13:19 +02:00
Rémi Verschelde
ae184a117e
Merge pull request #27633 from akien-mga/scons-py3-fixup
SCons: Fix python3 compat for builtin_bullet=no
2019-04-03 15:12:59 +02:00
Jason Yundt
f8a22f0a90 Minor English fix
CONTRIBUTING.md would use the phrase "those guidelines" to introduce a
list. In general, the word "these" is used to refer to something that is
being introduced or has recently been introduced, and "those" is used to
refer to something that had been previously introduced.

This change also makes CONTRIBUTING.md consistent with the
documentation. The documentation guidelines at
https://docs.godotengine.org/en/latest/community/contributing/documentation_guidelines.html
use "these" to introduce a list and its singular form, "this", to
introduce items.
2019-04-03 08:49:08 -04:00
Rémi Verschelde
7eabf4c8a3 dist: Rename Linux mime type to follow system convention
Mime type definitions are usually named like the mime type they define,
i.e. x-godot-project in our case.
It was introduced with reverse DNS naming as that's what FlatHub favors,
so it will need to be renamed there.
2019-04-03 13:24:28 +02:00
PouleyKetchoupp
8b84638322 Add ability to flip TextureRect horizontally or vertically 2019-04-03 13:05:29 +02:00
Rémi Verschelde
44f1b390a3 SCons: Fix python3 compat for builtin_bullet=no 2019-04-03 11:25:01 +02:00
Rémi Verschelde
f64336f1a7
Merge pull request #27264 from ViktorEvil/master
Enable macOS Mojave "Dark Mode" on the editor title bar
2019-04-03 10:09:20 +02:00
Chaosus
a19e99aacb Added signal for Tween emitted at completion 2019-04-03 10:35:26 +03:00
Rémi Verschelde
76cbe7a9ae
Merge pull request #27214 from marcelofg55/midi_note_off
Fix MIDI Note Off missing on some devices
2019-04-03 09:17:07 +02:00
Rémi Verschelde
de54ee975d
Merge pull request #27238 from ShyRed/cpu2dmask
Add Emission Mask to CPUParticle2D
2019-04-03 09:13:14 +02:00
Ignacio Roldán Etcheverry
f285d554e5
Merge pull request #27618 from neikeq/fix-leak
Fix memory leak introduced in bb6814a
2019-04-03 00:25:07 +02:00
Ignacio Etcheverry
0338e55a6e Fix memory leak introduced in bb6814a 2019-04-02 22:56:17 +02:00
Rémi Verschelde
25c1363a11
Merge pull request #27597 from marxin/fix-Wnon-virtual-dtor-warnings
Fix -Wnon-virtual-dtor warnings.
2019-04-02 18:25:02 +02:00
Rémi Verschelde
f5013e3277
Merge pull request #26343 from marxin/warnings-all-add-most-of-Wextra
Enable most of -Wextra warnings for warnings=all.
2019-04-02 18:24:06 +02:00
marxin
e7f22ebdcd Enable warnings=extra on clang and GCC testers.
And remove 2 warnings from warnings=extra.
2019-04-02 17:14:47 +02:00
toasteater
ae1393acae Improve RandomNumberGenerator docs.
Clarified behavior of a few methods. Added implementation notes so
that developers not familiar with RNGs are alerted to common pitfalls.
2019-04-02 22:42:49 +08:00
marxin
f9f2413e69 Fix -Wnon-virtual-dtor warnings.
Example of the warning:
./core/script_language.h:198:7: warning: 'class ScriptCodeCompletionCache' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
2019-04-02 14:07:29 +02:00