godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/modules/openxr
History
Rémi Verschelde fd6453c45e Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 
This reverts commit 4b817a565c.

Fixes #64988.
Fixes #64997.

This caused several regressions (#64988, #64997,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605)
which point at a flaw in the current logic:

- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
  `NOTIFCATION_THEME_CHANGED` as introduced in #62845.
- Some classes use their `THEME_CHANGED` to cache theme items in
  member variables (e.g. `style_normal`, etc.), and use those member
  variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
  notification is now deferred, they end up accessing invalid state and this
  can lead to not applying theme properly (e.g. for EditorHelp) or crashing
  (e.g. for EditorLog or CodeEdit).

So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?

Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
  variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
  bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
  does arrive for the first time. But that means having a temporary invalid
  (and possibly still crashing) state, and doing some computations twice
  which might be heavy (e.g. `EditorHelp::_update_doc()`).
 		2022-08-29 11:11:29 +02:00
..
action_map Fix unnamed arguments in XML docs 2022-07-26 20:42:38 +02:00
doc_classes Improve the `make_rst.py` parser for BBCode tags 2022-08-15 17:45:10 +03:00
editor Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
extensions Code quality: Fix header guards consistency 2022-07-25 11:17:40 +02:00
SCsub Improve `linuxbsd` headless building, cleanup build scripts 2022-07-20 19:48:35 +02:00
config.py Implementing OpenXR driver 2022-02-23 12:02:24 +01:00
openxr_api.cpp Add startup flag to override XR mode settings 2022-07-28 11:50:34 +10:00
openxr_api.h Code quality: Fix header guards consistency 2022-07-25 11:17:40 +02:00
openxr_interface.cpp Swap arguments of ResourceSaver.save() 2022-07-29 19:53:09 +02:00
openxr_interface.h Code quality: Fix header guards consistency 2022-07-25 11:17:40 +02:00
openxr_util.cpp Adding signals and events to OpenXR interface 2022-03-10 17:14:56 +11:00
openxr_util.h Code quality: Fix header guards consistency 2022-07-25 11:17:40 +02:00
register_types.cpp Refactor module initialization 2022-05-04 17:34:51 +02:00
register_types.h Refactor module initialization 2022-05-04 17:34:51 +02:00