godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7da392bcc5
godot/core
History
Rémi Verschelde 7da392bcc5
Don't return reference on copy assignment operators 
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this
can lead to confusing code and subtle bugs.

According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B), C++
allows any arbitrary return type, so this is standard compliant.

This could be re-assessed if/when we have an actual need for a behavior more
akin to that of the C++ STL, for now this PR simply changes a handful of
cases which were inconsistent with the rest of the codebase (`void` return
type was already the most common case prior to this commit).
2021-11-30 16:26:29 +01:00
..
config Don't show errors when getting nonexistent settings 2021-11-25 08:23:42 -06:00
crypto [Crypto] Delete mbedtls ctx in deconstructor. 2021-07-03 16:12:55 +02:00
debugger Fix incorrect encoding (Latin-1 instead of UTF-8) used in _error_handler functions. 2021-11-08 23:45:08 +02:00
error Fix console colors on Windows 2021-11-26 13:10:55 +03:00
extension [GDExtension] Implement missing Dictionary index operators. 2021-11-22 12:43:00 +02:00
input Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
io Fix console colors on Windows 2021-11-26 13:10:55 +03:00
math Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
multiplayer [Net] Fix spawn/despawn custom callable argument. 2021-10-12 14:18:16 +02:00
object Fix wrong comparison with default values 2021-11-26 14:04:13 +00:00
os [HTML5] Add WebGL2 (GLES3) support using the OpenGL renderer. 2021-11-19 16:59:27 +01:00
string Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
templates Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
variant Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
core_bind.cpp Expose Thread::get_main_id in core bindings 2021-11-12 19:28:49 -05:00
core_bind.h Expose Thread::get_main_id in core bindings 2021-11-12 19:28:49 -05:00
core_builders.py Use maximum zlib compression when generating editor translation headers 2021-10-29 19:07:48 +02:00
core_constants.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
core_constants.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
core_string_names.cpp Removed _change_notify 2021-02-10 19:31:24 -03:00
core_string_names.h Removed _change_notify 2021-02-10 19:31:24 -03:00
doc_data.cpp Implement NativeExtension pointer arguments 2021-08-23 19:58:40 -03:00
doc_data.h Enable sorting of operator methods in class documentation. 2021-11-29 14:51:44 +00:00
register_core_types.cpp [Net] Bind Multiplayer to GDExtension. 2021-09-24 18:40:39 +02:00
register_core_types.h Implement native extension system 2021-06-25 17:32:45 -03:00
SCsub SCons: List .gen.cpp sources explicitly to avoid globbing errors 2021-10-15 22:14:11 +02:00
typedefs.h Rename built-in SGN() macro to SIGN() 2021-11-16 20:40:49 +01:00
version.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00