4ed1d977fc
Some platforms (*cough* web *cough*) have hard limits on the number of threads that can be spawned. Currently, ThreadPoolWork (mostly used in rendering/physics servers) will spawn as many threads as CPUs available causing exception on machines with high CPU count. This commit adds a new overridable method to OS that returns the default thread pool size (still the CPU count by default), and overrides it for the JavaScript platform so it always allocate only one thread. We can likely improve the whole ThreadPoolWork in the future to always allocate X amount of threads, and assign jobs to them on the fly, but that will require some more architectural changes.
82 lines
3.2 KiB
C++
82 lines
3.2 KiB
C++
/*************************************************************************/
|
|
/* thread_work_pool.cpp */
|
|
/*************************************************************************/
|
|
/* This file is part of: */
|
|
/* GODOT ENGINE */
|
|
/* https://godotengine.org */
|
|
/*************************************************************************/
|
|
/* Copyright (c) 2007-2021 Juan Linietsky, Ariel Manzur. */
|
|
/* Copyright (c) 2014-2021 Godot Engine contributors (cf. AUTHORS.md). */
|
|
/* */
|
|
/* Permission is hereby granted, free of charge, to any person obtaining */
|
|
/* a copy of this software and associated documentation files (the */
|
|
/* "Software"), to deal in the Software without restriction, including */
|
|
/* without limitation the rights to use, copy, modify, merge, publish, */
|
|
/* distribute, sublicense, and/or sell copies of the Software, and to */
|
|
/* permit persons to whom the Software is furnished to do so, subject to */
|
|
/* the following conditions: */
|
|
/* */
|
|
/* The above copyright notice and this permission notice shall be */
|
|
/* included in all copies or substantial portions of the Software. */
|
|
/* */
|
|
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
|
|
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
|
|
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
|
|
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
|
|
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
|
|
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
|
|
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
|
|
/*************************************************************************/
|
|
|
|
#include "thread_work_pool.h"
|
|
|
|
#include "core/os/os.h"
|
|
|
|
void ThreadWorkPool::_thread_function(void *p_user) {
|
|
ThreadData *thread = static_cast<ThreadData *>(p_user);
|
|
while (true) {
|
|
thread->start.wait();
|
|
if (thread->exit.load()) {
|
|
break;
|
|
}
|
|
thread->work->work();
|
|
thread->completed.post();
|
|
}
|
|
}
|
|
|
|
void ThreadWorkPool::init(int p_thread_count) {
|
|
ERR_FAIL_COND(threads != nullptr);
|
|
if (p_thread_count < 0) {
|
|
p_thread_count = OS::get_singleton()->get_default_thread_pool_size();
|
|
}
|
|
|
|
thread_count = p_thread_count;
|
|
threads = memnew_arr(ThreadData, thread_count);
|
|
|
|
for (uint32_t i = 0; i < thread_count; i++) {
|
|
threads[i].exit.store(false);
|
|
threads[i].thread.start(&ThreadWorkPool::_thread_function, &threads[i]);
|
|
}
|
|
}
|
|
|
|
void ThreadWorkPool::finish() {
|
|
if (threads == nullptr) {
|
|
return;
|
|
}
|
|
|
|
for (uint32_t i = 0; i < thread_count; i++) {
|
|
threads[i].exit.store(true);
|
|
threads[i].start.post();
|
|
}
|
|
for (uint32_t i = 0; i < thread_count; i++) {
|
|
threads[i].thread.wait_to_finish();
|
|
}
|
|
|
|
memdelete_arr(threads);
|
|
threads = nullptr;
|
|
}
|
|
|
|
ThreadWorkPool::~ThreadWorkPool() {
|
|
finish();
|
|
}
|