godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9327052bed
godot/servers/physics
History
Josh Jones 9327052bed [Godot Physics]: Correct typo in moment of inertia calculations. 
The moment of inertia calculation for BoxShape is:

```
Vector3(
    (p_mass / 3.0) * (ly * ly + lz * lz), 
    (p_mass / 3.0) * (lx * lx + lz * lz), 
    (p_mass / 3.0) * (lx * lx + ly * ly));
```

where the final line includes both the x and y extents.

However, for CapsuleShape3D, CylinderShape3D, ConvexPolygonShape3D, ConcavePolygonShape3D, and HeightMapShape3D, the final line read `(p_mass / 3.0) * (extents.y * extents.y + extents.y * extents.y)`.  I believe this is a mistake, considering the comment in each case mentions using an AABB approximation, which should follow the same approach as BoxShape.

This change corrects the final line to include both the x and y components of the shape's extent.
2021-03-22 20:23:39 -07:00
..
joints Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
area_pair_sw.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
area_pair_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
area_sw.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
area_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
body_pair_sw.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
body_pair_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
body_sw.cpp [3.3] Fix some angular velocity calculations 2021-03-20 16:58:04 +10:00
body_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
broad_phase_basic.cpp BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
broad_phase_basic.h BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
broad_phase_bvh.cpp BVH add support for visibility (activation) 2021-01-30 13:21:40 +00:00
broad_phase_bvh.h BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
broad_phase_octree.cpp BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
broad_phase_octree.h BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
broad_phase_sw.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
broad_phase_sw.h BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
collision_object_sw.cpp BVH broadphase creates objects with updated AABB to avoid extra checks 2021-01-19 12:22:33 -07:00
collision_object_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
collision_solver_sat.cpp Merge pull request #47068 from nekomatata/cylinder-fix-margins-3.2 2021-03-17 11:05:46 +01:00
collision_solver_sat.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
collision_solver_sw.cpp Cylinder support in Godot Physics 3D 2021-02-18 08:44:23 -07:00
collision_solver_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
constraint_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
gjk_epa.cpp Fix Cylinder shape collision with margins when using GJK-EPA 2021-03-16 10:20:19 -07:00
gjk_epa.h Fix Cylinder shape collision with margins when using GJK-EPA 2021-03-16 10:20:19 -07:00
joints_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
physics_server_sw.cpp Cylinder support in Godot Physics 3D 2021-02-18 08:44:23 -07:00
physics_server_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
SCsub SCons: Format buildsystem files with psf/black 2020-06-10 15:30:52 +02:00
shape_sw.cpp [Godot Physics]: Correct typo in moment of inertia calculations. 2021-03-22 20:23:39 -07:00
shape_sw.h Cylinder support in Godot Physics 3D 2021-02-18 08:44:23 -07:00
space_sw.cpp [3.3] Fix some angular velocity calculations 2021-03-20 16:58:04 +10:00
space_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
step_sw.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
step_sw.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00