godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
bca2d3ad40
godot/platform/iphone
History
Rémi Verschelde e5bbcb8bcf Fix warnings for comparison between signed and unsigned integers [-Wsign-compare] 
Also turn off -Wsign-compare warnings in the future, we do not consider them important.

Fixes the following GCC 5 warnings:
```
core/node_path.cpp:279:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/oa_hash_map.h:169:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/oa_hash_map.h:314:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles2/shader_gles2.cpp:985:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles3/rasterizer_storage_gles3.cpp:1075:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/pulseaudio/audio_driver_pulseaudio.cpp:343:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/editor_plugin.cpp:525:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/editor_properties_array_dict.cpp:747:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/spatial_editor_plugin.cpp:2078:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/spatial_editor_plugin.cpp:4096:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/sprite_editor_plugin.cpp💯20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:122:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:134:77: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:339:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/etc/image_etc.cpp:222:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/gdnative/register_types.cpp:242:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/gdnative/register_types.cpp:258:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:200:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:222:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:246:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1085:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1489:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1623:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:206:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:356:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:406:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:493:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/audio_stream_player_3d.cpp:420:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/audio_stream_sample.cpp:565:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/audio_stream_sample.cpp:571:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_rb_resampler.cpp:156:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
```

The following warnings were not fixed, as they implied casting for no gain:
```
core/io/packet_peer.cpp:228:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/io/resource_format_binary.cpp:109:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles2/rasterizer_scene_gles2.cpp:144:57: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/unix/file_access_unix.cpp:249:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:889:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:1020:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:1154:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:2255:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/bit_mask.cpp:336:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:141:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:150:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:154:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio_server.cpp:86:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio_server.cpp:89:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
```
2018-09-27 16:25:23 +02:00
..
export Fix warnings for comparison between signed and unsigned integers [-Wsign-compare] 2018-09-27 16:25:23 +02:00
globals Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
app_delegate.h Resume audio on iOS after phone call or alarm 2018-05-07 15:48:46 +07:00
app_delegate.mm Fix keep screen on property path for Android/iOS/UWP 2018-07-17 18:45:57 +09:00
detect.py -Fix disable_3d flag 2018-07-21 17:26:49 -03:00
game_center.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
game_center.mm Style: Format code with clang-format 6.0.1 2018-07-18 16:27:03 +02:00
gl_view.h iPhone X support and iOS-related fixes 2018-04-11 14:53:24 +07:00
gl_view.mm Implement universal translation of touch to mouse 2018-04-30 19:03:38 +02:00
godot_iphone.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
icloud.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
icloud.mm Add missing return statements (iOS and server). 2018-02-25 01:11:03 +02:00
in_app_store.h add restore purchases for iOS 2018-02-22 14:28:37 -05:00
in_app_store.mm Provide error details when in-app purchase fails 2018-04-19 21:04:20 +07:00
ios.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ios.mm Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
logo.png Optimize images losslessly using oxipng -o6 --strip all --zopfli 2018-06-28 19:17:41 +02:00
main.m Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
os_iphone.cpp Fall back to GLES2 if GLES3 is not working 2018-08-26 16:40:46 +02:00
os_iphone.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
platform_config.h fix iOS build - error due to GLES2 missing include (with the advice from bruvzg[m] on irc) 2018-03-13 10:42:23 +01:00
platform_refcount.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
power_iphone.cpp Fix UpdatePowerInfo method implementation in PowerIphone class 2018-03-31 02:52:37 +03:00
power_iphone.h Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
SCsub Fix IPhone and OSX cross compilation 2018-03-28 19:08:20 +02:00
sem_iphone.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
sem_iphone.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
view_controller.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
view_controller.mm Respect window/handheld/orientation setting in iOS 2018-07-01 22:08:37 +03:00