godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/editor
History
Crazy-P e6deba8d19 Fixes logically dead code (Coverity) 
Fixes reported logically dead codes by Coverity

* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.

* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function

* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.

* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)

* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle

* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'

* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp

* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.

* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.

* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
 		2018-04-21 22:35:23 +08:00
..
collada Fixes logically dead code (Coverity) 2018-04-21 22:35:23 +08:00
doc Refactor version macros and fix related bugs 2018-02-23 20:15:29 +01:00
fileserver Display set_nodelay to GDScript 2018-01-30 13:22:15 -02:00
icons Displays node icon on hover 2018-04-03 23:56:37 +02:00
import Merge pull request #16297 from lpn/master 2018-04-08 18:41:46 -03:00
plugins Fixes logically dead code (Coverity) 2018-04-21 22:35:23 +08:00
translations Properly closing all files in Python code 2018-03-11 14:55:50 +01:00
SCsub Merge pull request #17440 from viktor-ferenczi/issue-5042 2018-03-13 11:49:58 +01:00
animation_editor.cpp Merge pull request #17379 from poke1024/fix-anim-popups 2018-03-13 11:55:17 +01:00
animation_editor.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
array_property_edit.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
array_property_edit.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
code_editor.cpp Fixes replace all not replacing the first word 2018-03-25 15:39:37 +08:00
code_editor.h Merge pull request #16241 from Chaosus/zoomlabel 2018-02-19 21:35:11 +01:00
connections_dialog.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
connections_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
create_dialog.cpp Merge pull request #16995 from mrcdk/custom_resources_inspector 2018-04-08 11:49:34 -03:00
create_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dependency_editor.cpp Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
dependency_editor.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dictionary_property_edit.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
dictionary_property_edit.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_about.cpp Update icons when theme changed 2018-02-25 23:04:16 +07:00
editor_about.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_asset_installer.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_asset_installer.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_audio_buses.cpp Merge pull request #17013 from Noshyaar/theme 2018-03-13 13:48:37 +01:00
editor_audio_buses.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_autoload_settings.cpp Fix column width on AutoLoad table on hidpi displays 2018-03-11 15:28:23 +01:00
editor_autoload_settings.h Merge pull request #16709 from willnationsdev/autoload-edit 2018-02-19 22:04:42 +01:00
editor_data.cpp Now the inspector will show the custom resources added via plugin 2018-02-25 01:41:26 +01:00
editor_data.h Now the inspector will show the custom resources added via plugin 2018-02-25 01:41:26 +01:00
editor_dir_dialog.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_dir_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_export.cpp Improved error checking at EditorExportPlatformPC::export_project 2018-03-06 14:23:17 -03:00
editor_export.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_file_dialog.cpp Icons update 2018-02-21 19:05:50 -06:00
editor_file_dialog.h Fixes open button not appearing with multiple selection 2018-01-31 16:25:42 -02:00
editor_file_system.cpp Merge pull request #17420 from marcelofg55/fscache_err_checks 2018-03-14 09:21:31 +01:00
editor_file_system.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_fonts.cpp Add an hinting mode setting to DynamicFonts 2018-02-28 00:12:26 +01:00
editor_fonts.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_help.cpp Ctrl+Clicking a enum now scrolls down to it in the docs. 2018-04-03 21:56:54 +02:00
editor_help.h Ctrl+Clicking a enum now scrolls down to it in the docs. 2018-04-03 21:56:54 +02:00
editor_initialize_ssl.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_initialize_ssl.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_log.cpp Show error icon at "Output" in case of errors 2018-03-11 14:20:32 +01:00
editor_log.h Show error icon at "Output" in case of errors 2018-03-11 14:20:32 +01:00
editor_name_dialog.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_name_dialog.h Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
editor_node.cpp Drag to rearrange Tabs and TabContainer 2018-04-08 20:23:37 -04:00
editor_node.h Drag to rearrange Tabs and TabContainer 2018-04-08 20:23:37 -04:00
editor_path.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_path.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_plugin.cpp Merge pull request #17576 from Mr-Slurpy/master 2018-03-23 11:08:03 +01:00
editor_plugin.h Enable EditorPlugin to add/remove autoloads 2018-02-14 20:15:57 -06:00
editor_plugin_settings.cpp Remove unused variable from plugin settings update 2018-02-13 18:33:51 -02:00
editor_plugin_settings.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_profiler.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_profiler.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_resource_preview.cpp Clean up some bad words from code comments 2018-02-17 16:00:39 +03:00
editor_resource_preview.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run_native.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run_native.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run_script.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_run_script.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_scale.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_scale.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
editor_settings.cpp Merge pull request #17706 from Calinou/overhaul-hidpi-settings 2018-03-23 14:12:20 +01:00
editor_settings.h Merge pull request #15399 from poke1024/load-one-translation 2018-02-14 17:04:44 +01:00
editor_sub_scene.cpp Fix inconsistencies and typos in argument names 2018-02-01 16:47:20 +01:00
editor_sub_scene.h Fix inconsistencies and typos in argument names 2018-02-01 16:47:20 +01:00
editor_themes.cpp Add radio-button-looking entries to PopupMenu 2018-03-27 19:19:45 +02:00
editor_themes.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
export_template_manager.cpp Fix version.txt validation logic for export templates .tpz 2018-02-25 15:24:33 +01:00
export_template_manager.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
file_type_cache.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
file_type_cache.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
filesystem_dock.cpp Merge pull request #18054 from Mintormo/bugfix-inconsistent-sort-in-file-manager 2018-04-09 17:56:43 +02:00
filesystem_dock.h update favorite_dirs list after move or rename a dir 2018-02-28 15:14:12 -08:00
find_in_files.cpp Added find & replace in files 2018-02-19 22:38:58 +01:00
find_in_files.h Added find & replace in files 2018-02-19 22:38:58 +01:00
groups_editor.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
groups_editor.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
import_dock.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
import_dock.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
multi_node_edit.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
multi_node_edit.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
node_dock.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
node_dock.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
output_strings.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
output_strings.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pane_drag.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pane_drag.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
progress_dialog.cpp -Remove color operator clamping, which is unnecesary. Fixes #15184, fixes #14686. 2018-01-12 00:08:32 -03:00
progress_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
project_export.cpp Set default file name for exported projects 2018-04-18 08:58:13 -05:00
project_export.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
project_manager.cpp Overhaul the display scaling editor settings 2018-03-23 14:04:39 +01:00
project_manager.h Add show path button to project manager 2018-02-19 21:56:28 +01:00
project_settings_editor.cpp Fixes left/up axis not mappable as actions 2018-04-18 21:38:52 +02:00
project_settings_editor.h Allow actions to provide an analog value 2018-04-16 23:20:43 +02:00
property_editor.cpp Fix #18058 regression 2018-04-08 20:01:38 +03:00
property_editor.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
property_selector.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
property_selector.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pvrtc_compress.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pvrtc_compress.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
quick_open.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
quick_open.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
register_exporters.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reparent_dialog.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reparent_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
run_settings_dialog.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
run_settings_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
scene_tree_dock.cpp Merge pull request #17717 from NikodemL/master 2018-04-07 16:46:49 -03:00
scene_tree_dock.h Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion. 2018-02-21 09:39:09 -03:00
scene_tree_editor.cpp Update icons when theme changed 2018-02-25 23:04:16 +07:00
scene_tree_editor.h Merge pull request #15235 from sersoong/master-batchtoggle 2018-02-18 17:20:15 +01:00
script_create_dialog.cpp Merge pull request #17388 from Hinsbart/mono_class_name 2018-03-15 19:47:39 +01:00
script_create_dialog.h Update icons when theme changed 2018-02-25 23:04:16 +07:00
script_editor_debugger.cpp Update icons when theme changed 2018-02-25 23:04:16 +07:00
script_editor_debugger.h Fix #16543 (add button to copy error from debugger) 2018-02-14 14:53:20 +03:00
settings_config_dialog.cpp Fix all categories unfold when one key binding is changed 2018-03-24 17:02:18 +01:00
settings_config_dialog.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
spatial_editor_gizmos.cpp Fixes logically dead code (Coverity) 2018-04-21 22:35:23 +08:00
spatial_editor_gizmos.h Fix inconsistencies and typos in argument names 2018-02-01 16:47:20 +01:00