godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/core
History
Maganty Rushyendra 4ef246f804 Fix unsigned integer bug in LocalVector::erase 
`erase()` calls `find()` to get the index of the element to remove, if
any.

c2151e1813/core/local_vector.h (L77-L81)

`find()` returns a signed integer. In particular, it returns -1 if
no element is found. Since `erase()` converts this to an unsigned type, the
wrong element may be erroneously removed from the vector.

Other ways to fix this would involve changing function signatures, so
this seemed to be the least disruptive change.

Fixes #38884
 		2020-05-27 21:53:34 +08:00
..
bind [Windows] Add tablet driver selection. 2020-05-20 09:37:32 +03:00
crypto Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
debugger Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
input Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
io Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
math Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
os [Windows] Add tablet driver selection. 2020-05-20 09:37:32 +03:00
SCsub Remove HQ2X and the `Image.expand_2x_hq2x()` method 2020-05-16 16:10:50 +02:00
array.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
array.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
callable.cpp Style: Enforce separation line between function definitions 2020-05-14 16:54:55 +02:00
callable.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
callable_method_pointer.cpp Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
callable_method_pointer.h Fix Container sorting not working when overriding _sort_children in gdscript 2020-05-16 18:13:25 +02:00
class_db.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
class_db.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
color.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
color.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
color_names.inc Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
command_queue_mt.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
command_queue_mt.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
compressed_translation.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
compressed_translation.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
container_type_validate.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
core_builders.py SCons: Format buildsystem files with psf/black 2020-03-30 09:05:53 +02:00
core_string_names.cpp Replace NULL with nullptr 2020-04-02 13:38:00 +02:00
core_string_names.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
cowdata.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
dictionary.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
dictionary.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
engine.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
engine.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
error_list.h Style: Harmonize header guards to style guide [Core] 2020-03-25 11:22:19 +01:00
error_macros.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
error_macros.h Error macros: Improve style of error messages 2020-05-15 18:21:14 +02:00
func_ref.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
func_ref.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
global_constants.cpp Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
global_constants.h Update copyright statements to 2020 2020-01-01 11:16:22 +01:00
hash_map.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
hashfuncs.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
image.cpp Expose `Image.save_png_to_buffer` method 2020-05-20 14:43:24 +03:00
image.h Remove HQ2X and the `Image.expand_2x_hq2x()` method 2020-05-16 16:10:50 +02:00
int_types.h Style: Harmonize header guards to style guide [Core] 2020-03-25 11:22:19 +01:00
list.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
local_vector.h Fix unsigned integer bug in LocalVector::erase 2020-05-27 21:53:34 +08:00
make_binders.py Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
map.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
message_queue.cpp Fix Container sorting not working when overriding _sort_children in gdscript 2020-05-16 18:13:25 +02:00
message_queue.h Fix Container sorting not working when overriding _sort_children in gdscript 2020-05-16 18:13:25 +02:00
method_bind.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
method_bind.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
method_ptrcall.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
node_path.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
node_path.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
oa_hash_map.h - Make sure it's impossible to initialize an OAHashMap with 0 capacity (would cause division by 0) 2020-05-25 11:18:02 +02:00
object.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
object.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
object_id.h Reworked signal connection system, added support for Callable and Signal objects and made them default. 2020-02-20 08:24:50 +01:00
ordered_hash_map.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
packed_data_container.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
packed_data_container.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
pair.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
pool_allocator.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
pool_allocator.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
print_string.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
print_string.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
project_settings.cpp Improve documentation of ProjectSettings::setup 2020-05-25 17:50:36 +02:00
project_settings.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
reference.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
reference.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
register_core_types.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
register_core_types.h Style: Harmonize header guards to style guide [Core] 2020-03-25 11:22:19 +01:00
resource.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
resource.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
rid.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
rid_owner.cpp Vulkan: Move thirdparty code out of drivers, style fixes 2020-02-11 14:08:44 +01:00
rid_owner.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
ring_buffer.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
safe_refcount.cpp Style: Fix unnecessary semicolons that confused clang-format 2020-05-19 11:24:58 +02:00
safe_refcount.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
script_language.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
script_language.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
self_list.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
set.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
simple_type.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
sort_array.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
spin_lock.h Port member initialization from constructor to declaration (C++11) 2020-05-14 10:01:56 +02:00
string_buffer.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
string_builder.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
string_builder.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
string_name.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
string_name.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
thread_work_pool.cpp Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
thread_work_pool.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
translation.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
translation.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
type_info.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
typed_array.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
typedefs.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
ucaps.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
undo_redo.cpp Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
undo_redo.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
ustring.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
ustring.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
variant.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
variant.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
variant_call.cpp Docs: Fix order of variant constants. 2020-05-20 16:45:42 +03:00
variant_op.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
variant_parser.cpp Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
variant_parser.h Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 2020-05-14 16:54:55 +02:00
vector.h Style: Remove unnecessary semicolons from `core` 2020-05-19 15:57:56 +02:00
version.h Style: Harmonize header guards to style guide [Core] 2020-03-25 11:22:19 +01:00
vmap.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00
vset.h Style: Enforce braces around if blocks and loops 2020-05-14 21:57:34 +02:00