From 0b09e8e43123ef6f4265b79be37c9db0d59dd00e Mon Sep 17 00:00:00 2001
From: Dirkjan Ochtman <dirkjan@ochtman.nl>
Date: Wed, 10 Feb 2021 16:31:13 +0100
Subject: [PATCH] Fix bug in definition of ml default value

---
 src/lib.rs   | 4 ++--
 src/types.rs | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index e2812db..1638712 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -52,7 +52,7 @@ impl Builder {
 
     /// Set the `mL` parameter from the paper
     ///
-    /// If the `mL` parameter is not already set, it defaults to `ln(M)`.
+    /// If the `mL` parameter is not already set, it defaults to `1.0 / ln(M)`.
     pub fn ml(mut self, ml: f32) -> Self {
         self.ml = Some(ml);
         self
@@ -127,7 +127,7 @@ where
     fn new(points: &[P], builder: Builder) -> (Self, Vec<PointId>) {
         let ef_search = builder.ef_search.unwrap_or(100);
         let ef_construction = builder.ef_construction.unwrap_or(100);
-        let ml = builder.ml.unwrap_or_else(|| (M as f32).ln());
+        let ml = builder.ml.unwrap_or_else(|| 1.0 / (M as f32).ln());
         let heuristic = builder.heuristic;
         let mut rng = match builder.seed {
             Some(seed) => SmallRng::seed_from_u64(seed),
diff --git a/src/types.rs b/src/types.rs
index fa94948..84c734d 100644
--- a/src/types.rs
+++ b/src/types.rs
@@ -202,7 +202,7 @@ pub(crate) struct LayerId(pub usize);
 impl LayerId {
     pub(crate) fn random(ml: f32, rng: &mut SmallRng) -> Self {
         let layer = rng.gen::<f32>();
-        LayerId((-(layer.ln() * ml)).floor() as usize)
+        LayerId((-layer.ln() * ml).floor() as usize)
     }
 
     pub(crate) fn descend(&self) -> impl Iterator<Item = LayerId> {