From 95b32d9c2935472099ff7ab8483ba86e70019e2a Mon Sep 17 00:00:00 2001
From: Dirkjan Ochtman <dirkjan@ochtman.nl>
Date: Sun, 4 Aug 2024 22:56:07 +0200
Subject: [PATCH] Apply suggestions from clippy/rustc

---
 src/connection.rs           | 2 +-
 src/contact/info.rs         | 2 +-
 src/contact/update.rs       | 8 +-------
 src/extensions/namestore.rs | 2 +-
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/connection.rs b/src/connection.rs
index 418e796..e49a13e 100644
--- a/src/connection.rs
+++ b/src/connection.rs
@@ -6,7 +6,7 @@ use std::future::Future;
 use std::pin::Pin;
 use std::task::{Context, Poll};
 use std::time::Duration;
-use std::{io, mem, str, u32};
+use std::{io, mem, str};
 
 use async_trait::async_trait;
 use tokio::io::{AsyncRead, AsyncWrite, AsyncWriteExt, ReadBuf};
diff --git a/src/contact/info.rs b/src/contact/info.rs
index 609428c..9d65226 100644
--- a/src/contact/info.rs
+++ b/src/contact/info.rs
@@ -35,7 +35,7 @@ pub struct ContactInfo<'a> {
 }
 
 impl<'a> ContactInfo<'a> {
-    pub fn new(id: &'a str, auth_password: &'a str) -> ContactInfo<'a> {
+    pub fn new(id: &'a str, auth_password: &'a str) -> Self {
         Self {
             info: ContactInfoRequest {
                 id,
diff --git a/src/contact/update.rs b/src/contact/update.rs
index 0a978a4..a189bd9 100644
--- a/src/contact/update.rs
+++ b/src/contact/update.rs
@@ -14,7 +14,7 @@ impl<'a> Command for ContactUpdate<'a> {
 }
 
 impl<'a> ContactUpdate<'a> {
-    pub fn new(id: &'a str) -> ContactUpdate {
+    pub fn new(id: &'a str) -> Self {
         Self {
             contact: ContactUpdateRequest {
                 id,
@@ -71,12 +71,6 @@ pub struct ContactChangeInfo<'a> {
     auth_info: Option<ContactAuthInfo<'a>>,
 }
 
-/// Type for list of elements of the `<status>` tag for contact update request
-#[derive(Debug, ToXml)]
-pub struct StatusList<'a> {
-    status: &'a [Status],
-}
-
 #[derive(Debug, ToXml)]
 #[xml(rename = "add", ns(XMLNS))]
 struct AddStatuses<'a> {
diff --git a/src/extensions/namestore.rs b/src/extensions/namestore.rs
index d9002bd..54fe68c 100644
--- a/src/extensions/namestore.rs
+++ b/src/extensions/namestore.rs
@@ -52,7 +52,7 @@ impl Transaction<NameStore<'_>> for HostUpdate<'_> {}
 
 impl<'a> NameStore<'a> {
     /// Create a new RGP restore report request
-    pub fn new(subproduct: &'a str) -> NameStore {
+    pub fn new(subproduct: &'a str) -> Self {
         NameStore {
             subproduct: subproduct.into(),
         }