Update Login::new to take ownership of Option ext_uris

README.md

@@ -80,7 +80,7 @@ async fn main() {
         Err(e) => panic!("Failed to create EppClient: {}",  e)
     };
 
-    let login = Login::<NoExtension>::new("username", "password", &None);
+    let login = Login::<NoExtension>::new("username", "password", None);
     client.transact(login, "transaction-id").await.unwrap();
 
     // Create an DomainCheck instance

epp-client/README.md

@@ -80,7 +80,7 @@ async fn main() {
         Err(e) => panic!("Failed to create EppClient: {}",  e)
     };
 
-    let login = Login::<NoExtension>::new("username", "password", &None);
+    let login = Login::<NoExtension>::new("username", "password", None);
     client.transact(login, "transaction-id").await.unwrap();
 
     // Create an DomainCheck instance

epp-client/src/contact/check.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for ContactCheck<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an ContactCheck instance

epp-client/src/contact/create.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for ContactCreate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create the address, postal_info, voice instances

epp-client/src/contact/delete.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for ContactDelete<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an ContactDelete instance

epp-client/src/contact/info.rs

@@ -58,7 +58,7 @@ impl<E: EppExtension> EppRequest<E> for ContactInfo<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an ContactInfo instance

epp-client/src/contact/update.rs

@@ -60,7 +60,7 @@ impl<E: EppExtension> EppRequest<E> for ContactUpdate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an ContactUpdate instance

epp-client/src/domain/check.rs

@@ -56,7 +56,7 @@ impl<E: EppExtension> EppRequest<E> for DomainCheck<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainCheck instance

epp-client/src/domain/create.rs

@@ -63,7 +63,7 @@ impl<E: EppExtension> EppRequest<E> for DomainCreate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     let contacts = vec![

epp-client/src/domain/delete.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for DomainDelete<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainDelete instance

epp-client/src/domain/info.rs

@@ -58,7 +58,7 @@ impl<E: EppExtension> EppRequest<E> for DomainInfo<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainInfo instance

epp-client/src/domain/renew.rs

@@ -59,7 +59,7 @@ impl<E: EppExtension> EppRequest<E> for DomainRenew<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create a date object to set the current expiry date

epp-client/src/domain/transfer.rs

@@ -117,7 +117,7 @@ impl<E: EppExtension> EppRequest<E> for DomainTransferQuery<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainTransferRequest instance
@@ -192,7 +192,7 @@ impl<E: EppExtension> DomainTransferRequest<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an instance of EppClient, passing the config and the registry you want to connect to
@@ -273,7 +273,7 @@ impl<E: EppExtension> DomainTransferApprove<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainTransferReject instance
@@ -348,7 +348,7 @@ impl<E: EppExtension> DomainTransferReject<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainTransferCancel instance
@@ -423,7 +423,7 @@ impl<E: EppExtension> DomainTransferCancel<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainTransferQuery instance

epp-client/src/domain/update.rs

@@ -66,7 +66,7 @@ impl<E: EppExtension> EppRequest<E> for DomainUpdate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an DomainUpdate instance

epp-client/src/extensions/namestore.rs

@@ -45,7 +45,7 @@ pub const XMLNS: &str = "http://www.verisign-grs.com/epp/namestoreExt-1.1";
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     let namestore_ext = NameStore::new("com");

epp-client/src/extensions/rgp/report.rs

@@ -47,7 +47,7 @@ use super::EPP_DOMAIN_RGP_EXT_XMLNS;
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     let pre_data =

epp-client/src/extensions/rgp/request.rs

@@ -45,7 +45,7 @@ use super::EPP_DOMAIN_RGP_EXT_XMLNS;
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an RgpRestoreRequest instance

epp-client/src/host/check.rs

@@ -58,7 +58,7 @@ impl<E: EppExtension> EppRequest<E> for HostCheck<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an HostCheck instance

epp-client/src/host/create.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for HostCreate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create a vector of IP addresses to assign to the host

epp-client/src/host/delete.rs

@@ -57,7 +57,7 @@ impl<E: EppExtension> EppRequest<E> for HostDelete<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an HostDelete instance

epp-client/src/host/info.rs

@@ -56,7 +56,7 @@ impl<E: EppExtension> EppRequest<E> for HostInfo<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an HostInfo instance

epp-client/src/host/update.rs

@@ -58,7 +58,7 @@ impl<E: EppExtension> EppRequest<E> for HostUpdate<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an HostUpdate instance

epp-client/src/lib.rs

@@ -69,7 +69,7 @@
 //!     Err(e) => panic!("Failed to create EppClient: {}",  e)
 //! };
 //!
-//! let login = Login::<NoExtension>::new("username", "password", &None);
+//! let login = Login::<NoExtension>::new("username", "password", None);
 //! client.transact(login, "transaction-id").await.unwrap();
 //!
 //! // Make a domain check call, which returns an object of type EppDomainCheckResponse

epp-client/src/login.rs

@@ -29,11 +29,9 @@ impl<E: EppExtension> Login<E> {
     pub fn new(
         username: &str,
         password: &str,
-        ext_uris: &Option<Vec<String>>,
+        ext_uris: Option<Vec<String>>,
     ) -> Login<NoExtension> {
-        let ext_uris = ext_uris
-            .as_ref()
-            .map(|uris| uris.iter().map(|u| u.as_str().into()).collect());
+        let ext_uris = ext_uris.map(|uris| uris.iter().map(|u| u.as_str().into()).collect());
 
         Login {
             request: LoginRequest {

epp-client/src/message/ack.rs

@@ -54,7 +54,7 @@ impl<E: EppExtension> EppRequest<E> for MessageAck<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an MessageAck instance

epp-client/src/message/poll.rs

@@ -55,7 +55,7 @@ impl<E: EppExtension> EppRequest<E> for MessagePoll<E> {
 ///         Err(e) => panic!("Failed to create EppClient: {}",  e)
 ///     };
 ///
-///     let login = Login::<NoExtension>::new("username", "password", &None);
+///     let login = Login::<NoExtension>::new("username", "password", None);
 ///     client.transact(login, "transaction-id").await.unwrap();
 ///
 ///     // Create an MessagePoll instance

epp-client/src/tests/se.rs

@@ -64,7 +64,7 @@ mod request {
         ]);
 
         let xml = get_xml("request/login.xml").unwrap();
-        let object = Login::<NoExtension>::new("username", "password", &ext_uris);
+        let object = Login::<NoExtension>::new("username", "password", ext_uris);
         let serialized = object.serialize_request(CLTRID).unwrap();
 
         assert_eq!(xml, serialized);