This also makes `Parameter` type an enum so future type support for
other parameters can be more easily added. Note that the enum is
non-exhaustive so that future variant addtions would not cause API
breaks.
Fixes a clippy warning:
```
warning: single-character string constant used as pattern
--> src/utils.rs:11:46
|
11 | escaped = Cow::Owned(escaped.replace("\"", "\\\""));
| ^^^^ help: try using a `char` instead: `'\"'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
```
Fixes a clippy warning:
```
warning: redundant closure
--> src/parse/mod.rs:70:9
|
70 | |s| unescape_quoted(s),
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `unescape_quoted`
|
= note: `#[warn(clippy::redundant_closure)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
```
This fixes a clippy warning but does even better than suggested:
```
warning: this call to `from_str_radix` can be replaced with a call to `str::parse`
--> src/parse/response.rs:119:13
|
119 | |s| u16::from_str_radix(s, 10),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::<u16>()`
|
= note: `#[warn(clippy::from_str_radix_10)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10
```
* ehlo_ok_resp returns `EhloOkResp` now
* Converted some &[u8] parser to &str
* Added unit test
* Changed ehlo_line to accept "AUTH=LOGIN PLAIN" (note the "=")
Dirkjan Ochtman
Zeeshan Ali
Damian Poddebniak