From 57ea45ff51f30b219a2902d441012471795f0265 Mon Sep 17 00:00:00 2001 From: Samantaz Fox Date: Thu, 11 Mar 2021 00:42:13 +0000 Subject: [PATCH 1/3] content_to_comment_html: Fix /watch links + make newline replace universal --- src/invidious/comments.cr | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/invidious/comments.cr b/src/invidious/comments.cr index 13ebbd73..20e64a08 100644 --- a/src/invidious/comments.cr +++ b/src/invidious/comments.cr @@ -488,8 +488,12 @@ def replace_links(html) length_seconds = decode_time(anchor.content) end - anchor["href"] = "javascript:void(0)" - anchor["onclick"] = "player.currentTime(#{length_seconds})" + if length_seconds > 0 + anchor["href"] = "javascript:void(0)" + anchor["onclick"] = "player.currentTime(#{length_seconds})" + else + anchor["href"] = url.request_target + end end end @@ -528,11 +532,7 @@ end def content_to_comment_html(content) comment_html = content.map do |run| - text = HTML.escape(run["text"].as_s) - - if run["text"] == "\n" - text = "
" - end + text = HTML.escape(run["text"].as_s).gsub("\n", "
") if run["bold"]? text = "#{text}" @@ -559,7 +559,7 @@ def content_to_comment_html(content) length_seconds = watch_endpoint["startTimeSeconds"]? video_id = watch_endpoint["videoId"].as_s - if length_seconds + if length_seconds && length_seconds.as_i > 0 text = %(#{text}) else text = %(#{text}) From b86476410fe4482c1851fd1a9e69e3f14452c8a5 Mon Sep 17 00:00:00 2001 From: Samantaz Fox Date: Thu, 11 Mar 2021 00:44:35 +0000 Subject: [PATCH 2/3] playlists: Fix description being simple text (issue #1767) --- src/invidious/playlists.cr | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/invidious/playlists.cr b/src/invidious/playlists.cr index 25797a36..69547457 100644 --- a/src/invidious/playlists.cr +++ b/src/invidious/playlists.cr @@ -101,6 +101,7 @@ struct Playlist property author_thumbnail : String property ucid : String property description : String + property description_html : String property video_count : Int32 property views : Int64 property updated : Time @@ -163,10 +164,6 @@ struct Playlist def privacy PlaylistPrivacy::Public end - - def description_html - HTML.escape(self.description).gsub("\n", "
") - end end enum PlaylistPrivacy @@ -374,8 +371,15 @@ def fetch_playlist(plid, locale) title = playlist_info["title"]?.try &.["runs"][0]?.try &.["text"]?.try &.as_s || "" + desc_item = playlist_info["description"]? - description = desc_item.try &.["runs"]?.try &.as_a.map(&.["text"].as_s).join("") || desc_item.try &.["simpleText"]?.try &.as_s || "" + + description_txt = desc_item.try &.["runs"]?.try &.as_a + .map(&.["text"].as_s).join("") || desc_item.try &.["simpleText"]?.try &.as_s || "" + + description_html = desc_item.try &.["runs"]?.try &.as_a + .try { |run| content_to_comment_html(run).try &.to_s } || "

" + thumbnail = playlist_info["thumbnailRenderer"]?.try &.["playlistVideoThumbnailRenderer"]? .try &.["thumbnail"]["thumbnails"][0]["url"]?.try &.as_s @@ -415,7 +419,8 @@ def fetch_playlist(plid, locale) author: author, author_thumbnail: author_thumbnail, ucid: ucid, - description: description, + description: description_txt, + description_html: description_html, video_count: video_count, views: views, updated: updated, From 3de39698dd0ad1ec28c6b4f5ce20d8ca38807945 Mon Sep 17 00:00:00 2001 From: Samantaz Fox Date: Thu, 11 Mar 2021 03:46:17 +0000 Subject: [PATCH 3/3] Make the build tests happy: remove blank lines --- src/invidious/playlists.cr | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/invidious/playlists.cr b/src/invidious/playlists.cr index 69547457..0251a69c 100644 --- a/src/invidious/playlists.cr +++ b/src/invidious/playlists.cr @@ -371,7 +371,6 @@ def fetch_playlist(plid, locale) title = playlist_info["title"]?.try &.["runs"][0]?.try &.["text"]?.try &.as_s || "" - desc_item = playlist_info["description"]? description_txt = desc_item.try &.["runs"]?.try &.as_a @@ -380,7 +379,6 @@ def fetch_playlist(plid, locale) description_html = desc_item.try &.["runs"]?.try &.as_a .try { |run| content_to_comment_html(run).try &.to_s } || "

" - thumbnail = playlist_info["thumbnailRenderer"]?.try &.["playlistVideoThumbnailRenderer"]? .try &.["thumbnail"]["thumbnails"][0]["url"]?.try &.as_s