From fe5b81f2c3caf37e10fd3284a49146e7aefb1530 Mon Sep 17 00:00:00 2001
From: techmetx11
Date: Mon, 16 Jan 2023 13:58:05 +0100
Subject: [PATCH] Add support for multiple songs
---
assets/css/default.css | 35 ++++++++++++++++++++--------
locales/en-US.json | 5 ++--
src/invidious/videos.cr | 12 +++++++---
src/invidious/videos/music.cr | 12 ++++++++++
src/invidious/videos/parser.cr | 33 ++++++++++++++------------
src/invidious/views/watch.ecr | 42 +++++++++++++++++++++++++---------
6 files changed, 97 insertions(+), 42 deletions(-)
create mode 100644 src/invidious/videos/music.cr
diff --git a/assets/css/default.css b/assets/css/default.css
index 80bf6a20..4ec6f720 100644
--- a/assets/css/default.css
+++ b/assets/css/default.css
@@ -490,26 +490,31 @@ hr {
}
/* Description Expansion Styling*/
-#descexpansionbutton {
+#descexpansionbutton,
+#musicdescexpansionbutton {
display: none
}
-#descexpansionbutton ~ div {
+#descexpansionbutton ~ div,
+#musicdescexpansionbutton ~ div {
overflow: hidden;
height: 8.3em;
}
-#descexpansionbutton:checked ~ div {
+#descexpansionbutton:checked ~ div,
+#musicdescexpansionbutton:checked ~ div {
overflow: unset;
height: 100%;
}
-#descexpansionbutton ~ label {
+#descexpansionbutton ~ label,
+#musicdescexpansionbutton ~ label {
order: 1;
margin-top: 20px;
}
-label[for="descexpansionbutton"]:hover {
+label[for="descexpansionbutton"]:hover,
+label[for="musicdescexpansionbutton"]:hover {
cursor: pointer;
}
@@ -521,14 +526,24 @@ h4,
h5,
p,
#descriptionWrapper,
-#description-box {
- unicode-bidi: plaintext;
- text-align: start;
+#description-box,
+#music-description-box,
+#musicDescriptionWrapper {
+ unicode-bidi: plaintext;
+ text-align: start;
}
#descriptionWrapper {
- max-width: 600px;
- white-space: pre-wrap;
+ max-width: 600px;
+ white-space: pre-wrap;
+}
+
+#musicDescriptionWrapper {
+ max-width: 600px;
+}
+
+#music-description-title {
+ margin-bottom: 0px;
}
/* Center the "invidious" logo on the search page */
diff --git a/locales/en-US.json b/locales/en-US.json
index bc6a3275..20f1a46d 100644
--- a/locales/en-US.json
+++ b/locales/en-US.json
@@ -188,9 +188,8 @@
"Engagement: ": "Engagement: ",
"Whitelisted regions: ": "Whitelisted regions: ",
"Blacklisted regions: ": "Blacklisted regions: ",
- "Music artist: ": "Music artist: ",
- "Music album: ": "Music album: ",
- "Music licenses: ": "Music licenses: ",
+ "Artist: ": "Artist: ",
+ "Album: ": "Album: ",
"Shared `x`": "Shared `x`",
"Premieres in `x`": "Premieres in `x`",
"Premieres `x`": "Premieres `x`",
diff --git a/src/invidious/videos.cr b/src/invidious/videos.cr
index be4854fe..aa3ef1a8 100644
--- a/src/invidious/videos.cr
+++ b/src/invidious/videos.cr
@@ -247,6 +247,15 @@ struct Video
info["reason"]?.try &.as_s
end
+ def music : Array(VideoMusic)
+ music_list = Array(VideoMusic).new
+
+ info["music"].as_a.each do |music_json|
+ music_list << VideoMusic.new(music_json["album"].as_s, music_json["artist"].as_s, music_json["license"].as_s)
+ end
+ return music_list
+ end
+
# Macros defining getters/setters for various types of data
private macro getset_string(name)
@@ -314,9 +323,6 @@ struct Video
getset_string genre
getset_string genreUcid
getset_string license
- getset_string music_artist
- getset_string music_album
- getset_string music_licenses
getset_string shortDescription
getset_string subCountText
getset_string title
diff --git a/src/invidious/videos/music.cr b/src/invidious/videos/music.cr
new file mode 100644
index 00000000..402ae46f
--- /dev/null
+++ b/src/invidious/videos/music.cr
@@ -0,0 +1,12 @@
+require "json"
+
+struct VideoMusic
+ include JSON::Serializable
+
+ property album : String
+ property artist : String
+ property license : String
+
+ def initialize(@album : String, @artist : String, @license : String)
+ end
+end
diff --git a/src/invidious/videos/parser.cr b/src/invidious/videos/parser.cr
index 4540dd13..69b04cb6 100644
--- a/src/invidious/videos/parser.cr
+++ b/src/invidious/videos/parser.cr
@@ -311,20 +311,25 @@ def parse_video_info(video_id : String, player_response : Hash(String, JSON::Any
# Music section
- music_desc = player_response.dig?("engagementPanels", 1, "engagementPanelSectionListRenderer", "content", "structuredDescriptionContentRenderer", "items", 2, "videoDescriptionMusicSectionRenderer", "carouselLockups", 0, "carouselLockupRenderer", "infoRows").try &.as_a
- artist = nil
- album = nil
- music_licenses = nil
+ music_list = [] of VideoMusic
+ music_desclist = player_response.dig?("engagementPanels", 1, "engagementPanelSectionListRenderer", "content", "structuredDescriptionContentRenderer", "items", 2, "videoDescriptionMusicSectionRenderer", "carouselLockups").try &.as_a
+ music_desclist.try &.each do |music_desc|
+ artist = nil
+ album = nil
+ music_license = nil
- music_desc.try &.each do |desc|
- desc_title = extract_text(desc.dig?("infoRowRenderer", "title"))
- if desc_title == "ARTIST"
- artist = extract_text(desc.dig?("infoRowRenderer", "defaultMetadata"))
- elsif desc_title == "ALBUM"
- album = extract_text(desc.dig?("infoRowRenderer", "defaultMetadata"))
- elsif desc_title == "LICENSES"
- music_licenses = extract_text(desc.dig?("infoRowRenderer", "expandedMetadata"))
+ music_desc.dig?("carouselLockupRenderer", "infoRows").try &.as_a.try &.each do |desc|
+ desc_title = extract_text(desc.dig?("infoRowRenderer", "title"))
+ if desc_title == "ARTIST"
+ artist = extract_text(desc.dig?("infoRowRenderer", "defaultMetadata"))
+ elsif desc_title == "ALBUM"
+ album = extract_text(desc.dig?("infoRowRenderer", "defaultMetadata"))
+ elsif desc_title == "LICENSES"
+ music_license = extract_text(desc.dig?("infoRowRenderer", "expandedMetadata"))
+ end
end
+ music = VideoMusic.new(album.to_s, artist.to_s, music_license.to_s)
+ music_list << music
end
# Author infos
@@ -378,9 +383,7 @@ def parse_video_info(video_id : String, player_response : Hash(String, JSON::Any
"genreUcid" => JSON::Any.new(genre_ucid.try &.as_s || ""),
"license" => JSON::Any.new(license.try &.as_s || ""),
# Music section
- "music_artist" => JSON::Any.new(artist || ""),
- "music_album" => JSON::Any.new(album || ""),
- "music_licenses" => JSON::Any.new(music_licenses || ""),
+ "music" => JSON.parse(music_list.to_json),
# Author infos
"author" => JSON::Any.new(author || ""),
"ucid" => JSON::Any.new(ucid || ""),
diff --git a/src/invidious/views/watch.ecr b/src/invidious/views/watch.ecr
index beab1bb2..207dae18 100644
--- a/src/invidious/views/watch.ecr
+++ b/src/invidious/views/watch.ecr
@@ -34,11 +34,13 @@
we're going to need to do it here in order to allow for translations.
-->
@@ -196,15 +198,6 @@ we're going to need to do it here in order to allow for translations.
<% end %>
<% end %>
- <% if !video.music_artist.empty? %>
- <%= translate(locale, "Music artist: ") %><%= video.music_artist %>
- <% end %>
- <% if !video.music_album.empty? %>
- <%= translate(locale, "Music album: ") %><%= video.music_album %>
- <% end %>
- <% if !video.music_licenses.empty? %>
- <%= translate(locale, "Music licenses: ") %><%= video.music_licenses %>
- <% end %>
@@ -244,6 +237,33 @@ we're going to need to do it here in order to allow for translations.
+ <% if !video.music.empty? %>
+ <%= translate(locale, "Music") %>
+
+ <% if video.music.size == 1 %>
+
+
<%= translate(locale, "Artist: ") %><%= video.music[0].artist %>
+
<%= translate(locale, "Album: ") %><%= video.music[0].album %>
+
<%= translate(locale, "License: ") %><%= video.music[0].license %>
+
+ <% else %>
+
+
+ <% video.music.each do |music| %>
+
<%= translate(locale, "Artist: ") %><%= music.artist %>
+
<%= translate(locale, "Album: ") %><%= music.album %>
+
<%= translate(locale, "License: ") %><%= music.license %>
+
+ <% end %>
+
+
+ <% end %>
+
+
+
+ <% end %>