iv-org
/
invidious
mirror of https://github.com/iv-org/invidious.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,904 Commits 7 Branches 29 Tags 64 MiB
Commit Graph

2388 Commits

Author SHA1 Message Date
Matthew McGarvey c5967ad572
will -> should 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2022-01-25 11:35:19 -06:00
matthewmcgarvey 574e35a720 HTML escape user input 2022-01-19 09:01:13 -06:00
Samantaz Fox 32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments 
Fix loading reddit comments when there are no threads found
 2022-01-19 12:53:20 +01:00
matthewmcgarvey 56e505164d 404 error with message and provide example 2022-01-18 18:56:26 -06:00
matthewmcgarvey d4f3139b73 Don't catch and provide better error message instead 2022-01-18 18:37:16 -06:00
matthewmcgarvey 97dceb3a5a Custom error on channel search, handle in search 2022-01-18 18:37:16 -06:00
matthewmcgarvey 212f6d6bf5 Fix channel search json parse to not raise 2022-01-18 18:37:16 -06:00
Samantaz Fox 8c2495a399
Apply suggestions from review 2022-01-17 21:47:29 +01:00
matthewmcgarvey 9233f71549 Use &.methods where possible instead of curly braces 2022-01-17 13:03:36 -06:00
matthewmcgarvey b2a738cf13 Fix loading reddit comments when there are no threads found 2022-01-17 12:11:47 -06:00
Samantaz Fox 34a79c5f1e
Don't show "next steps" message with a stack trace 
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
 2022-01-16 16:15:23 +01:00
Samantaz Fox a2600acfa9
Improve crash page messages 
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
 2022-01-16 16:15:23 +01:00
Samantaz Fox 250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus 
Fix search autofocus
 2022-01-16 15:24:27 +01:00
Samantaz Fox 6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import 
Add CSV Subscriptions Import
 2022-01-16 15:11:37 +01:00
Samantaz Fox 6cf6c56dd1
Autofocus search bar only on search homepage 2022-01-13 22:19:19 +01:00
Samantaz Fox 8b72481b8c
Fix comments 
"ReplyCount" is actually an Int, not a String.
 2022-01-13 20:43:46 +01:00
Samantaz Fox aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales 
Better support of plurals in locales
 2022-01-13 12:55:55 +01:00
Samantaz Fox eff8b23f57
Improve youtube import type detection 
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
 2022-01-12 18:13:15 +01:00
Samantaz Fox 81a2300af8
Prevent import of insanely large files 2022-01-12 01:28:58 +01:00
Samantaz Fox fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels 
Update to fetch related channels again
 2022-01-11 01:50:48 +01:00
matthewmcgarvey dc62b6ffdb Can fetch related channels using just the channel ucid] 2022-01-10 17:07:52 -06:00
Samantaz Fox eb7e79fdf7
i18n: Apply code review suggestions + code cleaning 2022-01-10 22:49:07 +01:00
Samantaz Fox 37c953e633
i18n: Use plurals for tokens/replies/unseen notifications 2022-01-10 22:49:07 +01:00
Samantaz Fox 5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts 2022-01-10 22:49:07 +01:00
Samantaz Fox 692f4e5be2
i18n: Use plurals for year/month/day/etc... 2022-01-10 22:49:07 +01:00
Samantaz Fox 7bb1471207
i18n: Add dedicated function for counts translation 2022-01-10 22:49:07 +01:00
Samantaz Fox 4752e16ad2
i18n: make multiple fixes to i18next plurals 2022-01-10 22:49:07 +01:00
Samantaz Fox 67d2635e41
i18n: Add i18next plural rules and selector 2022-01-10 22:26:45 +01:00
Samantaz Fox 71a1ad307c
i18n: Add i18next plural resolver class 2022-01-10 22:26:45 +01:00
Samantaz Fox 9a48fd81a3
i18n: Add i18next plurals base sets 2022-01-10 22:26:45 +01:00
Samantaz Fox 790b7afcca
Fix indefinitely growing database 2022-01-09 22:04:10 +01:00
matthewmcgarvey 4962c00ba8 Update to fetch related channels again 2022-01-08 12:31:16 -06:00
bbielsa 6764185543
Add explicit return keyword 2022-01-08 18:07:07 +01:00
bbielsa 0a66a68db8
Move require statement to the correct file 2022-01-08 18:07:07 +01:00
bbielsa 8d47ec714e
Add text/xml as a possible mime type for xml file uploads 2022-01-08 18:07:07 +01:00
bbielsa 9607fe03af
Detect the type of subscription import format based on the content type of the file uploaded 2022-01-08 18:07:06 +01:00
bbielsa 62057e676a
Move parse_subscription_export_csv function to user/imports.cr 2022-01-08 18:07:06 +01:00
bbielsa 43ff3be751
Test if body content is likely JSON, if so parse the json format of subscriptions export. If the content is anything else, assume it is CSV and parse 2022-01-08 18:07:06 +01:00
bbielsa 7cbd79fee5
Add helper function parse_subscription_export_csv() which parses the csv format returned by the subscription exporter 2022-01-08 18:07:06 +01:00
Samantaz Fox 5a728243a2
Merge pull request #2767 from SamantazFox/fix-subscriptions-not-cleared 
Fix subscription not being cleared
 2022-01-06 14:17:33 +01:00
matthewmcgarvey 2eb7c5c037 PR feedback 2022-01-05 20:15:42 -06:00
matthewmcgarvey ba0bc72d0b delete_by_playlist_id -> delete_by_playlist 2022-01-05 19:03:32 -06:00
matthewmcgarvey e1219cbdef Fix playlist deletion 2022-01-05 18:24:04 -06:00
Samantaz Fox bf0a48847c
DB: fix subscription not being cleared 
Fixes https://github.com/iv-org/invidious/issues/2764
 2022-01-05 19:58:24 +01:00
Samantaz Fox 3bb7fbb2f1
Merge pull request #2719 from SamantazFox/batch-minor-fixes 
Multiple minor fixes
 2022-01-05 17:20:57 +01:00
TheFrenchGhosty 326a362eb8
Merge pull request #2685 from SamantazFox/database-improvments 
Database improvements
 2022-01-05 09:40:39 +00:00
TheFrenchGhosty fdc380e7f7
Merge pull request #2677 from SamantazFox/decompression-fix-2 
Temporarily fix for #2612 (round 2)
 2022-01-05 09:38:53 +00:00
Samantaz Fox 444b1c99d0
Show unavailable videos in playlists 2022-01-05 03:32:54 +01:00
Samantaz Fox 3b1a286290
Use dig?() for playlist title 2022-01-05 03:32:54 +01:00
Samantaz Fox 6c8a5a1e7f
Fix leading spaces being collapsed in descriptions 
Fixes #1954
 2022-01-05 03:32:54 +01:00
Samantaz Fox 1769b0fdce
Fix "video can't be added to playlist without JS" 
Fixes #2686
 2022-01-05 03:32:54 +01:00
Samantaz Fox 68cbc11810
Fix the search box 
Fix #277 : autoselect search field
Fix #1107: no spell checking/auto-correct on search field
 2022-01-05 03:32:44 +01:00
Samantaz Fox 302fecbdcb
Clean useless database arguments (5/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox d74873fed1
Clean useless database arguments (4/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox 40ed4a0506
Clean useless database arguments (3/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox c25d664edc
Clean useless database arguments (2/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox 9bad7e2940
Clean useless database arguments (1/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox 6704ce3214
Move DB utility functions to the proper module 2022-01-04 17:15:43 +01:00
Samantaz Fox 914cfbd953
Move DB queries related to 'annotations' in a separate module 2022-01-04 17:15:43 +01:00
Samantaz Fox 85cf27119c
Move DB queries related to playlists in a separate module (3/3) 2022-01-04 17:15:43 +01:00
Samantaz Fox 7691f53520
Move DB queries related to 'users' in a separate module (2/2) 2022-01-04 17:15:43 +01:00
Samantaz Fox 094f835642
Move DB queries related to 'users' in a separate module (1/2) 2022-01-04 17:13:52 +01:00
Samantaz Fox 92eea3b18b
Move DB queries related to session tokens in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox c021b93b5c
Move DB queries related to channels in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox d94d4c2045
Move DB queries related to statistics in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox 46d08237c6
Move DB queries related to playlists in a separate module (2/3) 2022-01-04 17:13:52 +01:00
Samantaz Fox 3deafe9f8d
Move DB queries related to playlists in a separate module (1/3) 2022-01-04 17:13:51 +01:00
Samantaz Fox 998edba6f0
Move DB queries related to 'videos' in a separate module 2022-01-04 17:13:51 +01:00
Samantaz Fox a779cdd463
Merge pull request #2727 from SamantazFox/add-shorts-support 
Add support for shorts
 2021-12-28 22:13:36 +01:00
Samantaz Fox fc2b9031d4
i18n: Add Serbian back 2021-12-22 00:52:08 +01:00
Samantaz Fox 28a6589a1e
Merge pull request #2538 from bbielsa/player-remember-position 
Retain video time position in video player
 2021-12-21 22:05:43 +01:00
Samantaz Fox ddb06b0cac
Fix XSS vulnerability in channel playlists 
The channel/<ucid>/playlists page was vulnerable to Cross Site Scripting
(XSS), because the different URL parameters were inserted as-is in the URL
meant for instance switching.

This vulnerability could allow an attacker to inject malicious Javascript
in the page by tricking the user to click on a crafted link.

Bug introduced in commit 66e7285108
("Only use /redirect when automatically redirecting").

Thanks to Jack (@testa:cthd.icu on Matrix, @cysea on github) for responsibly
reporting this issue!
 2021-12-19 20:51:44 +01:00
Samantaz Fox f54e247eb4
Extractors: Add support for shorts 
Fixes #2708
 2021-12-17 16:47:41 +01:00
bbielsa b90bceb2dc Fix formatting of preferences.cr and videos.cr 2021-12-15 19:38:58 +01:00
bbielsa f31bd5ffb9 Use localization for save player position label in the preferences page 2021-12-15 19:38:56 +01:00
bbielsa 5abe7fe123 Rename 'remember_position' to 'save_player_pos' for clarity 2021-12-15 19:37:55 +01:00
bbielsa a6a0bbf398 Add remember_position field to the Preferences and VideoPreferences structs, and add a checkbox in the preferences page to toggle it 2021-12-15 19:37:55 +01:00
Samantaz Fox ee91effb7a
Merge pull request #2576 from SamantazFox/fix-locales-handling 
Fix locales handling
 2021-12-12 22:26:22 +01:00
Samantaz Fox f236a6872b
Merge pull request #2659 from SamantazFox/fix-likes-dislikes 
Fix likes/dislikes
 2021-12-06 03:52:38 +01:00
Samantaz Fox 3e0096f360
Merge pull request #2683 from iv-org/SamantazFox-patch-1 
Fix #2682
 2021-12-02 15:35:00 +01:00
Samantaz Fox 438b334320
Merge pull request #2671 from matthewmcgarvey/code-removal 
Remove dead code
 2021-12-01 20:49:23 +01:00
Samantaz Fox 4aa96ecab9
Use 'dig()' in 'find()' statements 2021-12-01 17:32:10 +01:00
Samantaz Fox 7b9d26d688
Fix #2670 
Fixes "Download widget replaces spaces in filename with +"
https://github.com/iv-org/invidious/issues/2670
 2021-11-29 23:12:55 +01:00
matthewmcgarvey 8d4b4cd14c Remove dead code 2021-11-29 09:11:50 -06:00
Samantaz Fox 342fc202a7
Fix #2682 
Fix "Missing param name: "q" (KeyError)"
https://github.com/iv-org/invidious/issues/2682
 2021-11-29 14:53:27 +01:00
Samantaz Fox 4436359d07
Use dig to get category contents 
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
 2021-11-28 23:44:37 +01:00
Samantaz Fox 91f8395222
Typo: missing '?' when looking for key in dislikes_button 
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
 2021-11-28 23:37:27 +01:00
Samantaz Fox de00e86cd5
Decompress the response body ourselves 
Temp fix for #2612
 2021-11-28 18:04:12 +01:00
Émilien Devos c6e086c6ff
Revert "Temporarily fix for #2612" (#2673) 2021-11-28 09:41:16 +01:00
Samantaz Fox 82f3eda82b
Merge pull request #2656 from SamantazFox/fix-2549 
extract_video_info: Make sure that the Android player response is valid
 2021-11-28 02:38:29 +01:00
Samantaz Fox 05f9613e14
Merge pull request #2623 from SamantazFox/temp-decompression-fix 
Temporarily fix for #2612
 2021-11-28 02:35:39 +01:00
Samantaz Fox ceb1feb350
likes/dislikes: better fallback management 
'.to_i64?' instead of '.to_i64' returns nil rather than raising
an exception when it's done on an empty string.

In some rare cases, rating can be equal to 5. In this case, the
value of player_response[videoDetails][averageRating] is an
Int and not a Float.
 2021-11-25 23:16:50 +01:00
Samantaz Fox 2ea0590b03
i18n: return 'key' if 'key' is not in locales files 2021-11-25 19:46:34 +01:00
Samantaz Fox 80a513baa5
Use new techniques to get (dis)likes back 2021-11-24 01:22:09 +01:00
Samantaz Fox ba48f68fc3
allow multiple, successive content-encodings 2021-11-21 18:16:05 +01:00
Samantaz Fox 319587e2f1
extract_video_info: make sure that the Android player response is valid 2021-11-21 17:34:17 +01:00
Samantaz Fox bf7952d9c7
i18n: log a warning instead of rising an exception 
This is more user-friendly.
TODO: maybe make a compile time flag for testing purposes
 2021-11-21 01:54:54 +01:00
Samantaz Fox f29ab53aff
Add other missing translations 
* on watch page and video cards (search results, playlists, etc...)
* on /feed/playlists
* in search filters (not normalized in order to avoid collisions with
an existing PR that reworks the search filters)
 2021-11-21 01:54:46 +01:00
Samantaz Fox b5b0c58de7
Add missing translation for quality selectors 2021-11-21 01:50:11 +01:00
Samantaz Fox a1bb421eec
Remove useless 'hl' parameters on captions URL 2021-11-21 01:50:11 +01:00
Samantaz Fox 139786b9ef
i18n: pass only the ISO code string to 'translate()' 
Don't use the whole Hash everywhere.
Also fall back nicely to english string if no translation exists.
 2021-11-21 01:50:11 +01:00
Samantaz Fox 301444563b
i18n: Use language full name instead of ISO code 
Fixes #851
 2021-11-21 01:50:11 +01:00
Samantaz Fox 9966c21c6b
i18n: Add list of language names 2021-11-21 01:50:11 +01:00
babababag fd54cf2d05
Escape video description 2021-11-17 12:04:30 +00:00
Samantaz Fox 2c447a42f2
Make sure to only apply fix if QUIC is disabled 2021-11-16 21:40:35 +01:00
Samantaz Fox dad8f9a0ce
Fix typo 
Should be checking the returned headers, not the sent ones.
 2021-11-16 20:39:26 +01:00
Samantaz Fox 2eac23a0b3
Temporary fix for #2612 
Don't rely on the auto compression/decompression provided by the crystal stdlib.
 2021-11-16 13:46:28 +01:00
Samantaz Fox 00904ae3f2
Merge pull request #2444 from syeopite/only-use-redirect-endpoint-when-needed 
Only use the /redirect endpoint when automatically redirecting to another instance
 2021-11-13 20:40:09 +01:00
Émilien Devos d214a0b333
remove duplicate lsquic requirement 2021-11-12 23:02:43 +00:00
syeopite a120f143d7
Disable quic by default 
See #2577
 2021-11-12 04:03:23 -08:00
syeopite 65fbdbff6a
Remove of gzip header w/ use_quic config 
Continuation of b0f127d4d8
 2021-11-12 03:52:50 -08:00
syeopite 6ec4dcfafd
Fix handling for maxres thumbnail 2021-11-12 03:47:58 -08:00
syeopite 48191aca6e
Fix copy-paste error 2021-11-12 03:47:57 -08:00
syeopite 83556bace2
Allow thumbnail queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite 814c9e6c3a
Use https for storyboard image requests 2021-11-12 03:47:57 -08:00
syeopite 547abe17d9
Use https for ggpht requests 2021-11-12 03:47:57 -08:00
syeopite 6b8450558d
Allow storyboard queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite c3747c2d49
Allow ggpht queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite 245122104a
Respect use_quic param and fix typos 2021-11-12 03:47:57 -08:00
syeopite b0f127d4d8
Fix gzip decompression with HTTP::Client 2021-11-12 03:47:57 -08:00
syeopite d379a36c0e
Add compile-time flag to remove code for QUIC 2021-11-12 03:47:50 -08:00
Samantaz Fox 6cf0ff6b49
Remove useless auto_generated param from PlaylistVideo#to_xml 
given the variables available in this function's context, 'author' and 'ucid'
provide the same data 'self.author' and 'self.ucid', respectively.

Given that fact, the variable `auto_generated` has no impact on the logic of
this function, and hence can be safely removed. this greatly simplifies the
code and makes it perfectly compatible with crystal's calling convention for
'#to_xml' methods.
 2021-10-29 16:26:42 +02:00
Samantaz Fox 86f75758a7
Fix 'to_json' in struct PlaylistVideo 2021-10-29 16:26:42 +02:00
Samantaz Fox 0ec94405ce
Add TODO comments to other places 2021-10-29 16:26:42 +02:00
Samantaz Fox 33780f1995
Also fix 'to_json' in struct Video 2021-10-29 16:26:35 +02:00
Samantaz Fox 1cb715ac9f
serialized_yt_data: force datatype of 'locale' 2021-10-28 17:48:08 +02:00
Samantaz Fox f65b628bf3
serialized_yt_data: Remove default nil value in to_json 
this will ensure that two parameters are passed and that it
doesn't collide with 'to_json(builder)'
 2021-10-28 17:48:07 +02:00
Samantaz Fox 60fa552469
Fix an infinite recursion caused by #2228 
Changes in the aforementioned PR lead to change the behavior
of some old code.

The data type of the parameters aren't explicit enough, which
makes the compiler use the wrong method because of type infering.
 2021-10-28 17:48:07 +02:00
syeopite 437bdedb07
Use env.request.resource for instance switch link 2021-10-26 16:12:25 -07:00
syeopite a531f4f057
Rebase error 2021-10-26 16:12:25 -07:00
syeopite bb396a310e
Remove unneeded redirect.invidious.io code in /redirect 2021-10-26 16:12:25 -07:00
syeopite 66e7285108
Only use /redirect when automatically redirecting 2021-10-26 16:12:16 -07:00
Samantaz Fox 2b81a82620
Merge pull request #2529 from DmitrySandalov/master 
Feature Request: Localization for trending iv-org#331
 2021-10-26 23:49:56 +02:00
Samantaz Fox b555df8377
Merge pull request #2428 from syeopite/ameba-fixes 
Fix (some) issues detected by Ameba
 2021-10-26 23:34:18 +02:00
Samantaz Fox 232730e909
Merge branch 'master' into master 2021-10-26 23:31:48 +02:00
Samantaz Fox 1e0712625a
Normalize translation key for preferences categories 
categories normalized:
 - Miscellanous
 - Player
 - Visual
 - Administrator
 - Data
 - Subscription
 2021-10-26 23:17:04 +02:00
Samantaz Fox 88752f32bd
Normalize translation key for user prefrerences 
preferences normalized:
 - annotations
 - annotations_subscribed
 - automatic_instance_redirect
 - autoplay
 - captions
 - comments
 - continue
 - continue_autoplay
 - dark_mode
 - default_home
 - extend_desc
 - feed_menu
 - listen
 - local
 - locale
 - max_results
 - notifications_only
 - player_style
 - quality
 - quality_dash
 - related_videos
 - show_nick
 - sort
 - speed
 - thin_mode
 - unseen_only
 - video_loop
 - volume
 - vr_mode
 2021-10-26 23:15:39 +02:00
syeopite e2bbc9a6fa
Switch to #sort_by! in pull_popular_videos job 2021-10-25 01:14:14 -07:00
syeopite 17e481c107
Reduce block verbosity further 2021-10-25 01:14:14 -07:00
syeopite b8f27a42a7
Optimize assigning of on_response_received_endpoints 2021-10-25 01:14:14 -07:00
syeopite 575c66efd3
Remove extra dot between [] from ambea copy-pasting. 2021-10-25 01:14:14 -07:00
syeopite 88ad7c8d8d
Update src/invidious/routes/playlists.cr 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2021-10-25 01:14:09 -07:00
syeopite 1adcac175e
Update src/invidious/routes/channels.cr 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2021-10-25 01:14:09 -07:00
syeopite dd8c412abc
Fix Style/IsAFilter issues 2021-10-25 01:14:08 -07:00
syeopite e969c1490a
Fix Performance/ChainedCallWithNoBang issues 2021-10-25 01:12:26 -07:00
syeopite e91421253e
Fix Style/VerboseBlock issues 2021-10-25 01:12:26 -07:00
syeopite 35d15c7c2b
Fix Style/VariableNames issues 2021-10-25 01:12:26 -07:00
syeopite 20cb751ff6
Fix Lint/UnusedArgument issues 2021-10-25 01:12:26 -07:00
syeopite 0614b52f03
Fix Lint/RedundantStringCoercion issues 2021-10-25 01:12:19 -07:00
Dmitry Sandalov a629521c37
Feature Request: Localization for trending (remove region from server config) 2021-10-25 10:57:27 +03:00
Dmitry Sandalov 0e17d026f2
Feature Request: Localization for trending (fix lint CONTENT_REGIONS end comma) 2021-10-21 23:38:49 +03:00
Dmitry Sandalov 1d78d67af3
Feature Request: Localization for trending (move TRENDING_REGIONS to i18n.cr as CONTENT_REGIONS) 2021-10-21 22:30:49 +03:00
Dmitry Sandalov d9c58c4837
Feature Request: Localization for trending iv-org#331 2021-10-21 14:54:15 +03:00
syeopite 129779a757
Merge pull request #2433 from iv-org/increase-channel-refresh-delay 
Decrease channel refresh frequency (1 min -> 1 h)
 2021-10-20 19:12:35 +00:00
syeopite c8a985cc77
Merge pull request #2477 from SamantazFox/move-prefs-and-config 
Move user preferences and server config
 2021-10-18 17:06:07 +00:00
Samantaz Fox cb9b84f940
Move 'extract_text()' to 'extractors_utils.cr' 2021-10-18 16:14:37 +02:00
Samantaz Fox 33d9be0ffb
Move 'extractors.cr' to 'yt_backend' folder 2021-10-18 16:12:49 +02:00
Samantaz Fox 2571e420f3
Move 'add_yt_headers()' to 'connection_pool.cr' 2021-10-18 16:12:18 +02:00
Samantaz Fox e17c8b1f4d
Move 'extract_videos' and 'extract_selected_tab' too 2021-10-18 16:12:18 +02:00
Samantaz Fox 8805ee7c8c
Add fetch_continuation_token back (required by #2215) 2021-10-18 16:12:18 +02:00
Samantaz Fox 7df2fd0bc8
Add 'require' statement to 'invidious.cr' 2021-10-18 16:12:17 +02:00
Samantaz Fox f7f0910953
Remove fetch_continuation_token(): dead code 2021-10-18 16:12:17 +02:00
Samantaz Fox d300797e22
Move the YoutubeConnectionPool code to its own file 2021-10-18 16:12:17 +02:00
Samantaz Fox 56dbe15943
Move proxy & YoutubeAPI code to the yt_backend folder 2021-10-18 16:12:17 +02:00
syeopite 5f65e92500
Merge pull request #2508 from syeopite/lazy-load-images 
Lazy load (some) images
 2021-10-17 18:25:59 +00:00
syeopite 21b96a3159
Merge pull request #2506 from syeopite/handle-empty-playlist-tabs 
Handle YT tabs without content
 2021-10-15 22:13:25 +00:00
syeopite 888c7e2c29
Merge pull request #2491 from syeopite/extract-image-routes 
Extract image routes
 2021-10-15 22:13:10 +00:00
TheFrenchGhosty 22e8f7e287 Fix #2510 2021-10-14 21:00:14 +02:00
TheFrenchGhosty 0ad2793b68 Link to invidious.io/donate/ in the footer 2021-10-14 20:20:25 +02:00
syeopite 585e4617e8
Lazy load (some) images 2021-10-14 08:18:44 -07:00
syeopite 4d44b2c3a4
Handle YT tabs without any content 2021-10-13 11:38:20 -07:00
syeopite b49b5fbda9
Support empty categories 2021-10-13 11:35:31 -07:00
syeopite 17e6093abb
Merge pull request #2497 from Yetangitu/videorendererparser_parse_missing_title 
Handle missing title fields in VideoRendererParser.parse (fixes #2495)
 2021-10-12 19:04:51 +00:00
Frank de Lange 3dc980e800
Fix for #2488 - parse contents of search results of type=Category (#2496) 
* Fix for #2488 - parse contents of search results of type=Category (returned on first page for universal (type=all) queries instead of returning an error.

* Moved content array walker to Category#to_json

As requested by reviewer this change moves the content array walker from the API endpoint to the Category class.

* Update src/invidious/helpers/serialized_yt_data.cr

Co-authored-by: syeopite <70992037+syeopite@users.noreply.github.com>
 2021-10-12 18:17:45 +00:00
Frank de Lange c44c1003af Handle missing title fields in VideoRendererParser.parse 2021-10-12 14:56:15 +00:00
Samantaz Fox 678b10dbcf
Lookback 50 videos 2021-10-11 23:52:57 +02:00
diogo a1d6411f1f
propagate video_id field on getting playlists 2021-10-11 23:51:07 +02:00
diogo c4c8a10507
rename from continuation to video_id on get_playlist_videos 2021-10-11 23:49:08 +02:00
diogo ee94ccdeb0
update to new YoutubeAPI 2021-10-11 23:49:08 +02:00
diogo e3df9f9ead
use dig for getting the video index 2021-10-11 23:49:08 +02:00
diogo 62dc629337
linting 2021-10-11 23:49:08 +02:00
diogo dccdf38ce7
increase the max videos in a playlist 2021-10-11 23:49:07 +02:00
diogo 84124b837d
use v1/next instead of searching for the continuation index 2021-10-11 23:49:07 +02:00
diogo 6176da3cbb
linting 2021-10-11 23:46:23 +02:00
diogo 24bc3e2704
no need to normalize the offset 2021-10-11 23:45:22 +02:00
diogo 0a9e19646a
pass the api/v1/playlists with videos before the offset 2021-10-11 23:43:41 +02:00
diogo 65e45c4079
linting 2021-10-11 23:30:49 +02:00
diogo 440105976f
fix cases when high offset video from playlist has no offset in url 2021-10-11 23:30:49 +02:00
diogo 7eba7fbcc7
add index to playlist item 2021-10-11 23:30:49 +02:00
diogo d9bfb3d305
playlist starts at the offset 2021-10-11 23:30:49 +02:00
syeopite 4246c7a523
Extract image routes 2021-10-11 13:22:11 -07:00
Samantaz Fox 57ed047025
Add mising 'require' statement to 'invidious.cr' 2021-10-11 18:33:36 +02:00
Samantaz Fox bda3a26423
Move server structure to a separate file 2021-10-11 18:33:36 +02:00
Samantaz Fox 080d9a8dc7
move theme converter function to a separate file 2021-10-11 18:33:36 +02:00
Samantaz Fox 984a4acc7b
Move user preferences structure to a separate file 2021-10-11 18:33:36 +02:00
syeopite b10f37bea9
Use kemal in production mode (#2455) 2021-10-11 14:42:22 +02:00
mastihios 0947c26612
Fix URL-encoding in href strings (#2460) 
* hrefs: replace HTML.escape w/ URI.encode_www_form

* Fix search_query_encoded
 2021-10-11 05:18:20 -07:00
Samantaz Fox c6f088d6ca
Reduce refresh delay, increase backoff start duration 2021-10-08 18:39:02 +02:00
syeopite 21e29411af
Fix extractor bugs (#2454) 
* Add debug/trace logging to extract_items
* Handle invalid timestamps for livestreams extraction
* Make use of author_fallback in playlist extractor
* Don't use extract_text for video length extraction

The extract_text function attempts to extract from both the simpleText and
the runs route. This is typically what we'd want for text extraction as
it could appear in both locations. However, while this still holds true,
the thumbnailOverlayTimeStatusRenderer writes a numerical length (when
present on the video) to the simpleText route and uses runs for a
text overlay like "LIVE" or "PREMIERE".

Therefore, when a video has a text overlay instead of a numerical one,
Invidious still passes it onto decode_length_seconds, which obviously
raises since it cannot be converted into integers.

In the future, if more routes requires one text route over the other, we
should go ahead and add an argument to extract_text itself. Though for
now, this is sufficient.

* Handle unsupported "special" categories
 2021-10-07 23:39:21 +02:00
Samantaz Fox adc12addfa
Add config option to display source code URL in footer (#2450) 2021-10-07 13:53:12 +02:00
Samantaz Fox d806310665
Revert "Fix typo (#2456)" (#2457) 
This reverts commit 4982bff74d.
 2021-10-04 19:51:57 +02:00
Jorge Maldonado Ventura 4982bff74d
Fix typo (#2456) 2021-10-04 17:47:57 +00:00
syeopite 81b12b8001
Add support to make invidious API-only via flag (#2363) 2021-10-02 20:04:02 +00:00
syeopite 3e781b7d13
Merge pull request #2443 from iv-org/syeopite-patch-1 
Use make_client when querying instance api
 2021-10-02 20:00:37 +00:00
syeopite 9c44e41a4c
Merge pull request #2228 from syeopite/extract-items-overhaul 
Overhaul extract_item(s) functions and add infrastructure for parsing YouTube categories
 2021-10-02 20:00:16 +00:00
syeopite 73eabb6ca2
Actually fix lint 2021-10-02 08:53:58 -07:00
Samantaz Fox 5a52b4fe45
Fix lint 2021-10-02 17:41:25 +02:00
Samantaz Fox caa08a6379
Disable locales with less than 50% of strings translated 2021-10-02 17:38:06 +02:00
Samantaz Fox cd02078e26
Add Portuguese (pt) to locales 
follow up to #2437
 2021-10-02 17:19:28 +02:00
syeopite 77131cff91
Use make_client when querying instance api 2021-10-02 15:16:07 +00:00
mastihios 7b2aa5f98e
add icon-buttons to playlist items (#2442) 2021-10-02 11:59:33 +00:00
syeopite 26b28cea49
Use break instead of short-circuit return 2021-10-01 05:39:23 -07:00
syeopite 23049e026f
Improve readabltiy of SearchChannel auto-gen detect 2021-09-28 08:55:02 -07:00
syeopite 9ab242ca2e
Optimize routing logic of extract_item(s) funcs 2021-09-28 08:50:23 -07:00
syeopite aa59925374
Rename get_browse_endpoint to get_browse_id 2021-09-28 08:39:00 -07:00
syeopite 43ea8fa706
Convert nil for AuthorFallback to empty strings 2021-09-28 08:25:03 -07:00
syeopite 6df85718e6
Apply suggestions from code review 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2021-09-28 15:23:36 +00:00
Samantaz Fox 9ba3e1cdb4
Decrease channel refresh frequency (1 min -> 1 h) 
This is a temporary fix to reduce load on instances with many channels and avoid IP being flagged by Google.
 2021-09-26 23:31:14 +02:00
syeopite b20f72b963
Use default timeout (5 seconds) for YT pool (#2430) 2021-09-26 23:03:45 +02:00
syeopite 092b8a4e52
Add documentation to extractors.cr 2021-09-24 21:07:07 -07:00
syeopite e5f07dedbf
Typos and tiny styling changes 2021-09-24 21:07:07 -07:00
syeopite ca9eb0d539
Bountiful extractor changes 
- Add extract_text to simplify extraction of InnerTube texts
- Add helper extractor methods to reduce repetition in parsing InnerTube
- Change [] more than 2 blocks long to use #dig or #dig?
- Remove useless ?.try blocks for items that always exists
- Add (some) documentation to VideoRendererParser
 2021-09-24 21:07:07 -07:00
syeopite 142317c2be
Overhaul extractors.cr to use modules 2021-09-24 21:07:07 -07:00
syeopite 3dea670091
Switch to structs in extractors.cr for performance 2021-09-24 21:07:07 -07:00
syeopite 8435e79913
Improve documentation for extract_item(s) funcs 2021-09-24 21:07:07 -07:00
syeopite 30e85b40f9
Fix extract_videos 2021-09-24 21:07:07 -07:00
syeopite be1a43a337
Manually extract category refactor from 1b569bbc99 
Also fixes some errors caused by cherry-picking
 2021-09-24 21:07:07 -07:00
syeopite abca8f7a7c
Rename invidiousitems.cr 2021-09-24 21:07:07 -07:00
syeopite 7b60dac526
Add description_html field to Category 
(cherry picked from commit aa8f15f795)
 2021-09-24 21:07:07 -07:00
syeopite ea6434662d
Change typing of Category contents to only Array 
(cherry picked from commit d3384e17f1)
 2021-09-24 21:07:06 -07:00
syeopite 0b7a108a59
Move continuation_token out of Category struct 
(cherry picked from commit 0e96eda28f)
 2021-09-24 21:07:06 -07:00
syeopite 57c63f3598
Rename "items_without_cate_items" to reflect usage 2021-09-24 21:07:06 -07:00
syeopite ae30f32c36
Unpack search items that are embedded in categories 
This is a squash of a bunch of commits
cherry-picked commits

Fix category parse error on search

(cherry picked from commit cc02fed4e6)

Fix category items not being extracted in search

(cherry picked from commit 2605b9c609)

Make search not include category items for now

(cherry picked from commit ca4afd59f4)

Change behavior of categories in search results

(cherry picked from commit cc10675610)

Fix missing search results in extraction

(cherry picked from commit abda6840d5)

Fix miscount of search results

(cherry picked from commit 491e33450e)
 2021-09-24 21:07:06 -07:00
syeopite a50f64f6e9
Add parser for categories (shelfRenderer) 
This commit adds a new parser for YT's shelfRenderers which are
typically used to denote different categories.The code for featured
channels parsing has also been moved to use the new parser but some
additional refactoring are needed there.

The ContinuationExtractor has also been improved and is now capable of
extraction continuation data that is packaged under
"appendContinuationItemsAction"

In additional this commit adds some useful helper functions to extract
the current selected tab the continuation token. This is to mainly
reduce code size and repetition.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.

(cherry picked from commit 8000d538db)
 2021-09-24 21:07:06 -07:00
syeopite 1323b94b7a
Rewrite extract_item and extract_items functions 
This commit completely rewrites the extract_item and extract_items
function. Before this commit these two function were an unreadable
mess. The extract_item function was a lengthy if-elsif chain
while the extract_items function contained an incomprehensible
mess of .try, else and ||.

With this commit both of these functions have been pulled into a
separate file with the internal logic being moved to a few classes.

This significantly reduces the size of these two methods, enhances
readability and makes adding new extraction/parse rules much simpler.

See diff for details.

--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.

(cherry picked from commit a027fbf7af)
 2021-09-24 21:06:46 -07:00
syeopite 6d68fbc31d
Fix livestream regex regression caused by #2271 
Closes #2352

Special thanks to @WaywardHeart for finding this issue!
 2021-09-25 02:47:52 +00:00
syeopite 86ca568d6d
Remove login type button from frontend (#2423) 2021-09-23 08:44:26 +02:00
Walkyst 2b0bb69a4f
Fix mixes route (#2421) 2021-09-20 22:39:32 -07:00
syeopite 87f46a7532
Unregister captcha job (#2390) 2021-09-19 10:30:19 +00:00
syeopite 4a0359c04e
Pass success msg from dep script during compile-time 2021-09-18 14:48:57 -07:00
syeopite 02431b3f98
Use correct videojs-vtt-thumbnails location in licences.ecr 2021-09-18 13:30:17 -07:00
syeopite 0323202a03
Revert to iv-org fork of silvermine-videojs-quality-selector 
Upstream requires at least two additional sources. Whereas Invidious needs it to be
able to display a single additional source for normal (dashless)
qualites. Aka medium and hd720.
 2021-09-18 13:30:17 -07:00
syeopite 62c1991b88
Typo 2021-09-18 13:30:17 -07:00
syeopite 3a6085ad31
Readd player.css 2021-09-18 13:30:17 -07:00
syeopite 2451497b31
Typo 2021-09-18 13:30:17 -07:00
syeopite 06a1d2ac41
Rename fetch_videojs* to fetch_player* 2021-09-18 13:30:16 -07:00
syeopite 262131f68e
Add script to resolve and fetch VideoJS files 2021-09-18 13:30:15 -07:00
Samantaz Fox e655af251c
Try not to log search queries (#2362) 2021-09-16 09:36:22 +00:00
syeopite 5054510d15
Prevent VR from being initialized in listen mode (#2396) 2021-09-15 01:37:23 +02:00
Samantaz Fox 947fe4fbb3
HTML escape video mimetype 
Video mimetype may contain code information between double quotes.
If not properly escaped, it breaks the browser's parser. E.g:
```
type="video/mp4; codecs=" avc1.64001f,="" mp4a.40.2""=""
```

Thank Robin for catching this!
 2021-09-13 18:20:11 +02:00