Rename "Submit debug log" to "Report issue"

This commit is contained in:
Davide De Rosa 2018-10-22 22:42:42 +02:00
parent e97713f732
commit 0f374fa8c9
4 changed files with 26 additions and 20 deletions

View File

@ -39,7 +39,7 @@ class AboutViewController: UITableViewController, TableModelHost {
model.setHeader(L10n.About.Sections.Feedback.header, for: .feedback)
model.set([.version, .credits, .disclaimer, .website], in: .info)
model.set([.sourcePassepartout, .sourceTunnelKit], in: .source)
model.set([.requestSupport, .submitDebugLog, .writeReview], in: .feedback)
model.set([.requestSupport, .reportIssue, .writeReview], in: .feedback)
return model
}()
@ -82,11 +82,11 @@ class AboutViewController: UITableViewController, TableModelHost {
UIApplication.shared.open(url, options: [:], completionHandler: nil)
}
private func requestRedditSupport() {
private func postSupportRequest() {
UIApplication.shared.open(AppConstants.URLs.subreddit, options: [:], completionHandler: nil)
}
private func reportIssue() {
private func reportConnectivityIssue() {
IssueReporter.shared.present(in: self)
}
@ -148,7 +148,7 @@ extension AboutViewController {
case requestSupport
case submitDebugLog
case reportIssue
case writeReview
}
@ -207,9 +207,9 @@ extension AboutViewController {
cell.leftText = L10n.About.Cells.RequestSupport.caption
return cell
case .submitDebugLog:
case .reportIssue:
let cell = Cells.setting.dequeue(from: tableView, for: indexPath)
cell.leftText = L10n.IssueReporter.title
cell.leftText = L10n.About.Cells.ReportIssue.caption
return cell
case .writeReview:
@ -240,10 +240,10 @@ extension AboutViewController {
visitRepository(AppConstants.Repos.tunnelKit)
case .requestSupport:
requestRedditSupport()
postSupportRequest()
case .submitDebugLog:
reportIssue()
case .reportIssue:
reportConnectivityIssue()
case .writeReview:
writeReview()

View File

@ -354,11 +354,11 @@ class ServiceViewController: UIViewController, TableModelHost {
}
}
private func requestRedditSupport() {
private func postSupportRequest() {
UIApplication.shared.open(AppConstants.URLs.subreddit, options: [:], completionHandler: nil)
}
private func reportIssue() {
private func reportConnectivityIssue() {
IssueReporter.shared.present(in: self)
}
@ -441,7 +441,7 @@ extension ServiceViewController: UITableViewDataSource, UITableViewDelegate, Tog
case requestSupport
case submitDebugLog
case reportIssue
}
private var trustedSectionIndex: Int {
@ -662,9 +662,9 @@ extension ServiceViewController: UITableViewDataSource, UITableViewDelegate, Tog
cell.leftText = L10n.About.Cells.RequestSupport.caption
return cell
case .submitDebugLog:
case .reportIssue:
let cell = Cells.setting.dequeue(from: tableView, for: indexPath)
cell.leftText = L10n.IssueReporter.title
cell.leftText = L10n.About.Cells.ReportIssue.caption
return cell
}
}
@ -761,10 +761,10 @@ extension ServiceViewController: UITableViewDataSource, UITableViewDelegate, Tog
return true
case .requestSupport:
requestRedditSupport()
postSupportRequest()
case .submitDebugLog:
reportIssue()
case .reportIssue:
reportConnectivityIssue()
default:
break
@ -888,7 +888,7 @@ extension ServiceViewController: UITableViewDataSource, UITableViewDelegate, Tog
model.set([.vpnSurvivesSleep], in: .vpnSurvivesSleep)
model.set([.trustedPolicy], in: .trustedPolicy)
model.set([.testConnectivity, .dataCount, .debugLog], in: .diagnostics)
model.set([.requestSupport, .submitDebugLog], in: .feedback)
model.set([.requestSupport, .reportIssue], in: .feedback)
}
trustedNetworks.delegate = self

View File

@ -169,7 +169,7 @@
"vpn.errors.dns" = "DNS failed";
"vpn.errors.network" = "Network changed";
"issue_reporter.title" = "Submit debug log";
"issue_reporter.title" = "Report issue";
"issue_reporter.message" = "The debug log of your latest connections is crucial to resolve your connectivity issues and is completely anonymous.";
"issue_reporter.buttons.accept" = "I understand";
"issue_reporter.alerts.email_not_configured.message" = "No e-mail account is configured.";
@ -182,6 +182,7 @@
"about.sections.feedback.header" = "Feedback";
"about.cells.version.caption" = "Version";
"about.cells.request_support.caption" = "Request support";
"about.cells.report_issue.caption" = "Report connectivity issue";
"about.cells.write_review.caption" = "Write a review";
"about.cells.website.caption" = "Visit website";

View File

@ -14,6 +14,11 @@ internal enum L10n {
internal enum Cells {
internal enum ReportIssue {
/// Report connectivity issue
internal static let caption = L10n.tr("Localizable", "about.cells.report_issue.caption")
}
internal enum RequestSupport {
/// Request support
internal static let caption = L10n.tr("Localizable", "about.cells.request_support.caption")
@ -293,7 +298,7 @@ internal enum L10n {
internal enum IssueReporter {
/// The debug log of your latest connections is crucial to resolve your connectivity issues and is completely anonymous.
internal static let message = L10n.tr("Localizable", "issue_reporter.message")
/// Submit debug log
/// Report issue
internal static let title = L10n.tr("Localizable", "issue_reporter.title")
internal enum Alerts {