Add title to version screen

This commit is contained in:
Davide De Rosa 2018-10-29 20:44:01 +01:00
parent fec2f02df5
commit 17ebaccbad
4 changed files with 5 additions and 6 deletions

View File

@ -176,7 +176,7 @@ extension AboutViewController {
switch model.row(at: indexPath) { switch model.row(at: indexPath) {
case .version: case .version:
let cell = Cells.setting.dequeue(from: tableView, for: indexPath) let cell = Cells.setting.dequeue(from: tableView, for: indexPath)
cell.leftText = L10n.About.Cells.Version.caption cell.leftText = L10n.Version.title
cell.rightText = Utils.versionString() cell.rightText = Utils.versionString()
return cell return cell

View File

@ -47,6 +47,7 @@ class VersionViewController: UIViewController {
override func viewDidLoad() { override func viewDidLoad() {
super.viewDidLoad() super.viewDidLoad()
title = L10n.Version.title
labelTitle?.text = GroupConstants.App.name labelTitle?.text = GroupConstants.App.name
labelVersion?.text = Utils.versionString() labelVersion?.text = Utils.versionString()
labelIntro?.text = L10n.Version.Labels.intro labelIntro?.text = L10n.Version.Labels.intro

View File

@ -189,7 +189,6 @@
"about.sections.source.header" = "Source code"; "about.sections.source.header" = "Source code";
"about.sections.share.header" = "Share"; "about.sections.share.header" = "Share";
"about.sections.feedback.header" = "Feedback"; "about.sections.feedback.header" = "Feedback";
"about.cells.version.caption" = "Version";
"about.cells.website.caption" = "Visit website"; "about.cells.website.caption" = "Visit website";
"about.cells.share_twitter.caption" = "Tweet about it!"; "about.cells.share_twitter.caption" = "Tweet about it!";
"about.cells.share_generic.caption" = "Invite a friend"; "about.cells.share_generic.caption" = "Invite a friend";
@ -198,6 +197,7 @@
"share.message" = "Passepartout is an user-friendly, open source OpenVPN client for iOS and macOS"; "share.message" = "Passepartout is an user-friendly, open source OpenVPN client for iOS and macOS";
"version.title" = "Version";
"version.labels.intro" = "Passepartout and TunnelKit are written and maintained by Davide De Rosa (keeshux).\n\nTunnelKit is a native OpenVPN client originally forked from PIATunnel by Private Internet Access.\n\nSource code for Passepartout and TunnelKit is publicly available on GitHub under the GPLv3."; "version.labels.intro" = "Passepartout and TunnelKit are written and maintained by Davide De Rosa (keeshux).\n\nTunnelKit is a native OpenVPN client originally forked from PIATunnel by Private Internet Access.\n\nSource code for Passepartout and TunnelKit is publicly available on GitHub under the GPLv3.";
"version.buttons.changelog" = "CHANGELOG"; "version.buttons.changelog" = "CHANGELOG";
"version.buttons.credits" = "CREDITS"; "version.buttons.credits" = "CREDITS";

View File

@ -28,10 +28,6 @@ internal enum L10n {
/// Tweet about it! /// Tweet about it!
internal static let caption = L10n.tr("Localizable", "about.cells.share_twitter.caption") internal static let caption = L10n.tr("Localizable", "about.cells.share_twitter.caption")
} }
internal enum Version {
/// Version
internal static let caption = L10n.tr("Localizable", "about.cells.version.caption")
}
internal enum Website { internal enum Website {
/// Visit website /// Visit website
internal static let caption = L10n.tr("Localizable", "about.cells.website.caption") internal static let caption = L10n.tr("Localizable", "about.cells.website.caption")
@ -611,6 +607,8 @@ internal enum L10n {
} }
internal enum Version { internal enum Version {
/// Version
internal static let title = L10n.tr("Localizable", "version.title")
internal enum Buttons { internal enum Buttons {
/// CHANGELOG /// CHANGELOG
internal static let changelog = L10n.tr("Localizable", "version.buttons.changelog") internal static let changelog = L10n.tr("Localizable", "version.buttons.changelog")