passepartoutvpn
/
passepartout-apple
mirror of https://github.com/passepartoutvpn/passepartout-apple.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Restore longer localizations in Settings/About

This commit is contained in:
Davide De Rosa 2022-08-27 22:48:49 +02:00
parent f36d7596d0
commit 28f7c6bbe8
4 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Passepartout/App/Views/AboutView.swift
View File

@ -70,13 +70,14 @@ struct AboutView: View {
} }
} }
// FIXME: l10n, refactor string ids
private var supportSection: some View { private var supportSection: some View {
Section { Section {
Button(L10n.Menu.Contextual.Support.joinCommunity) { Button(L10n.Menu.System.Support.joinCommunity) {
URL.openURL(redditURL) URL.openURL(redditURL)
} }
Button(L10n.Menu.Contextual.shareTwitter, action: shareOnTwitter) Button(L10n.Menu.System.ShareTwitter.caption, action: shareOnTwitter)
Button(L10n.Menu.Contextual.Support.writeReview, action: submitReview) Button(L10n.Menu.System.Support.writeReview, action: submitReview)
} header: { } header: {
Text(L10n.Menu.All.Support.title) Text(L10n.Menu.All.Support.title)
} }

2
Passepartout/App/Views/SettingsView.swift
View File

@ -62,7 +62,7 @@ struct SettingsView: View {
NavigationLink { NavigationLink {
DonateView() DonateView()
} label: { } label: {
Text(L10n.Donate.title) Text(L10n.Menu.System.Support.donate)
}.disabled(!productManager.canMakePayments()) }.disabled(!productManager.canMakePayments())
} footer: { } footer: {
HStack { HStack {

12
Passepartout/AppShared/Constants/SwiftGen+Strings.swift
View File

@ -546,6 +546,18 @@ internal enum L10n {
return L10n.tr("Localizable", "menu.system.quit.title", String(describing: p1), fallback: "Quit %@") return L10n.tr("Localizable", "menu.system.quit.title", String(describing: p1), fallback: "Quit %@")
} }
} }
internal enum ShareTwitter {
/// Tweet about it!
internal static let caption = L10n.tr("Localizable", "menu.system.share_twitter.caption", fallback: "Tweet about it!")
}
internal enum Support {
/// Make a donation
internal static let donate = L10n.tr("Localizable", "menu.system.support.donate", fallback: "Make a donation")
/// Join community
internal static let joinCommunity = L10n.tr("Localizable", "menu.system.support.join_community", fallback: "Join community")
/// Write a review
internal static let writeReview = L10n.tr("Localizable", "menu.system.support.write_review", fallback: "Write a review")
}
} }
} }
internal enum NetworkSettings { internal enum NetworkSettings {

8
Passepartout/AppShared/en.lproj/Localizable.strings
View File

@ -82,11 +82,11 @@
//"menu.system.active_profile.messages.missing_credentials" = "No account configured"; //"menu.system.active_profile.messages.missing_credentials" = "No account configured";
//"menu.system.organizer.title" = "Organizer"; //"menu.system.organizer.title" = "Organizer";
//"menu.system.preferences.title" = "Preferences"; //"menu.system.preferences.title" = "Preferences";
//"menu.system.support.donate" = "Make a donation"; "menu.system.support.donate" = "Make a donation";
//"menu.system.support.join_community" = "Join community"; "menu.system.support.join_community" = "Join community";
//"menu.system.support.write_review" = "Write a review"; "menu.system.support.write_review" = "Write a review";
// "menu.system.support.translate" = "Offer to translate"; // "menu.system.support.translate" = "Offer to translate";
//"menu.system.share_twitter.caption" = "Tweet about it!"; "menu.system.share_twitter.caption" = "Tweet about it!";
//"menu.system.share_generic.caption" = "Invite a friend"; //"menu.system.share_generic.caption" = "Invite a friend";
"menu.system.quit.title" = "Quit %@"; "menu.system.quit.title" = "Quit %@";
//"menu.system.quit.messages.confirm" = "The VPN, if enabled, will still run in the background. Do you want to quit?"; //"menu.system.quit.messages.confirm" = "The VPN, if enabled, will still run in the background. Do you want to quit?";