Improve bump script with positional arguments (#957)

Get rid of the messy `bump*.sh` scripts variants with a single one with
positional arguments (all optional):

- -v: the new version number (default: current)
- -b: the new build number (default: current + 1)
- -s: the initial build for the CHANGELOG diff (default: latest tag)
- -na: do not update the API (default: do update it)
- -nl: do not update the CHANGELOG (default: present editor)
- -d: dry run

Fixes #948

ci/bump-no-log.sh

@@ -1,5 +0,0 @@
-#!/bin/sh
-if [ ! -z $1 ]; then
-    BUILD="build:$1"
-fi
-bundle exec fastlane bump $BUILD only:true

ci/bump-since.sh

@@ -1,5 +0,0 @@
-#!/bin/sh
-if [ ! -z $1 ]; then
-    SINCE="since:$1"
-fi
-bundle exec fastlane bump $SINCE

ci/bump-version.sh

@@ -1,10 +0,0 @@
-#!/bin/sh
-if [ -z $1 ]; then
-    echo "Version number required"
-    exit 1
-fi
-if [ ! -z $2 ]; then
-    BUILD="build:$2"
-fi
-VERSION="version:$1"
-bundle exec fastlane bump $VERSION $BUILD

ci/bump.sh

@@ -1,5 +1,67 @@
-#!/bin/sh
+#!/bin/bash
-if [ ! -z $1 ]; then
+# https://stackoverflow.com/questions/192249/how-do-i-parse-command-line-arguments-in-bash
-    BUILD="build:$1"
+
+POSITIONAL_ARGS=()
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    -v)
+      OPT_VERSION="version:$2"
+      shift # past argument
+      shift # past value
+      ;;
+    -b)
+      OPT_BUILD="build:$2"
+      shift # past argument
+      shift # past value
+      ;;
+    -s)
+      OPT_SINCE="since:$2"
+      shift # past argument
+      shift # past value
+      ;;
+    -na)
+      OPT_NO_API=1
+      shift # past argument
+      ;;
+    -nl)
+      OPT_NO_LOG="no_log:true"
+      shift # past argument
+      ;;
+    -d)
+      OPT_DRY_RUN=1
+      shift # past argument
+      ;;
+    -*|--*)
+      echo "Unknown option $1"
+      exit 1
+      ;;
+    *)
+      POSITIONAL_ARGS+=("$1") # save positional arg
+      shift # past argument
+      ;;
+  esac
+done
+
+set -- "${POSITIONAL_ARGS[@]}" # restore positional parameters
+
+CMD_API=$(dirname "$0")/update-bundled-api.sh
+CMD_FASTLANE="bundle exec fastlane bump $OPT_VERSION $OPT_BUILD $OPT_SINCE $OPT_NO_LOG"
+
+if [[ -n $OPT_DRY_RUN ]]; then
+    echo "VERSION = $OPT_VERSION"
+    echo "BUILD   = $OPT_BUILD"
+    echo "SINCE   = $OPT_SINCE"
+    echo "NO_API  = $OPT_NO_API"
+    echo "NO_LOG  = $OPT_NO_LOG"
+    if [[ -z $OPT_NO_API ]]; then
+        echo "$CMD_API"
+    fi
+    echo "$CMD_FASTLANE"
+    exit 0
 fi
-bundle exec fastlane bump $BUILD
+
+if [[ -z $OPT_NO_API ]]; then
+    eval "$CMD_API"
+fi
+eval "$CMD_FASTLANE"

ci/update-bundled-api.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-DESTINATION="Passepartout/Library/Sources/APILibrary/API"
+DESTINATION="Passepartout/Library/Sources/CommonAPI/API"
 API_VERSION="v5"
 
 mkdir tmp

fastlane/Fastfile

@@ -18,13 +18,14 @@ fastlane_require "fileutils"
 Dotenv.load ".env.secret"
 
 setup_ci if ENV["CI"]
+api = "Passepartout/Library/Sources/CommonAPI/API"
 logname = "CHANGELOG.txt"
 build_path = "build"
 derived_data_path = "build/derived_data"
 
 desc "Bump version"
 lane :bump do |options|
-    unless options[:only]
+    unless options[:no_log]
         if options[:since]
             between = [options[:since], "HEAD"]
         else
@@ -55,7 +56,7 @@ lane :bump do |options|
     end
     commit_version_bump(
         message: "Bump version",
-        include: [logname]
+        include: [api, logname]
     )
     add_git_tag(
         includes_lane: false,