Move favorites toggle above servers list on iOS (#769)

Improve access to the most used filter.

Passepartout/Library/Sources/AppUI/Views/Provider/VPNFiltersView+Model.swift

@@ -54,11 +54,26 @@ extension VPNFiltersView {
 
         let onlyShowsFavoritesDidChange = PassthroughSubject<Bool, Never>()
 
+        private var subscriptions: Set<AnyCancellable>
+
         init() {
             options = VPNFilterOptions()
             categories = []
             countries = []
             presets = []
+            subscriptions = []
+
+            $filters
+                .sink { [weak self] in
+                    self?.filtersDidChange.send($0)
+                }
+                .store(in: &subscriptions)
+
+            $onlyShowsFavorites
+                .sink { [weak self] in
+                    self?.onlyShowsFavoritesDidChange.send($0)
+                }
+                .store(in: &subscriptions)
         }
 
         func load(options: VPNFilterOptions, initialFilters: VPNFilters?) {

Passepartout/Library/Sources/AppUI/Views/Provider/VPNFiltersView.swift

@@ -41,7 +41,6 @@ struct VPNFiltersView: View {
                 countryPicker
                 presetPicker
 #if os(iOS)
-                favoritesToggle
                 clearFiltersButton
                     .frame(maxWidth: .infinity, alignment: .center)
 #else
@@ -56,12 +55,6 @@ struct VPNFiltersView: View {
         .onChange(of: model.filters.categoryName) { _ in
             model.filters.countryCode = nil
         }
-        .onChange(of: model.filters) {
-            model.filtersDidChange.send($0)
-        }
-        .onChange(of: model.onlyShowsFavorites) {
-            model.onlyShowsFavoritesDidChange.send($0)
-        }
     }
 }
 
@@ -106,7 +99,6 @@ private extension VPNFiltersView {
     var clearFiltersButton: some View {
         Button(Strings.Providers.clearFilters, role: .destructive) {
             model.filters = VPNFilters()
-            model.onlyShowsFavorites = false
         }
     }
 }

Passepartout/Library/Sources/AppUI/Views/Provider/VPNProviderServerView.swift

@@ -104,6 +104,7 @@ extension VPNProviderServerView {
 
         let vpnManager: VPNProviderManager<Configuration>
 
+        // BEWARE: not observed! use .onReceive() + @State
         let filtersViewModel: VPNFiltersView.Model
 
         let apis: [APIMapper]

Passepartout/Library/Sources/AppUI/Views/Provider/iOS/VPNProviderServerView+iOS.swift

@@ -109,14 +109,8 @@ extension VPNProviderServerView {
 
         var body: some View {
             debugChanges()
-            return ZStack {
+            return listView
-                if isFiltering || !servers.isEmpty {
+                .themeAnimation(on: isFiltering, category: .providers)
-                    listView
-                } else {
-                    emptyView
-                }
-            }
-            .themeAnimation(on: isFiltering, category: .providers)
         }
     }
 }
@@ -125,11 +119,18 @@ private extension VPNProviderServerView.ServersSubview {
     var listView: some View {
         List {
             Section {
-                if isFiltering {
+                Toggle(Strings.Providers.onlyFavorites, isOn: $filtersViewModel.onlyShowsFavorites)
-                    ProgressView()
+            }
-                        .id(UUID())
+            Section {
+                if isFiltering || !servers.isEmpty {
+                    if isFiltering {
+                        ProgressView()
+                            .id(UUID())
+                    } else {
+                        ForEach(countryCodes, id: \.self, content: countryView)
+                    }
                 } else {
-                    ForEach(countryCodes, id: \.self, content: countryView)
+                    emptyView
                 }
             } header: {
                 Text(filtersViewModel.filters.categoryName ?? Strings.Providers.Vpn.Category.any)
@@ -139,7 +140,6 @@ private extension VPNProviderServerView.ServersSubview {
 
     var emptyView: some View {
         Text(Strings.Providers.Vpn.noServers)
-            .themeEmptyMessage()
     }
 }