From 346aaec441f5ab010735b6f38bdda9a6aca5df23 Mon Sep 17 00:00:00 2001
From: Davide <keeshux@gmail.com>
Date: Tue, 5 Nov 2024 13:27:05 +0100
Subject: [PATCH] Reuse PurchaseButtonModifier in restricted areas (#815)

Fixes #687
---
 .../Views/Modules/OnDemandView.swift          | 27 +++---
 .../AppUIMain/Views/Modules/OpenVPNView.swift |  1 -
 .../Views/Profile/AppleTVSection.swift        | 17 ++--
 .../Provider/ProviderContentModifier.swift    | 17 ++--
 .../Modules/OpenVPNView+Credentials.swift     | 23 ++---
 .../Views/Paywall/PaywallModifier.swift       | 10 +-
 .../Views/Paywall/PaywallView.swift           |  0
 .../Views/UI/PurchaseButtonModifier.swift     | 91 +++++++++++++++++++
 8 files changed, 133 insertions(+), 53 deletions(-)
 rename Passepartout/Library/Sources/{AppUIMain => UILibrary}/Views/Paywall/PaywallModifier.swift (91%)
 rename Passepartout/Library/Sources/{AppUIMain => UILibrary}/Views/Paywall/PaywallView.swift (100%)
 create mode 100644 Passepartout/Library/Sources/UILibrary/Views/UI/PurchaseButtonModifier.swift

diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Modules/OnDemandView.swift b/Passepartout/Library/Sources/AppUIMain/Views/Modules/OnDemandView.swift
index 294b8371..a629f0fa 100644
--- a/Passepartout/Library/Sources/AppUIMain/Views/Modules/OnDemandView.swift
+++ b/Passepartout/Library/Sources/AppUIMain/Views/Modules/OnDemandView.swift
@@ -60,6 +60,12 @@ struct OnDemandView: View, ModuleDraftEditing {
         Group {
             enabledSection
             restrictedArea
+                .modifier(PurchaseButtonModifier(
+                    Strings.Modules.OnDemand.purchase,
+                    feature: .onDemand,
+                    showsIfRestricted: false,
+                    paywallReason: $paywallReason
+                ))
         }
         .moduleView(editor: editor, draft: draft.wrappedValue)
         .modifier(PaywallModifier(reason: $paywallReason))
@@ -81,22 +87,11 @@ private extension OnDemandView {
 
     @ViewBuilder
     var restrictedArea: some View {
-        switch iapManager.paywallReason(forFeature: .onDemand) {
-        case .purchase(let feature):
-            Button(Strings.Modules.OnDemand.purchase) {
-                paywallReason = .purchase(feature)
-            }
-
-        case .restricted:
-            EmptyView()
-
-        default:
-            if draft.wrappedValue.isEnabled {
-                policySection
-                if draft.wrappedValue.policy != .any {
-                    networkSection
-                    wifiSection
-                }
+        if draft.wrappedValue.isEnabled {
+            policySection
+            if draft.wrappedValue.policy != .any {
+                networkSection
+                wifiSection
             }
         }
     }
diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Modules/OpenVPNView.swift b/Passepartout/Library/Sources/AppUIMain/Views/Modules/OpenVPNView.swift
index 23f9ded9..d480f3db 100644
--- a/Passepartout/Library/Sources/AppUIMain/Views/Modules/OpenVPNView.swift
+++ b/Passepartout/Library/Sources/AppUIMain/Views/Modules/OpenVPNView.swift
@@ -234,7 +234,6 @@ private extension OpenVPNView {
             .navigationTitle(Strings.Modules.Openvpn.credentials)
             .themeForm()
             .themeAnimation(on: draft.wrappedValue.isInteractive, category: .modules)
-            .modifier(PaywallModifier(reason: $paywallReason))
         }
     }
 }
diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Profile/AppleTVSection.swift b/Passepartout/Library/Sources/AppUIMain/Views/Profile/AppleTVSection.swift
index 575555b6..1faa565d 100644
--- a/Passepartout/Library/Sources/AppUIMain/Views/Profile/AppleTVSection.swift
+++ b/Passepartout/Library/Sources/AppUIMain/Views/Profile/AppleTVSection.swift
@@ -53,17 +53,14 @@ private extension AppleTVSection {
         Toggle(Strings.Modules.General.Rows.appleTv(Strings.Unlocalized.appleTV), isOn: $profileEditor.isAvailableForTV)
     }
 
-    @ViewBuilder
     var purchaseButton: some View {
-        switch iapManager.paywallReason(forFeature: .appleTV) {
-        case .purchase(let feature):
-            Button(Strings.Modules.General.Rows.AppleTv.purchase) {
-                paywallReason = .purchase(feature)
-            }
-
-        default:
-            EmptyView()
-        }
+        EmptyView()
+            .modifier(PurchaseButtonModifier(
+                Strings.Modules.General.Rows.AppleTv.purchase,
+                feature: .appleTV,
+                showsIfRestricted: true,
+                paywallReason: $paywallReason
+            ))
     }
 
     var footer: String {
diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Provider/ProviderContentModifier.swift b/Passepartout/Library/Sources/AppUIMain/Views/Provider/ProviderContentModifier.swift
index 740bda01..56627af5 100644
--- a/Passepartout/Library/Sources/AppUIMain/Views/Provider/ProviderContentModifier.swift
+++ b/Passepartout/Library/Sources/AppUIMain/Views/Provider/ProviderContentModifier.swift
@@ -132,17 +132,14 @@ private extension ProviderContentModifier {
         )
     }
 
-    @ViewBuilder
     var purchaseButton: some View {
-        switch iapManager.paywallReason(forFeature: .providers) {
-        case .purchase(let feature):
-            Button(Strings.Providers.Picker.purchase) {
-                paywallReason = .purchase(feature)
-            }
-
-        default:
-            EmptyView()
-        }
+        EmptyView()
+            .modifier(PurchaseButtonModifier(
+                Strings.Providers.Picker.purchase,
+                feature: .providers,
+                showsIfRestricted: true,
+                paywallReason: $paywallReason
+            ))
     }
 
     func refreshButton<Label>(label: () -> Label) -> some View where Label: View {
diff --git a/Passepartout/Library/Sources/UILibrary/Views/Modules/OpenVPNView+Credentials.swift b/Passepartout/Library/Sources/UILibrary/Views/Modules/OpenVPNView+Credentials.swift
index e7a1dc8b..07e776c6 100644
--- a/Passepartout/Library/Sources/UILibrary/Views/Modules/OpenVPNView+Credentials.swift
+++ b/Passepartout/Library/Sources/UILibrary/Views/Modules/OpenVPNView+Credentials.swift
@@ -74,9 +74,17 @@ public struct OpenVPNCredentialsView: View {
     public var body: some View {
         Group {
             restrictedArea
+                .modifier(PurchaseButtonModifier(
+                    Strings.Modules.Openvpn.Credentials.Interactive.purchase,
+                    feature: .interactiveLogin,
+                    showsIfRestricted: false,
+                    paywallReason: $paywallReason
+                ))
+
             inputSection
         }
         .themeManualInput()
+        .modifier(PaywallModifier(reason: $paywallReason))
         .onLoad {
             builder = credentials?.builder() ?? OpenVPN.Credentials.Builder()
             builder.otp = nil
@@ -114,19 +122,8 @@ private extension OpenVPNCredentialsView {
 
     @ViewBuilder
     var restrictedArea: some View {
-        switch iapManager.paywallReason(forFeature: .interactiveLogin) {
-        case .purchase(let feature):
-            Button(Strings.Modules.Openvpn.Credentials.Interactive.purchase) {
-                paywallReason = .purchase(feature)
-            }
-
-        case .restricted:
-            EmptyView()
-
-        default:
-            if !isAuthenticating {
-                interactiveSection
-            }
+        if !isAuthenticating {
+            interactiveSection
         }
     }
 
diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Paywall/PaywallModifier.swift b/Passepartout/Library/Sources/UILibrary/Views/Paywall/PaywallModifier.swift
similarity index 91%
rename from Passepartout/Library/Sources/AppUIMain/Views/Paywall/PaywallModifier.swift
rename to Passepartout/Library/Sources/UILibrary/Views/Paywall/PaywallModifier.swift
index 842726fe..777ed639 100644
--- a/Passepartout/Library/Sources/AppUIMain/Views/Paywall/PaywallModifier.swift
+++ b/Passepartout/Library/Sources/UILibrary/Views/Paywall/PaywallModifier.swift
@@ -26,10 +26,10 @@
 import CommonLibrary
 import SwiftUI
 
-struct PaywallModifier: ViewModifier {
+public struct PaywallModifier: ViewModifier {
 
     @Binding
-    var reason: PaywallReason?
+    private var reason: PaywallReason?
 
     @State
     private var isPresentingRestricted = false
@@ -37,7 +37,11 @@ struct PaywallModifier: ViewModifier {
     @State
     private var paywallFeature: AppFeature?
 
-    func body(content: Content) -> some View {
+    public init(reason: Binding<PaywallReason?>) {
+        _reason = reason
+    }
+
+    public func body(content: Content) -> some View {
         content
             .alert(
                 Strings.Alerts.Iap.Restricted.title,
diff --git a/Passepartout/Library/Sources/AppUIMain/Views/Paywall/PaywallView.swift b/Passepartout/Library/Sources/UILibrary/Views/Paywall/PaywallView.swift
similarity index 100%
rename from Passepartout/Library/Sources/AppUIMain/Views/Paywall/PaywallView.swift
rename to Passepartout/Library/Sources/UILibrary/Views/Paywall/PaywallView.swift
diff --git a/Passepartout/Library/Sources/UILibrary/Views/UI/PurchaseButtonModifier.swift b/Passepartout/Library/Sources/UILibrary/Views/UI/PurchaseButtonModifier.swift
new file mode 100644
index 00000000..abaed3c9
--- /dev/null
+++ b/Passepartout/Library/Sources/UILibrary/Views/UI/PurchaseButtonModifier.swift
@@ -0,0 +1,91 @@
+//
+//  PurchaseButtonModifier.swift
+//  Passepartout
+//
+//  Created by Davide De Rosa on 11/5/24.
+//  Copyright (c) 2024 Davide De Rosa. All rights reserved.
+//
+//  https://github.com/passepartoutvpn
+//
+//  This file is part of Passepartout.
+//
+//  Passepartout is free software: you can redistribute it and/or modify
+//  it under the terms of the GNU General Public License as published by
+//  the Free Software Foundation, either version 3 of the License, or
+//  (at your option) any later version.
+//
+//  Passepartout is distributed in the hope that it will be useful,
+//  but WITHOUT ANY WARRANTY; without even the implied warranty of
+//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//  GNU General Public License for more details.
+//
+//  You should have received a copy of the GNU General Public License
+//  along with Passepartout.  If not, see <http://www.gnu.org/licenses/>.
+//
+
+import CommonLibrary
+import SwiftUI
+
+public struct PurchaseButtonModifier: ViewModifier {
+
+    @EnvironmentObject
+    private var iapManager: IAPManager
+
+    private let title: String
+
+    private let label: String?
+
+    private let feature: AppFeature
+
+    private let showsIfRestricted: Bool
+
+    @Binding
+    private var paywallReason: PaywallReason?
+
+    public init(
+        _ title: String,
+        label: String? = nil,
+        feature: AppFeature,
+        showsIfRestricted: Bool,
+        paywallReason: Binding<PaywallReason?>
+    ) {
+        self.title = title
+        self.label = label
+        self.feature = feature
+        self.showsIfRestricted = showsIfRestricted
+        _paywallReason = paywallReason
+    }
+
+    public func body(content: Content) -> some View {
+        switch iapManager.paywallReason(forFeature: feature) {
+        case .purchase:
+            purchaseView
+
+        case .restricted:
+            if showsIfRestricted {
+                content
+            }
+
+        default:
+            content
+        }
+    }
+}
+
+private extension PurchaseButtonModifier {
+    var purchaseView: some View {
+        HStack {
+            if let label {
+                Text(label)
+                Spacer()
+            }
+            purchaseButton
+        }
+    }
+
+    var purchaseButton: some View {
+        Button(title) {
+            paywallReason = .purchase(feature)
+        }
+    }
+}