Fix non-optional MTU in network settings

May break parsing of ConnectionService.

Fixes #163
This commit is contained in:
Davide De Rosa 2021-01-02 11:00:43 +01:00
parent f9f692416a
commit 5a1b86e9d5
3 changed files with 11 additions and 4 deletions

View File

@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## Unreleased
### Fixed
- Losing profiles on upgrade. [#163](https://github.com/passepartoutvpn/passepartout-ios/issues/163)
- Twitch link does not work when Twitch app not installed. [#162](https://github.com/passepartoutvpn/passepartout-ios/issues/162)
## 1.13.0 (2021-01-01) ## 1.13.0 (2021-01-01)
### Added ### Added

View File

@ -144,7 +144,7 @@ class NetworkSettingsViewController: UITableViewController {
updateGateway(networkChoices.gateway) updateGateway(networkChoices.gateway)
updateDNS(networkChoices.dns) updateDNS(networkChoices.dns)
updateProxy(networkChoices.proxy) updateProxy(networkChoices.proxy)
updateMTU(networkChoices.mtu) updateMTU(networkChoices.mtu ?? ProfileNetworkChoices.defaultChoice)
} }
override func viewWillAppear(_ animated: Bool) { override func viewWillAppear(_ animated: Bool) {
@ -218,7 +218,7 @@ class NetworkSettingsViewController: UITableViewController {
private func updateMTU(_ choice: NetworkChoice) { private func updateMTU(_ choice: NetworkChoice) {
networkChoices.mtu = choice networkChoices.mtu = choice
switch networkChoices.mtu { switch networkChoices.mtu ?? ProfileNetworkChoices.defaultChoice {
case .client: case .client:
if let settings = clientNetworkSettings { if let settings = clientNetworkSettings {
networkSettings.copyMTU(from: settings) networkSettings.copyMTU(from: settings)
@ -392,7 +392,7 @@ extension NetworkSettingsViewController {
case .mtu: case .mtu:
let cell = Cells.setting.dequeue(from: tableView, for: indexPath) let cell = Cells.setting.dequeue(from: tableView, for: indexPath)
cell.leftText = L10n.Core.NetworkSettings.Mtu.title cell.leftText = L10n.Core.NetworkSettings.Mtu.title
cell.rightText = networkChoices.mtu.description cell.rightText = (networkChoices.mtu ?? ProfileNetworkChoices.defaultChoice).description
return cell return cell
case .gatewayIPv4: case .gatewayIPv4:

@ -1 +1 @@
Subproject commit 1cacb2612d9577a19a1406b89e21a52185695932 Subproject commit 97092dbf0ff403a8e117a7976af7de93fe4f2136