passepartoutvpn/passepartout-apple
1
0
Fork 0
mirror of https://github.com/passepartoutvpn/passepartout-apple.git synced 2025-01-30 20:42:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix table pre-scrolling to selection

Browse Source 
iOS is broken, must wrap in a DispatchQueue.main.async
This commit is contained in:
Davide De Rosa 2019-04-05 12:46:50 +02:00
parent 8a7b0389ed
commit a4a82fbd03
6 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Passepartout-iOS/Scenes/EndpointViewController.swift
View File

@ -120,7 +120,7 @@ class EndpointViewController: UIViewController, TableModelHost {
tableView.reloadData() tableView.reloadData()
if let ip = selectedIndexPath { if let ip = selectedIndexPath {
tableView.scrollToRow(at: ip, at: .middle, animated: false) tableView.scrollToRowAsync(at: ip)
} }
} }

2
Passepartout-iOS/Scenes/Organizer/OrganizerViewController.swift
View File

@ -100,7 +100,7 @@ class OrganizerViewController: UITableViewController, TableModelHost {
tableView.reloadData() tableView.reloadData()
if let ip = selectedIndexPath { if let ip = selectedIndexPath {
tableView.scrollToRow(at: ip, at: .middle, animated: false) tableView.scrollToRowAsync(at: ip)
} }
service.delegate = self service.delegate = self

2
Passepartout-iOS/Scenes/ProviderPoolViewController.swift
View File

@ -53,7 +53,7 @@ class ProviderPoolViewController: UIViewController {
title = L10n.Service.Cells.Provider.Pool.caption title = L10n.Service.Cells.Provider.Pool.caption
tableView.reloadData() tableView.reloadData()
if let ip = selectedIndexPath { if let ip = selectedIndexPath {
tableView.scrollToRow(at: ip, at: .middle, animated: false) tableView.scrollToRowAsync(at: ip)
} }
} }
} }

2
Passepartout-iOS/Scenes/ProviderPresetViewController.swift
View File

@ -57,7 +57,7 @@ class ProviderPresetViewController: UIViewController {
title = L10n.Service.Cells.Provider.Preset.caption title = L10n.Service.Cells.Provider.Preset.caption
tableView.reloadData() tableView.reloadData()
if let ip = selectedIndexPath { if let ip = selectedIndexPath {
tableView.scrollToRow(at: ip, at: .middle, animated: false) tableView.scrollToRowAsync(at: ip)
} }
} }

4
Passepartout/Sources/AppConstants.swift
View File

@ -258,6 +258,10 @@ public class AppConstants {
"Circle Icons", "Circle Icons",
"The logo is taken from the awesome Circle Icons set by Nick Roach." "The logo is taken from the awesome Circle Icons set by Nick Roach."
), ),
Notice(
"Country flags",
"https://github.com/lipis/flag-icon-css"
),
Notice( Notice(
"OpenVPN", "OpenVPN",
"© 2002-2018 OpenVPN Inc. - OpenVPN is a registered trademark of OpenVPN Inc." "© 2002-2018 OpenVPN Inc. - OpenVPN is a registered trademark of OpenVPN Inc."

8
Passepartout/Sources/Utils.swift
View File

@ -223,3 +223,11 @@ public extension Array where Element: CustomStringConvertible {
return sorted { $0.description.lowercased() < $1.description.lowercased() } return sorted { $0.description.lowercased() < $1.description.lowercased() }
} }
} }
public extension UITableView {
func scrollToRowAsync(at indexPath: IndexPath) {
DispatchQueue.main.async { [weak self] in
self?.scrollToRow(at: indexPath, at: .middle, animated: false)
}
}
}