Some fixes
- Import remote profiles off the main thread - Drop meaningless Published - Add a FIXME to move Profile build logic to library
This commit is contained in:
parent
8cdd20dfb4
commit
aeaf0a6eed
|
@ -254,7 +254,6 @@ extension ProfileManager {
|
||||||
remoteRepository?
|
remoteRepository?
|
||||||
.profilesPublisher
|
.profilesPublisher
|
||||||
.dropFirst()
|
.dropFirst()
|
||||||
.receive(on: DispatchQueue.main)
|
|
||||||
.sink { [weak self] in
|
.sink { [weak self] in
|
||||||
self?.importRemoteProfiles($0)
|
self?.importRemoteProfiles($0)
|
||||||
}
|
}
|
||||||
|
|
|
@ -33,7 +33,6 @@ final class InteractiveManager: ObservableObject {
|
||||||
@Published
|
@Published
|
||||||
var isPresented = false
|
var isPresented = false
|
||||||
|
|
||||||
@Published
|
|
||||||
private(set) var editor = ProfileEditor()
|
private(set) var editor = ProfileEditor()
|
||||||
|
|
||||||
private var onComplete: CompletionBlock?
|
private var onComplete: CompletionBlock?
|
||||||
|
|
|
@ -98,6 +98,7 @@ private extension EditableProfile {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// FIXME: ###, move to library
|
||||||
func checkConstraints() throws {
|
func checkConstraints() throws {
|
||||||
if activeConnectionModule == nil,
|
if activeConnectionModule == nil,
|
||||||
let ipModule = modules.first(where: { activeModulesIds.contains($0.id) && $0 is IPModule.Builder }) {
|
let ipModule = modules.first(where: { activeModulesIds.contains($0.id) && $0 is IPModule.Builder }) {
|
||||||
|
|
Loading…
Reference in New Issue