From f60265556831184e70789cd41296568d29eb2aa7 Mon Sep 17 00:00:00 2001 From: Davide De Rosa Date: Tue, 1 Oct 2024 15:45:25 +0200 Subject: [PATCH] Link TODOs to issues --- .../Sources/AppDataProfiles/CDProfileRepository.swift | 1 + Passepartout/Library/Sources/AppUI/AppUI.swift | 1 + .../Library/Sources/AppUI/Business/ProfileEditor.swift | 2 +- Passepartout/Library/Sources/AppUI/Domain/Issue+App.swift | 2 ++ Passepartout/Library/Sources/AppUI/Domain/Issue.swift | 2 +- .../Library/Sources/AppUI/Views/About/DonateView.swift | 2 +- .../Sources/AppUI/Views/About/iOS/AboutView+iOS.swift | 2 +- .../Sources/AppUI/Views/About/macOS/AboutView+macOS.swift | 2 +- .../Sources/AppUI/Views/Diagnostics/DebugLogView.swift | 6 +++++- .../Library/Sources/AppUI/Views/Modules/OpenVPNView.swift | 2 +- .../Library/Sources/AppUI/Views/Modules/WireGuardView.swift | 2 +- .../Library/Sources/AppUI/Views/Paywall/PaywallView.swift | 4 ++-- .../Library/Sources/AppUI/Views/Theme/Theme+UI.swift | 2 +- .../Sources/AppUI/Views/UI/InstalledProfileView.swift | 2 +- .../Library/Sources/AppUI/Views/UI/ProfileInfoButton.swift | 2 +- .../Library/Sources/CommonLibrary/CommonLibrary.swift | 1 + .../CommonLibrary/Domain/BundleConfiguration+Main.swift | 1 + .../Sources/UtilsLibrary/Views/LongContentView.swift | 2 +- 18 files changed, 24 insertions(+), 14 deletions(-) diff --git a/Passepartout/Library/Sources/AppDataProfiles/CDProfileRepository.swift b/Passepartout/Library/Sources/AppDataProfiles/CDProfileRepository.swift index ee0d2272..b23dbe86 100644 --- a/Passepartout/Library/Sources/AppDataProfiles/CDProfileRepository.swift +++ b/Passepartout/Library/Sources/AppDataProfiles/CDProfileRepository.swift @@ -30,6 +30,7 @@ import PassepartoutKit import UtilsLibrary extension AppData { + // TODO: #656, make non-static public static func cdProfileRepository( registry: Registry, coder: ProfileCoder, diff --git a/Passepartout/Library/Sources/AppUI/AppUI.swift b/Passepartout/Library/Sources/AppUI/AppUI.swift index e0e51483..f2742aeb 100644 --- a/Passepartout/Library/Sources/AppUI/AppUI.swift +++ b/Passepartout/Library/Sources/AppUI/AppUI.swift @@ -26,6 +26,7 @@ import Foundation import PassepartoutKit +// TODO: #656, make non-static public struct AppUI { private init() { } diff --git a/Passepartout/Library/Sources/AppUI/Business/ProfileEditor.swift b/Passepartout/Library/Sources/AppUI/Business/ProfileEditor.swift index 36f4696b..4cf78d6c 100644 --- a/Passepartout/Library/Sources/AppUI/Business/ProfileEditor.swift +++ b/Passepartout/Library/Sources/AppUI/Business/ProfileEditor.swift @@ -94,7 +94,7 @@ extension ProfileEditor { ModuleType .allCases .filter { - // TODO: hide manual OpenVPN/WireGuard until editable + // TODO: #657, hide manual OpenVPN/WireGuard until editable $0 != .openVPN && $0 != .wireGuard } .filter { diff --git a/Passepartout/Library/Sources/AppUI/Domain/Issue+App.swift b/Passepartout/Library/Sources/AppUI/Domain/Issue+App.swift index e0f185e0..0fc8f4f5 100644 --- a/Passepartout/Library/Sources/AppUI/Domain/Issue+App.swift +++ b/Passepartout/Library/Sources/AppUI/Domain/Issue+App.swift @@ -28,6 +28,8 @@ import Foundation import PassepartoutKit extension Issue { + + // TODO: #656, make non-static static func with(versionString: String, purchasedProducts: Set, tunnel: Tunnel) async -> Self { let appLog = CommonLibrary.currentLog(parameters: Constants.shared.log) .joined(separator: "\n") diff --git a/Passepartout/Library/Sources/AppUI/Domain/Issue.swift b/Passepartout/Library/Sources/AppUI/Domain/Issue.swift index a6cd2daf..28954528 100644 --- a/Passepartout/Library/Sources/AppUI/Domain/Issue.swift +++ b/Passepartout/Library/Sources/AppUI/Domain/Issue.swift @@ -81,7 +81,7 @@ struct Issue: Identifiable { .replacingOccurrences(of: "$appLine", with: appLine ?? "unknown") .replacingOccurrences(of: "$osLine", with: osLine) .replacingOccurrences(of: "$deviceLine", with: deviceLine ?? "unknown") - // TODO: replace with provider later + // TODO: #614, replace with provider later .replacingOccurrences(of: "$providerName", with: "none") .replacingOccurrences(of: "$providerLastUpdate", with: "unknown") .replacingOccurrences(of: "$purchasedProducts", with: purchasedProducts.map(\.rawValue).description) diff --git a/Passepartout/Library/Sources/AppUI/Views/About/DonateView.swift b/Passepartout/Library/Sources/AppUI/Views/About/DonateView.swift index 46a604b0..b8b92502 100644 --- a/Passepartout/Library/Sources/AppUI/Views/About/DonateView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/About/DonateView.swift @@ -25,7 +25,7 @@ import SwiftUI -// TODO: donations +// TODO: #585, donations struct DonateView: View { var body: some View { diff --git a/Passepartout/Library/Sources/AppUI/Views/About/iOS/AboutView+iOS.swift b/Passepartout/Library/Sources/AppUI/Views/About/iOS/AboutView+iOS.swift index 3b0e119c..bc7b08f6 100644 --- a/Passepartout/Library/Sources/AppUI/Views/About/iOS/AboutView+iOS.swift +++ b/Passepartout/Library/Sources/AppUI/Views/About/iOS/AboutView+iOS.swift @@ -32,7 +32,7 @@ extension AboutView { var listView: some View { List { Section { - // TODO: donations + // TODO: #585, donations // donateLink linksLink creditsLink diff --git a/Passepartout/Library/Sources/AppUI/Views/About/macOS/AboutView+macOS.swift b/Passepartout/Library/Sources/AppUI/Views/About/macOS/AboutView+macOS.swift index 8aa237bc..adcc83fd 100644 --- a/Passepartout/Library/Sources/AppUI/Views/About/macOS/AboutView+macOS.swift +++ b/Passepartout/Library/Sources/AppUI/Views/About/macOS/AboutView+macOS.swift @@ -32,7 +32,7 @@ extension AboutView { var listView: some View { List(selection: $navigationRoute) { Section { - // TODO: donations + // TODO: #585, donations // donateLink linksLink creditsLink diff --git a/Passepartout/Library/Sources/AppUI/Views/Diagnostics/DebugLogView.swift b/Passepartout/Library/Sources/AppUI/Views/Diagnostics/DebugLogView.swift index 88c04622..d222ed1e 100644 --- a/Passepartout/Library/Sources/AppUI/Views/Diagnostics/DebugLogView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/Diagnostics/DebugLogView.swift @@ -29,18 +29,22 @@ import SwiftUI import UtilsLibrary extension DebugLogView { + + // TODO: #656, make non-static static func withApp(parameters: Constants.Log) -> DebugLogView { DebugLogView { CommonLibrary.currentLog(parameters: parameters) } } + // TODO: #656, make non-static static func withTunnel(_ tunnel: Tunnel, parameters: Constants.Log) -> DebugLogView { DebugLogView { await tunnel.currentLog(parameters: parameters) } } + // TODO: #656, make non-static static func withURL(_ url: URL) -> DebugLogView { DebugLogView { do { @@ -99,7 +103,7 @@ private extension DebugLogView { .disabled(currentLines.isEmpty) } - // TODO: share as temporary URL (could enable email) + // TODO: #658, share as temporary URL (could enable email) // var shareButton: some View { // ShareLink(item: content) // } diff --git a/Passepartout/Library/Sources/AppUI/Views/Modules/OpenVPNView.swift b/Passepartout/Library/Sources/AppUI/Views/Modules/OpenVPNView.swift index ef7c681f..fc641ac6 100644 --- a/Passepartout/Library/Sources/AppUI/Views/Modules/OpenVPNView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/Modules/OpenVPNView.swift @@ -321,7 +321,7 @@ private extension OpenVPNView { private extension OpenVPNView { func importConfiguration(from url: URL) { - // TODO: import draft from external URL + // TODO: #657, import draft from external URL } } diff --git a/Passepartout/Library/Sources/AppUI/Views/Modules/WireGuardView.swift b/Passepartout/Library/Sources/AppUI/Views/Modules/WireGuardView.swift index fdb9026f..9b2bc545 100644 --- a/Passepartout/Library/Sources/AppUI/Views/Modules/WireGuardView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/Modules/WireGuardView.swift @@ -137,7 +137,7 @@ private extension WireGuardView { private extension WireGuardView { func importConfiguration(from url: URL) { - // TODO: import draft from external URL + // TODO: #657, import draft from external URL } } diff --git a/Passepartout/Library/Sources/AppUI/Views/Paywall/PaywallView.swift b/Passepartout/Library/Sources/AppUI/Views/Paywall/PaywallView.swift index e798ea5f..96f1dcc9 100644 --- a/Passepartout/Library/Sources/AppUI/Views/Paywall/PaywallView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/Paywall/PaywallView.swift @@ -35,11 +35,11 @@ struct PaywallView: View { let feature: AppFeature - // TODO: #424, implement payments + // TODO: #585, implement payments var body: some View { Text(String(describing: feature)) .toolbar(content: toolbarContent) - .navigationTitle("Purchase") + .navigationTitle(Strings.Global.purchase) } } diff --git a/Passepartout/Library/Sources/AppUI/Views/Theme/Theme+UI.swift b/Passepartout/Library/Sources/AppUI/Views/Theme/Theme+UI.swift index c253bcd7..6475fe6d 100644 --- a/Passepartout/Library/Sources/AppUI/Views/Theme/Theme+UI.swift +++ b/Passepartout/Library/Sources/AppUI/Views/Theme/Theme+UI.swift @@ -348,7 +348,7 @@ struct ThemeCopiableText: View { } label: { ThemeImage(.copy) } - // TODO: #584 menu, necessary to avoid cell selection + // TODO: #584, necessary to avoid cell selection .buttonStyle(.borderless) } } diff --git a/Passepartout/Library/Sources/AppUI/Views/UI/InstalledProfileView.swift b/Passepartout/Library/Sources/AppUI/Views/UI/InstalledProfileView.swift index 2388e9e7..da71ea39 100644 --- a/Passepartout/Library/Sources/AppUI/Views/UI/InstalledProfileView.swift +++ b/Passepartout/Library/Sources/AppUI/Views/UI/InstalledProfileView.swift @@ -123,7 +123,7 @@ private extension InstalledProfileView { ThemeImage(.tunnelToggle) .scaleEffect(1.5, anchor: .trailing) } - // TODO: #584 menu, necessary to avoid cell selection + // TODO: #584, necessary to avoid cell selection .buttonStyle(.plain) .opacity(installedOpacity) } diff --git a/Passepartout/Library/Sources/AppUI/Views/UI/ProfileInfoButton.swift b/Passepartout/Library/Sources/AppUI/Views/UI/ProfileInfoButton.swift index 4d8b4aef..d2e90474 100644 --- a/Passepartout/Library/Sources/AppUI/Views/UI/ProfileInfoButton.swift +++ b/Passepartout/Library/Sources/AppUI/Views/UI/ProfileInfoButton.swift @@ -37,7 +37,7 @@ struct ProfileInfoButton: View { } label: { ThemeImage(.info) } - // TODO: #584 menu, necessary to avoid cell selection + // TODO: #584, necessary to avoid cell selection .buttonStyle(.borderless) } } diff --git a/Passepartout/Library/Sources/CommonLibrary/CommonLibrary.swift b/Passepartout/Library/Sources/CommonLibrary/CommonLibrary.swift index 716572c2..e70a7845 100644 --- a/Passepartout/Library/Sources/CommonLibrary/CommonLibrary.swift +++ b/Passepartout/Library/Sources/CommonLibrary/CommonLibrary.swift @@ -26,6 +26,7 @@ import Foundation import PassepartoutKit +// TODO: #656, make non-static public struct CommonLibrary { private init() { } diff --git a/Passepartout/Library/Sources/CommonLibrary/Domain/BundleConfiguration+Main.swift b/Passepartout/Library/Sources/CommonLibrary/Domain/BundleConfiguration+Main.swift index 3307beff..f7fcb427 100644 --- a/Passepartout/Library/Sources/CommonLibrary/Domain/BundleConfiguration+Main.swift +++ b/Passepartout/Library/Sources/CommonLibrary/Domain/BundleConfiguration+Main.swift @@ -26,6 +26,7 @@ import Foundation import PassepartoutKit +// TODO: #656, make non-static extension BundleConfiguration { public enum BundleKey: String { case appStoreId diff --git a/Passepartout/Library/Sources/UtilsLibrary/Views/LongContentView.swift b/Passepartout/Library/Sources/UtilsLibrary/Views/LongContentView.swift index 38ef4171..00d24696 100644 --- a/Passepartout/Library/Sources/UtilsLibrary/Views/LongContentView.swift +++ b/Passepartout/Library/Sources/UtilsLibrary/Views/LongContentView.swift @@ -41,7 +41,7 @@ public struct LongContentView: View { Image(systemName: copySystemImage ?? "doc.on.doc") } } - // TODO: layout, add padding an inset, let content extend beyond safe areas + // TODO: #659, add padding as inset, let content extend beyond safe areas } }