Commit Graph

313 Commits

Author SHA1 Message Date
Davide De Rosa 400cea0f7b Show EKU and random endpoint in configuration 2019-03-27 17:07:29 +01:00
Davide De Rosa 250c3399da Reuse enabled/disabled strings in configuration 2019-03-27 17:04:06 +01:00
Davide De Rosa 895b375741 Parse EKU validation from preset 2019-03-26 00:41:51 +01:00
Davide De Rosa ecf9fece0f Parse compression from infra preset 2019-03-26 00:41:51 +01:00
Davide De Rosa dc81356b31 Retry import after passphrase input
Isolate .ovpn parsing routines.

- AppDelegate (external URL)
- ImportedHosts

Only delete URL if error is not encryption passphrase.
2019-03-25 20:33:07 +01:00
Davide De Rosa 34fc10eef8 Split guidance and referral footers
Handle tap per footer.
2019-03-25 20:26:03 +01:00
Davide De Rosa 65b6cdccbf Parse server num and free bit 2019-03-25 20:07:46 +01:00
Davide De Rosa 838f097d65 Parse TLSWrap from infra preset "wrap" 2019-03-25 20:03:58 +01:00
Davide De Rosa e00a7f60ce Update TunnelKit for --remote-random 2019-03-25 20:03:58 +01:00
Davide De Rosa 7b814e4021 Add Mullvad account creation link 2019-03-22 19:57:57 +01:00
Davide De Rosa 54f7779c45 Add Mullvad provider 2019-03-22 19:29:55 +01:00
Davide De Rosa 2dd26ae72a Reword no framing to "Disabled" for consistency 2019-03-22 19:29:15 +01:00
Davide De Rosa 3b5207dc8f Better reconnect than disconnect 2019-03-22 19:25:12 +01:00
Davide De Rosa c45e741750 Disconnect on masking change
To ensure that the stale log is erased immediately.
2019-03-22 19:23:32 +01:00
Davide De Rosa fdc3869d29 Move baseVPNConfiguration to TransientStore
Simplifies configuration update.
2019-03-22 19:09:52 +01:00
Davide De Rosa c391663d11 Persist masking flag 2019-03-22 19:09:52 +01:00
Davide De Rosa e4c1ea4def Delete log on masking change
It may contain stale and either sensitive or irrelevant data.
2019-03-22 18:54:54 +01:00
Davide De Rosa 96f5210c7c Control debug masking via diagnostics
Be clear about NOT logging any sensitive data. In fact, the
variable name masksPrivateData is potentially misleading.
2019-03-22 18:54:54 +01:00
Davide De Rosa 9f6307dbc2 Make default VPN configuration mutable 2019-03-22 18:46:04 +01:00
Davide De Rosa dacd5653b4 Make localizedName a subordinate method
To reuse localizedCountryArea for sorting regardless of display.
2019-03-21 22:21:42 +01:00
Davide De Rosa 42f64db0b7 Localize pools consistently 2019-03-21 22:21:42 +01:00
Davide De Rosa 15f23dd448 Retain Pool.name internally but show .localizedName
Use name from API if available (XXX: not localized).

Make it private to avoid unintended use in app.
2019-03-21 22:21:42 +01:00
Davide De Rosa 3eb9c6ae98 Localize Pool via country code + area 2019-03-21 22:21:42 +01:00
Davide De Rosa 3bf340c74c Prepare before disconnection intent
manager is nil otherwise in connect/disconnect.

Doesn't apply to reinstall/reconnect.
2019-03-19 18:01:15 +01:00
Davide De Rosa af51911536 Replace Cancel with X to exit shortcuts
Misleading!
2019-03-19 18:01:15 +01:00
Davide De Rosa 63d74b6feb Reorganize shortcut sections 2019-03-19 18:01:15 +01:00
Davide De Rosa c0be33dacc Add descriptive footer to Siri section 2019-03-19 18:01:15 +01:00
Davide De Rosa 877dd4d990 Fix similar completionHandler bugs
See previous commit
2019-03-19 17:27:42 +01:00
Davide De Rosa 9a67918dc0 Fix disconnection handler not called when inactive
Fixes #42
2019-03-19 17:24:45 +01:00
Davide De Rosa 82aa8b5f79 Add LZO license 2019-03-19 15:23:45 +01:00
Davide De Rosa fbbd0b33f2 Reorganize compression section
- Show algorithm.
- Make framing readonly.

Easy way to prevent combination of LZO with new framing.
2019-03-19 15:23:45 +01:00
Davide De Rosa 15602f7dc9 Pick profile/location for connection intent
- Host: ConnectVPN intent
- Provider: requires Pool selection
2019-03-18 22:13:36 +01:00
Davide De Rosa 98160fdccb Split shortcuts into VPN and Trust 2019-03-18 21:00:07 +01:00
Davide De Rosa 7e11f7bf81 Reword Wi-Fi intents 2019-03-18 20:55:58 +01:00
Davide De Rosa 8f3d2f0b15 Add basic cells for any possible shortcut 2019-03-18 20:54:47 +01:00
Davide De Rosa 1c103c639d Add shortcuts view controller stub 2019-03-18 20:54:47 +01:00
Davide De Rosa 43b75a1029 Add completion handler to intent dispatcher 2019-03-18 17:18:57 +01:00
Davide De Rosa 554f5bcad6 Rename notification method to be UI-agnostic 2019-03-18 17:08:24 +01:00
Davide De Rosa c3e6e1ecd5 Move intents to Core target
Suppress responses for consistency.
2019-03-18 17:06:35 +01:00
Davide De Rosa 5237aa3916 Import Core framework into iOS target 2019-03-18 11:52:19 +01:00
Davide De Rosa f661008679 Make framework internal components public 2019-03-18 11:50:52 +01:00
Davide De Rosa cf499739f7 Export SwiftGen strings as public
Required as part of an external framework.
2019-03-18 11:19:24 +01:00
Davide De Rosa de944acabb Fall back to documents container
Convenient for test target.
2019-03-18 11:19:24 +01:00
Davide De Rosa d983362815 Use relative bundle to locate URL in framework 2019-03-18 11:19:24 +01:00
Davide De Rosa c7f522f55e Create Passepartout-Core framework target
Move all sources to this target, out of Passepartout-iOS.

FIXME: TrustedNetworks uses ServiceViewController.RowType
FIXME: make iOS target depend on Core.
2019-03-18 11:19:24 +01:00
Davide De Rosa 39fb191309 Log documents migration event
If anything was moved.
2019-03-11 10:17:45 +01:00
Davide De Rosa 9005bf6c19 Skip "Inbox" during migration
No permission.
2019-03-11 10:17:01 +01:00
Davide De Rosa 87249cb8ad Migrate documents to App Group 2019-03-11 10:16:33 +01:00
Davide De Rosa 8ede1ed3d4 Use App Group container for documents and caches 2019-03-11 10:05:54 +01:00
Davide De Rosa 29f34cd206 Report .inactiveProfile on nil GracefulVPN.vpn
Methods:

- reconnect
- reinstall
- disconnect
2019-03-11 09:55:25 +01:00
Davide De Rosa 439c9c0b0f Set profile directly in GracefulVPN
No need to pass through prepare(). Couple with setProfile() for
robustness.
2019-03-11 09:55:25 +01:00
Davide De Rosa 7a21338042 Update copyright 2019-03-09 11:44:44 +01:00
Davide De Rosa 2e4d2162ac Define custom intents
- Connect
- Disable
- (Un)Trust current network
- (Un)Trust cellular network
- Move to location
2019-03-09 11:23:47 +01:00
Davide De Rosa c0c8ed3fc9 Hide beta testing section 2019-03-08 11:01:21 +01:00
Davide De Rosa ce3781e3b5 Be more formal about ProfileKey parsing 2019-03-08 10:21:08 +01:00
Davide De Rosa 05daa8f77a Delete log file on start 2019-03-08 09:39:37 +01:00
Davide De Rosa b50cb4681b Fix stupid parsing of ProfileKey from String
Fixes #19
2019-03-08 00:01:52 +01:00
Davide De Rosa 5fb38652b0 Debug app log to file for troubleshooting 2019-03-07 22:53:29 +01:00
Davide De Rosa bc4841af8a Refine TunnelBear integration
- Mention in README
- Promo link
2019-03-07 22:04:09 +01:00
Davide De Rosa 9441a31fd1 Add button to test app termination
Might help reproducing #19
2019-03-06 17:46:06 +01:00
Davide De Rosa e4ef4a9dbc Rearrange lines to isolate throwing code 2019-03-06 17:10:37 +01:00
Davide De Rosa c5c670b086 Add TunnelBear provider 2019-03-05 23:02:22 +01:00
Davide De Rosa 0b7bd41636 Add provider referrals 2019-03-03 14:17:09 +01:00
Davide De Rosa 3ddfa87b58 Disconnect before switching active profile
Make sure that completionHandler is ALWAYS called, despite vpn
object being nil.
2019-03-03 13:04:27 +01:00
Davide De Rosa a9e16c5335 Show custom DNS addresses in configuration UI 2019-03-03 10:40:12 +01:00
Davide De Rosa 6d4c566e05 Fix renamed SwiftGen license file 2019-03-01 21:10:38 +01:00
Davide De Rosa f335440800 Shut down if server pushes a compression directive 2019-02-25 23:13:12 +01:00
Davide De Rosa 942aaecdc3 Refine profile description 2019-02-23 11:18:36 +01:00
Davide De Rosa 68b9cf0fdf Convert bundled API to a folder reference
Create intermediate directory for cached infrastructure.
2019-02-23 11:18:31 +01:00
Davide De Rosa 50157e0480 Reword again remove VPN configuration button
See 88099c416b
2019-02-06 10:25:40 +01:00
Davide De Rosa fedea91087 Add FAQ in About 2019-02-03 22:08:24 +01:00
Davide De Rosa 88099c416b Reword VPN configuration deletion 2019-01-17 09:56:14 +01:00
Davide De Rosa d0de93c60a Do not sort endpoint addresses
Defeats purpose of best-first ordering in DNS reply.
2019-01-17 09:51:42 +01:00
Davide De Rosa 323807cfbf Configure reviewer event count in AppConstants 2018-12-10 12:53:15 +01:00
Davide De Rosa 76c50e637d Add reviewer singleton
Prompt for rating after N events.
2018-12-10 12:47:53 +01:00
Davide De Rosa 5dea24295d Update API URL following relocation 2018-12-09 12:30:39 +01:00
Davide De Rosa 9daf64648b Fix handling of HTTP 304 from infrastructure ws 2018-12-06 10:37:22 +01:00
Davide De Rosa d25753a263 Use custom domain to avoid GitHub redirect
Badly handled by iOS.

Fixes #29
2018-12-06 10:26:15 +01:00
Davide De Rosa afcb45c614 Cache fetched license content
And show an error message when unable to fetch license URL.
2018-12-04 10:45:12 +01:00
Davide De Rosa a486cb4265 List licenses/notices in full table 2018-12-04 10:33:19 +01:00
Davide De Rosa 3d5c2bb8f5 Move .ovpn parser to TunnelKit 2018-11-10 11:39:36 +01:00
Davide De Rosa d9c984da27 Reword comment about host title format 2018-11-06 14:29:30 +01:00
Davide De Rosa c7cb00f679 Move ProfileKey to separate file 2018-11-06 11:16:34 +01:00
Davide De Rosa 389746180b Move PlaceholderConnectionProfile to separate file 2018-11-06 11:16:30 +01:00
Davide De Rosa 0c389d8d8e Make caught errors warnings instead 2018-11-06 11:03:15 +01:00
Davide De Rosa 299c4088ad Improve ConnectionProfile description format
Refines 137e87a
2018-11-06 11:02:44 +01:00
Davide De Rosa aa6af8acb3 Update TunnelKit to fix IPv4 endianness
Hopefully once and for all!
2018-11-05 20:48:51 +01:00
Davide De Rosa 66cfab678b Fix wrong team ID
Even if essentially unused.
2018-11-05 15:44:49 +01:00
Davide De Rosa fb8e7f9950 Update SwiftGen comments 2018-11-05 14:12:30 +01:00
Davide De Rosa 5b016df7f3 Drop optional, lastModified is non-optional 2018-11-04 18:32:08 +01:00
Davide De Rosa ceeda8c314 Fix default trust policy 2018-11-04 16:49:46 +01:00
Davide De Rosa 137e87ad69 Add description for generic ConnectionProfile 2018-11-04 15:56:05 +01:00
Davide De Rosa e7d2dde972 Add/remove profile to/from filesystem immediately
Save unnecessary serialization of unaffected profiles.
2018-11-04 15:06:53 +01:00
Davide De Rosa bc0568cc38 Do not re-save profiles on (de)activate
Only service JSON is affected.
2018-11-04 14:55:25 +01:00
Davide De Rosa 9bda7f9576 Reword policy text 2018-11-04 12:14:23 +01:00
Davide De Rosa 2dafe9f1f2 Invert caption/logic about trusted network policy
Looks more intuitive (default ON).
2018-11-04 12:02:02 +01:00
Davide De Rosa cfad536048 Attach .ovpn rather than .txt
Less convenient to quick look, yet more convenient for testing
import.
2018-11-04 11:57:44 +01:00
Davide De Rosa f2b5c05d58 Test and fix behavior with compression options
Changes in #20 were insufficient.
2018-11-04 11:57:37 +01:00
Davide De Rosa c1065751b6 Add method to parse configuration from [String]
With an optional original URL. Helps testing. Take the chance to
also disambiguate method overloads.
2018-11-04 11:45:19 +01:00
Davide De Rosa 9e7c4960e5 Update GitHub URL in license preamble 2018-11-04 10:53:16 +01:00
Davide De Rosa 1ab26dd8a2 Update GitHub repository constants 2018-11-04 10:53:16 +01:00
Davide De Rosa ef03b2b94d Leave serialization up to delegate
Ends up calling saveProfiles() multiple times otherwise.
2018-11-04 10:49:40 +01:00
Davide De Rosa 8e445e90b3 Move profile reactions to delegate
- Activation
- Removal
2018-11-04 10:49:40 +01:00
Davide De Rosa f75fbfb4bb Remove keychain password with profile removal 2018-11-02 15:52:36 +01:00
Davide De Rosa b051f8118f Add "Edit" item to rename host profile
Disabled in network profiles. Reuse same title style/constraints
and message strings in host wizard.

For consistency, rename activate() to activateProfile(). And it's
not even an IBAction.
2018-11-02 15:52:36 +01:00
Davide De Rosa 56c0a1a15e Add profile renaming logic
- Suspend delegation of internal add/remove.
- Review several try/throws.
2018-11-02 15:52:36 +01:00
Davide De Rosa aa2b6bafaf Add method to rename immutable profile 2018-11-02 15:52:34 +01:00
Davide De Rosa 3f1e98f8ac Delegate profile management from ConnectionService
Makes much more sense than dumb wizard notifications. Organizer is
already a ConnectionServiceDelegate.
2018-11-02 15:20:37 +01:00
Davide De Rosa a0ff420f54 Add dot as legal char in profile title
Fixes #22
2018-11-02 14:06:04 +01:00
Davide De Rosa d756948872 Fix endianness of pool addresses
Rushed in 64cbb9b but still broken.
2018-11-02 13:59:35 +01:00
Davide De Rosa 4870e2233d Fix regexes to warn about compression
By not including the potential argument in the pattern:

- comp-lzo *always* raises a warning
- compress *never* raises a warning
2018-11-02 00:04:28 +01:00
Davide De Rosa af870e2a84 Fix migrateJSON declarations and exposure
Unit tests could not compile.
2018-11-01 23:55:59 +01:00
Davide De Rosa 25c2308c63 Reject encrypted certificate key
Do at least a poor-man check on the PEM header.

Fixes #15
2018-11-01 14:31:24 +01:00
Davide De Rosa 0ab2244c36 Revert "Move variable declaration to proper scope"
This reverts commit 49b86c2888.

...because it was VERY WRONG.
2018-11-01 14:29:03 +01:00
Davide De Rosa 52394296be Drop pre-release migration logic 2018-11-01 13:42:20 +01:00
Davide De Rosa 64cbb9b4b2 Use versioned TunnelKit
Also fixes issues with IPv4/UInt32 endianness.
2018-11-01 13:41:27 +01:00
Davide De Rosa a4f46d0d7b Reword imported hosts title 2018-11-01 13:40:15 +01:00
Davide De Rosa 964a4d701b Make serviceURL an external static var 2018-11-01 13:40:15 +01:00
Davide De Rosa 36995e089b Locate profiles via relative URLs
Avoid absolute URLs, profiles directory is always relative to
documents. Assume profiles to be based in the documents root
unless directory is != nil.

Given that, starting from iOS 8, the documents location can change
from time to time, could this fix #19?
2018-11-01 13:39:55 +01:00
Davide De Rosa 2197c96bd9 Move serialization URLs to ConnectionService
Keep ProfileKey a bare struct.
2018-11-01 13:32:53 +01:00
Davide De Rosa 6cb85a952d Find source links in the home page 2018-10-30 20:46:41 +01:00
Davide De Rosa 88124f5588 Replace source section with web section 2018-10-30 20:44:58 +01:00
Davide De Rosa 0706d552be Drop redundant disconnection alert on Wi-Fi add
Doesn't trust by default, so it won't disconnect.

See 474105d
2018-10-30 00:30:30 +01:00
Davide De Rosa 2564f2446d Show disclaimer from website 2018-10-29 21:25:22 +01:00
Davide De Rosa fe85677e68 Add privacy policy 2018-10-29 21:25:08 +01:00
Davide De Rosa 482b51cb52 Move non-affiliation to main version screen 2018-10-29 21:25:08 +01:00
Davide De Rosa 17ebaccbad Add title to version screen 2018-10-29 21:25:08 +01:00
Davide De Rosa fec2f02df5 Move Credits inside Version 2018-10-29 21:25:06 +01:00
Davide De Rosa cced9b018f Fix provider name ordering
Define intrinsecally with Comparable.
2018-10-29 17:48:17 +01:00
Davide De Rosa 0d49d1abc8 Upgrade SwiftGen 2018-10-28 14:50:12 +01:00
Davide De Rosa 474105d671 Add current Wi-Fi without auto-trusting 2018-10-28 14:50:09 +01:00
Davide De Rosa ebe8c5836b Only retain first parsing warning 2018-10-28 14:41:41 +01:00
Davide De Rosa 49b86c2888 Move variable declaration to proper scope 2018-10-28 14:41:41 +01:00
Davide De Rosa 326c5b823d Observe wizard creation via notifications
Flow is too scattered to safely maintain delegation.
2018-10-27 20:11:26 +02:00
Davide De Rosa fa59b8b5f9 Fix handling of extra whitespaces in .ovpn
Fixes #17
2018-10-27 19:49:35 +02:00
Davide De Rosa b7dc72a5e9 Sort hosts ignoring case 2018-10-27 16:56:41 +02:00
Davide De Rosa 8d2ce2e7ae Handle potentially unsupported as a warning alert
Configuration is imported anyway, so alert must be asynchronous.
2018-10-27 14:57:37 +02:00
Davide De Rosa 0b7ab7bca6 Intercept potentially unsupported options
As warnings.
2018-10-27 14:51:51 +02:00
Davide De Rosa cda53bc4f1 Clean up Inbox on migration 2018-10-27 13:35:21 +02:00
Davide De Rosa dcecc84bda Remove .ovpn of deleted profile 2018-10-27 13:35:21 +02:00
Davide De Rosa 0e7c0b6388 List imported .ovpn if any, fall back to alert
Use .formSheet presentation (iPad).
2018-10-27 12:43:26 +02:00
Davide De Rosa 25523b5f61 Add stubs for imported hosts 2018-10-27 12:43:26 +02:00
Davide De Rosa 9e933d68c5 Improve unsupported options filter 2018-10-27 12:33:30 +02:00
Davide De Rosa 8c1e6d00ca Parse .ovpn file outside of wizard context 2018-10-27 12:33:17 +02:00
Davide De Rosa 422c4da09c Move ParsedFile out of WizardHostVC 2018-10-27 12:08:44 +02:00
Davide De Rosa 0d14349bca Move filename charset to extensions 2018-10-27 12:08:44 +02:00
Davide De Rosa 4bcb1fe2ad Convert some warnings to errors 2018-10-27 12:08:44 +02:00
Davide De Rosa 804585f13d Fix/improve some poor filename parsing 2018-10-27 10:52:26 +02:00
Davide De Rosa e00129c8a5 Adjust issue alert to new .ovpn attachment 2018-10-27 09:43:57 +02:00
Davide De Rosa 4b075bcc95 Improve alerts on configuration import error
Issue reporting is currently disabled because un unparsed .ovpn
may contain sensitive data.
2018-10-27 09:43:57 +02:00