passepartoutvpn/passepartout-apple
1
0
Fork 0
mirror of https://github.com/passepartoutvpn/passepartout-apple.git synced 2024-12-24 02:21:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,851 Commits 2 Branches 126 Tags 91 MiB
3e2823c2e0
Commit Graph

1382 Commits

Author SHA1 Message Date
Davide De Rosa
d02da0bad8
Fill missing descriptions for some errors (#359) 
Fixes #358
 2023-09-10 17:15:40 +02:00
Davide De Rosa
9d72dc43a2 Attempt release 2023-09-10 11:21:59 +02:00
Davide De Rosa
f32c6f8fde
Retain persistence objects in manager (#357) 
Relying on Core Data for context retention is fragile, better to keep a
reference of the *Persistence objects ourselves.

Also, remove any CloudKit reference from CoreContext.
 2023-09-10 11:20:56 +02:00
Davide De Rosa
0b755c1c77 Attempt release 2023-09-10 10:35:22 +02:00
Davide De Rosa
0872c27fce
Move CloudKit logic to PersistenceManager (#355) 
Observe updates rather than execute operations imperatively. Also refine
responsibilities of AppContext and CoreContext.
 2023-09-10 10:34:42 +02:00
Davide De Rosa
c645f39254
Fix SandboxChecker actor (#356) 
Mac function was still running on main actor. Only constrain to main
actor on public API.
 2023-09-10 10:27:11 +02:00
Davide De Rosa
3891723356 Attempt release 2023-09-10 08:09:05 +02:00
Davide De Rosa
6b0a08a189 Attempt release 
Fix sed syntax on Mac.
 2023-09-10 01:08:07 +02:00
Davide De Rosa
a38e3fed7a
Look up TestFlight flag asynchronously (#352) 
Xcode has been quite obnoxious recently with this issue. Start the app
with the most restrictive type (.undefined), relax restrictions after
looking up sandbox and app receipt.
 2023-09-10 00:52:39 +02:00
Davide De Rosa
33d9e05907
Drop < 2.2.0 key after migration (#353) 
Otherwise, iCloud is being constantly reinforced to true.
 2023-09-10 00:50:12 +02:00
Davide De Rosa
791b6be7d5
Allow erasing remote iCloud store (#351) 
Convenient for those with privacy concerns.
 2023-09-09 21:52:32 +02:00
Davide De Rosa
a4ca8cc996
Support iCloud sync as an option (#350) 
Sync will be enabled on upgrade for consistency with current behavior,
and disabled for new installs.

Fixes #227
 2023-09-09 20:29:04 +02:00
Davide De Rosa
2d046181b0
Only migrate if current version is higher (#349) 2023-09-08 22:45:04 +02:00
Davide De Rosa
a3cfde1950
Drop v2 migrations (#348) 2023-09-08 22:18:41 +02:00
Davide De Rosa
0f84859354
Do some housekeeping (#347) 
- Be consistent with on-demand rules
- Use shortcut reduce(into:)
 2023-09-08 16:20:42 +02:00
Davide De Rosa
c80d17ceb4
Fix .locksInBackground AppStorage key (#346) 2023-09-08 16:20:24 +02:00
Davide De Rosa
b4b2db176c
Fix .sink retain cycles (#345) 2023-09-08 16:20:01 +02:00
Davide De Rosa
f159252e24
Replicate Diagnostics in Settings (#342) 
As the only link to "Diagnostics" appears in the profile screen, when
there are no profiles the screen is unreachable. Replicate the same
entry in Settings.
 2023-08-06 20:27:16 +02:00
Davide De Rosa
04e090e26f
Suppress SceneConfiguration warning (#341) 2023-08-06 09:43:24 +02:00
Davide De Rosa
7a74525149 Fix b608d59d8f 2023-07-31 08:25:30 +02:00
Davide De Rosa
19e52bfd59 Attempt release 2023-07-30 18:01:44 +02:00
Davide De Rosa
b608d59d8f
Omit footer when on-demand is disabled (#339) 
Preserve footer in that case, just empty. Adding/removing footer seems
to result in a worse animation.
 2023-07-30 17:59:29 +02:00
Davide De Rosa
388af4a73c Attempt release 2023-07-30 17:47:41 +02:00
Davide De Rosa
db4c6094ea Attempt release 2023-07-24 23:32:51 +02:00
Davide De Rosa
bae843363c
Fall back sandbox receipt to release receipt (#337) 
Could be a way to enable paid features in TestFlight builds for those
who originally bought them from the App Store.
 2023-07-24 23:32:05 +02:00
Davide De Rosa
65d6e30469
Consider text length in endpoint rows (#336) 2023-07-23 15:17:28 +02:00
Davide De Rosa
38cca79683 Attempt release 2023-07-23 13:59:56 +02:00
Davide De Rosa
34f6738b69
Focus some text fields on appearance (#334) 
Feature from iOS 15, use it on:

- New profile name
- New profile passphrase
- Renamed profile name
- Account username
 2023-07-23 13:28:47 +02:00
Davide De Rosa
6ede6f052a
Allow editing of OpenVPN endpoints (#335) 
Hosts only:

- Add new
- Edit/delete existing
- Reorder

Closes #206
 2023-07-23 12:45:47 +02:00
Davide De Rosa
e0dbca224f
Rework "Trusted networks" to be a generic "On-demand" (#333) 
Extend the feature by also providing a complementary "include" policy,
i.e. activate the VPN _only_ on the specified networks. "Trusted
networks" was only providing the "exclude" counterpart, i.e. _except_
the specified networks.

Closes #119
 2023-07-23 08:44:46 +02:00
Davide De Rosa
1c3cbe02e5
Improve OpenVPN Endpoint UX (#332) 
- Make selection linear by address
- Do not hide endpoints when automatic, show disabled
- Suggest manual endpoint required
- Pre-expand selected endpoint address
- Do not dismiss on selection, because selected value is not visible in
ProfileView
 2023-07-22 17:10:16 +02:00
Davide De Rosa
0734816c05 Bump version 2023-07-17 21:48:25 +02:00
Davide De Rosa
2357324a74
Update some metadata (#331) 
A bit of everything.

- Use GitHub handles in CHANGELOG
- Mention XOR patch in README and keywords
- Update gems
- Add GitHub issue template
- Fix missing script in release workflow
 2023-07-17 21:46:32 +02:00
Davide De Rosa
4173c7aa6c
Externalize complex bindings (#329) 
Some bindings are too convoluted, move them out of initializers.
 2023-07-17 21:44:18 +02:00
Davide De Rosa
0804c6b38e Attempt release 2023-07-06 18:47:35 +01:00
Davide De Rosa
a7ea010d4e
Extend error handler to modals (#327) 2023-07-06 19:29:10 +02:00
Davide De Rosa
1935d9e92c Attempt release 2023-07-06 11:10:10 +01:00
Davide De Rosa
cf43e1cd7b Attempt release 2023-07-06 11:05:27 +01:00
Davide De Rosa
b5d230f0b9 Attempt release 
Use TunnelKit 6.1.0
 2023-07-05 17:16:09 +01:00
Davide De Rosa
f0e3b2fa9c
Improve release workflow (#326) 2023-07-05 18:07:47 +02:00
Davide De Rosa
98e5e4cdde
Share common protocols across localized strings (#324) 2023-07-05 17:18:33 +02:00
Davide De Rosa
bf70c7c59a
Reorganize app folders (#323) 2023-07-04 22:29:43 +02:00
Davide De Rosa
bd6340ce77
Split reusable views into extensions (#322) 
Like in #321
 2023-07-03 17:37:16 +02:00
Davide De Rosa
d7ebcb23ba
Split views into extensions (#321) 
Nothing but moving code around to reorganize views into the following
sections (MARK):

- Properties/Body
- Subviews
- Actions
 2023-07-03 16:54:43 +02:00
Davide De Rosa
7198150f00
Refactor alerts to use latest API (#320) 2023-07-03 16:41:49 +02:00
Davide De Rosa
278efaf347
Refactor domain errors (#310) 2023-07-02 12:51:50 +02:00
Davide De Rosa
3a06d6c984 Do not use spaces in filenames 2023-06-18 10:05:10 +02:00
Davide De Rosa
7030ad40c2 Do not observe shared entities if uninterested (#313) 
`@ObservedObject` is unnecessary in cases where manager operation is
unidirectional.
 2023-06-18 10:05:10 +02:00
Davide De Rosa
ddab76326d
Replace deprecated .windows with .connectedScenes (#316) 2023-06-17 21:40:09 +02:00
Davide De Rosa
fb47def4ed
Avoid inline format for non-descriptive strings (#302) 2023-05-28 11:57:35 +02:00
Davide De Rosa
b89328b5c3
Only show 'Reconnect' on active profile (#311) 
It doesn't make sense anywhere else.
 2023-05-28 11:23:07 +02:00
Davide De Rosa
36cad41529
Fix IPv4/6 address validation (#308) 2023-05-27 21:34:31 +02:00
Davide De Rosa
d05cf7140c
Fail gracefully when refreshing infrastructure (#307) 2023-05-27 13:52:57 +02:00
Davide De Rosa
a78a7b18b5
Encapsulate *Persistence responsibilities (#305) 
Do not leave the choice of a repository context up to the library
consumer. Instead, provide a specific factory (*Persistence) for each
module.
 2023-05-27 12:32:53 +02:00
Davide De Rosa
7ccb10febc
Rethink library architecture (#301) 2023-05-24 18:19:47 +02:00
Davide De Rosa
b4ad8dea0d Do some code clean up 
- Use guard in validators

- Rename URL.openURL() to URL.open()

- Sort imports (SwiftLint)

- Drop unused VPNProtocolType.allTypes

- Drop unused imports
 2023-05-21 11:48:03 +02:00
Davide De Rosa
1051a8dc52
Revisit domain name validators (#297) 
- Allow TLDs longer than 6 characters

- Allow wildcards in proxy bypass domains
 2023-05-01 11:44:41 +02:00
Davide De Rosa
40330cc87a Attempt beta release 2023-04-18 18:15:39 +02:00
Davide De Rosa
1fd38790e4 Attempt beta release 2023-04-18 17:24:47 +02:00
Dmytro Chyrkin
1cb5821f9d
Small fixes for Ukrainian translation (#288) 2023-04-12 09:05:39 +02:00
Davide De Rosa
574f9a05b5
Show app version in Mac menu (#286) 2023-04-08 11:57:42 +02:00
Davide De Rosa
50b4806275
Remove nonsense Mac menus (#285) 2023-04-08 11:56:17 +02:00
Davide De Rosa
7a7a815979 Attempt beta release 2023-04-06 12:51:01 +02:00
Davide De Rosa
aec7f8eefe Attempt beta release 2023-04-05 16:32:50 +02:00
Davide De Rosa
e3cfdadf97
Cover screen on .inactive (#282) 
* Make unlock block actor-safe

* Cover views on .inactive, lock on .background
 2023-04-05 16:31:17 +02:00
Davide De Rosa
0591363b15 Refine platform-specific release notes 
Symlink metadata to iOS, except "What's New".
 2023-04-05 07:59:50 +02:00
Davide De Rosa
34e41ba93f Attempt beta release 2023-04-04 18:59:44 +02:00
Davide De Rosa
07bd126131
Recognize IAPs other than full version on Mac (#281) 2023-04-04 18:59:05 +02:00
Davide De Rosa
d4d3d97081 Attempt beta release 2023-04-04 17:11:44 +02:00
Davide De Rosa
ad90a5908b Fix truncation in provider footer 2023-04-04 17:10:54 +02:00
Davide De Rosa
7e2e4d6caa
Import missing translations (#280) 2023-04-04 17:07:41 +02:00
Davide De Rosa
e050c0c8df
Catch WireGuard parsing errors properly (#279) 
They could be reported as OpenVPN errors.
 2023-04-03 08:48:18 +02:00
Davide De Rosa
7f9ae7c3bc
Always show "Reconnect" button (#278) 
Will do nothing if VPN is disabled. Suboptimal, but consistent
with Mac menu.
 2023-04-01 22:46:12 +02:00
Davide De Rosa
33e0ceec04
Lock in background (#275) 
There are plenty of situations where the app kind of stays in the
foreground, but goes to .inactive state. Lock screen could be
annoying in those cases.
 2023-03-31 23:47:29 +02:00
Davide De Rosa
e9f11d1dbe Attempt beta release 2023-03-25 17:07:58 +01:00
Davide De Rosa
1e0d522010
Drop #available condition on iOS 15 (#274) 2023-03-25 17:05:53 +01:00
Davide De Rosa
6af4bb7e0f
Resolve issues with lock screen (#273) 
* Make lock screen a View extension

- Reuse in global theme (apply to all modals)

- Use a ZStack rather than replace (retain content/navigation)

- Share lock state across all LockableView
 2023-03-25 16:47:08 +01:00
Davide De Rosa
76084dbd30 Attempt beta release 2023-03-20 15:07:26 +01:00
Davide De Rosa
4eb2ac5e0e
Revert interactive login (#272) 
Implementation is buggy/incomplete.

See #259
 2023-03-20 15:06:56 +01:00
Davide De Rosa
2d00a05c4c Attempt beta release 2023-03-20 14:14:20 +01:00
Davide De Rosa
5f991d9cc2
Unlock app with biometrics (#271) 
* Prevent app lock completely in macOS

* Add missing Face ID metadata for biometrics auth

* Ensure MainActor

* Reword option

* Fix lock logic on launch
 2023-03-20 14:12:42 +01:00
Davide De Rosa
325e10845d
Option to lock app when entering background (#270) 2023-03-20 11:00:01 +01:00
Davide De Rosa
7346bfc65c
Add 3D Touch items (#267) 
- Enable/Disable VPN

- Reconnect (if enabled)

Move lifecycle operations to SceneDelegate.
 2023-03-19 20:04:31 +01:00
Davide De Rosa
4a2dec9c6a Attempt beta release 2023-03-19 16:11:09 +01:00
Davide De Rosa
513b38584d
Upgrade SwiftLint to CI version (#266) 2023-03-19 16:10:40 +01:00
Davide De Rosa
4faeb85295 Attempt beta release 
Update bundle in beta script.
 2023-03-19 14:42:56 +01:00
Davide De Rosa
fbd32d8b26
Fine-tune SwiftLint (#265) 2023-03-19 14:41:53 +01:00
Davide De Rosa
1dda8dce98 Attempt beta release 2023-03-19 08:45:34 +01:00
Davide De Rosa
17ae9793df
Randomize provider server (#263) 
* Pick random server within location

* Add toggle to provider section in profile
 2023-03-19 08:19:32 +01:00
Davide De Rosa
c85f3d894e
Restore DNS "Domain" setting (#260) 2023-03-17 22:16:04 +01:00
Davide De Rosa
f06f097f27
Add SwiftLint phase (#262) 2023-03-17 21:55:47 +01:00
Davide De Rosa
cecf64d871
Move Diagnostics view to Profile bottom (#261) 2023-03-17 21:46:53 +01:00
Davide De Rosa
26c34638cb Make category optional in server long description 2023-03-17 18:09:21 +01:00
Davide De Rosa
8f999a462e Do not open long content when XOR is disabled 2023-03-17 17:52:57 +01:00
Davide De Rosa
37354d1b87 Update copyright 2023-03-17 16:56:19 +01:00
Davide De Rosa
2e10aab039
Extend authentication methods (#259) 
* Add profile authentication method

- Persistent (default, fallback)

- Interactive (may expire through reconnections)

- TOTP (seed-based) - currently disabled

* Disable on-demand if login is interactive

* Present interactive prompt on VPN toggle
 2023-03-17 16:49:35 +01:00
Davide De Rosa
44ccd21536
Fetch full profiles from Core Data (#258) 
* Fetch full profiles

* Manage full profiles in organizer
 2023-03-16 16:49:09 +01:00
Davide De Rosa
17b01a4dbc Clean up some code 
- Drop stale generic

- Improve readability
 2023-03-16 15:12:23 +01:00
Davide De Rosa
1b704d7d4a
Decouple VPNManager from TunnelKit (#248) 
* Drop VPNManager dependency on TunnelKit

* Hook .masksPrivateData to preferences updates
 2022-11-10 07:42:08 +01:00
Davide De Rosa
7ed27558fc
Move refund detection inside ProductManager (#246) 
* Detect refunds inside ProductManager

Compare former value and report refund event via subject.

* Hook VPN uninstallation on refund event
 2022-11-06 18:51:13 +01:00
Davide De Rosa
ba09dcffa7
Full OpenVPN XOR patch (#245) 2022-11-06 18:08:41 +01:00
Davide De Rosa
c48e35887c Bump version 2022-11-02 22:33:26 +01:00
Dmitry Chirkin
07eaa54f1b
Ukrainian transaltion (#243) 
Co-authored-by: Davide De Rosa <keeshux@gmail.com>
 2022-11-01 14:20:09 +01:00
Davide De Rosa
e2c976e58d Attempt beta release 2022-10-31 14:18:07 +01:00
Davide De Rosa
baac1f59a8 Bump version 2022-10-31 08:57:05 +01:00
Davide De Rosa
22c28de641
Retain original filename as imported profile name (#240) 2022-10-30 10:22:44 +01:00
Davide De Rosa
e4ec1e642d Attempt beta release 2022-10-29 13:40:50 +02:00
Davide De Rosa
b2bdf23c54 Revisit pull section in OpenVPN Endpoint 
- Hide from server diagnostics

- Use a better section title
 2022-10-29 13:40:30 +02:00
Davide De Rosa
b2ec7f0422 Attempt beta release 2022-10-29 13:01:18 +02:00
Davide De Rosa
cdc05f0c10 Update TunnelKit 
Split IP settings and routes. Now properly handling local routes.
 2022-10-29 12:28:27 +02:00
Davide De Rosa
0f04bdcce3 Attempt beta release 2022-10-28 15:42:10 +02:00
Davide De Rosa
b431ce4f05 Attempt beta release 2022-10-27 00:43:41 +02:00
Davide De Rosa
a96fff2add Import new translations 2022-10-26 17:03:54 +02:00
Davide De Rosa
e28bb3db9a Ack new refunds only if refunds list was altered 
Fixes #238
 2022-10-25 12:48:45 +02:00
Davide De Rosa
e1d8ec6066 Attempt beta release 2022-10-25 09:07:39 +02:00
Davide De Rosa
c0cc10ab94
Restore reconnect action (#232) 
* Add "Reconnect" in profile view

* Add "Reconnect" in profile context menu

* Update CHANGELOG

* Restrict "Reconnect" in context menu to iOS 16

SwiftUI does not react properly to state updates.
 2022-10-17 17:36:32 +02:00
Davide De Rosa
c7a0a3e4b8 Drop 'non-official' from strings 2022-10-17 13:35:30 +02:00
Davide De Rosa
f6e0caaa73 Implement --remote-random-hostname 
- Update TunnelKit

- Show in UI
 2022-10-17 09:06:52 +02:00
Davide De Rosa
6c6904255d Bump version 2022-10-17 09:05:27 +02:00
Davide De Rosa
54dc2307e9 Attempt beta release 2022-10-16 10:09:35 +02:00
Davide De Rosa
6a228d29c7 Use specific rounded Mac icon 2022-10-16 10:09:19 +02:00
Davide De Rosa
c345265451 Attempt beta release 2022-10-16 08:36:17 +02:00
Davide De Rosa
54c53707e0
Add app log in Diagnostics screen (#234) 2022-10-16 08:33:32 +02:00
Davide De Rosa
fbc17877b1 Suppress buggy Xcode warnings 
@discardableResult annotations became suddenly ineffective.
 2022-10-15 22:30:21 +02:00
Davide De Rosa
7f748e6d1e Reuse "Download" for pulled OpenVPN settings 2022-10-15 16:52:58 +02:00
Davide De Rosa
c4ca510b72 Fix app icon inconsistencies 
- iOS: Single size

- macOS: Add missing
 2022-10-15 16:41:13 +02:00
Davide De Rosa
592b0801e2 Prefix server description with category 2022-10-13 23:07:31 +02:00
Davide De Rosa
6031d0119a Drop assertion on legit intents scenario 2022-10-13 19:10:45 +02:00
Davide De Rosa
f95e4f228d
Implement --route-nopull via TunnelKit (#230) 
Use it internally to override server-pushed settings.
 2022-10-13 19:09:51 +02:00
Davide De Rosa
5627e6c4a9
Address UI race conditions (#229) 
* Make some managers concurrency-safe

- IntentsManager: @MainActor, non-shared, continuation

- SSIDReader: @MainActor, continuation

- Reviewer: main queue, non-shared

* Review wrong use of Concurrency framework

There were background thread calls e.g. in VPNToggle, because
ProfileManager was used inside a VPNManager async call.

Annotate @MainActor wherever a Task involves UI.

* Make main managers MainActor

* Apply MainActor to Mac menus

* [ci skip] Update CHANGELOG

* Set MainActor consistently on Mac menu view models
 2022-10-13 08:53:50 +02:00
Davide De Rosa
54dc8a2556 Use MockVPN from TunnelKit 
Rather than ad hoc strategy.
 2022-10-12 22:37:40 +02:00
Davide De Rosa
f21d05aa53 Add IVPN metadata 2022-10-08 11:33:03 +02:00
Davide De Rosa
07328982d6 Restore PIA provider 2022-10-05 08:18:46 +02:00
Davide De Rosa
63c3ac80b4 Attempt beta release 2022-10-04 22:37:53 +02:00
Davide De Rosa
e2c1a4c686 Fix Oeck eligibility regression 2022-10-04 22:37:53 +02:00
Davide De Rosa
6183433c13 Drop unused libraries 2022-09-30 22:26:56 +02:00
Davide De Rosa
ecb3138817 Attempt beta release 2022-09-25 08:55:15 +02:00
Davide De Rosa
025421aa08 Refactor some alert translations 2022-09-25 08:35:52 +02:00
Davide De Rosa
496d993e3d Attempt beta release 2022-09-23 23:07:40 +02:00
Davide De Rosa
1364d5153e Attempt beta release 2022-09-23 22:57:36 +02:00
Davide De Rosa
a3fd5c40d4 Fix access to hidden OpenVPN.Configuration.Fallback 2022-09-23 22:56:27 +02:00
Davide De Rosa
be6726fbd8 Attempt beta release 2022-09-23 21:56:37 +02:00
Davide De Rosa
f755550974 Increase debug log view size 2022-09-23 09:04:27 +02:00
Davide De Rosa
c2aef310f3 Fix again server ordering 2022-09-21 22:32:33 +02:00
Davide De Rosa
db6f7bdf28 Revisit app metadata and screenshots 
- Add script to import localized metadata

- Update app name, subtitle, keywords

- Update App Store description

    - Replace "OpenVPN" with "VPN"

    - Add .conf file extension (WireGuard)

    - Drop PIA (404)

    - Drop trailing notices

- Update README snapshots (Mac versions unused)

- Update App Store screenshots

- Revert to legacy launch screen (SwiftUI method stretches)
 2022-09-15 17:41:22 +02:00
Davide De Rosa
38bdbc3697 Move diagnostics to settings 2022-09-12 22:58:37 +02:00
Davide De Rosa
940e0cf8c9 Attempt beta release 2022-09-05 22:35:22 +02:00
Davide De Rosa
5c681d6c3f Import new localizations 2022-09-05 22:34:51 +02:00
Davide De Rosa
3b146b3e0f Fix var syntax 2022-09-05 07:58:20 +02:00
Davide De Rosa
092d4f5de2 Drop return in one-line functions 2022-09-04 20:30:55 +02:00
Davide De Rosa
1005a12a66 Add extended provider location description 
- Profile: Below location row

- Menu: On top of server list
 2022-09-04 19:23:40 +02:00
Davide De Rosa
7975ddd194 Fix provider header in profile view 2022-09-04 19:23:27 +02:00
Davide De Rosa
b322bde137 Refactor string ids after adding SettingsView 2022-09-03 14:59:17 +02:00
Davide De Rosa
4c4b3ee0c9 Revert to concrete-only managers 
Abstraction was overcomplicated. Strategy pattern is enough.
 2022-09-03 12:47:40 +02:00
Davide De Rosa
28f7c6bbe8 Restore longer localizations in Settings/About 2022-08-28 09:24:02 +02:00
Davide De Rosa
f36d7596d0 Integrate settings with about screen 
Move everything to SettingsView and remove invite actions.
 2022-08-27 23:15:51 +02:00
Davide De Rosa
10270b02ee On Mac, copy debug log to pasteboard, do not share 
UIActivityViewController is lame.
 2022-08-27 22:21:34 +02:00
Davide De Rosa
0fee726951 Make profile "Connect" item a connection toggle 
Requires adding multiple delegates to LightVPNManager.
 2022-08-19 17:43:56 +02:00
Davide De Rosa
4d56ed6fca Only hide app by closing it 
Keep constant "Show" action in menu:

- Bring app to foreground if in background
- Activate app if already in foreground
 2022-08-19 17:43:52 +02:00
Davide De Rosa
d10edc69fe Restore truncated VPN footer workaround 2022-08-19 08:34:55 +02:00
Davide De Rosa
f465108a0a Attempt beta release 2022-08-16 12:43:20 +02:00
Davide De Rosa
0f790a9401 Fix leaks when reconnecting from menu 
LightVPNManager implementation was still disabling/enabling VPN
manually instead of using reconnect() atomically, which led to an
IP leak in between the two steps.
 2022-08-13 16:48:00 +02:00
Davide De Rosa
7a700408a8 Improve a few things about provider profile menus 
- Add "Connect" item to connect to current server

- Sort provider categories ("Default" should also come first)

Reuse bundle from constants.
 2022-08-13 16:47:01 +02:00
Davide De Rosa
80f71507e3 Do not navigate to active profile on launch 2022-08-05 12:50:12 +02:00
Davide De Rosa
0464cd0476 Fix property in launch on login bindings 2022-08-04 23:35:42 +02:00
Davide De Rosa
9195d426e4 Attempt beta release 2022-07-18 08:03:24 +02:00
Davide De Rosa
f8c6b6580d Encapsulate launchesOnLogin AppPreference from Mac 2022-07-18 08:03:24 +02:00
Davide De Rosa
b26e334881 Get Mac strings from main bundle 
Alter bundle in SwiftGen configuration file.
 2022-07-18 07:55:56 +02:00
Davide De Rosa
04faf57d4c Send app to background if started hidden 
Sandbox had to be enabled in order to submit binary to App Store
Connect, therefore command line arguments cannot be used to tell
if the app was started by the launcher.

However, given that launcher starts app in hidden state, we can
safely assert that if the app is hidden on start, it was started
by the launcher.

See f33380b4e2

Also drop automatic signing on Mac bundle and unused utils.
 2022-07-18 07:55:56 +02:00
Davide De Rosa
32e548421f Attempt beta release 2022-07-17 14:50:05 +02:00
Davide De Rosa
2c5f3d0bf0 Send app to background in OrganizerView handler 
Keep handler in a single place.
 2022-07-17 14:47:15 +02:00
Davide De Rosa
781291940f Enforce window appearance on 'Show' after closure 2022-07-16 21:24:53 +02:00
Davide De Rosa
9458c4f3a3 Fix server description and sorting 
- Name (countries, area)
- Index
- Tags

Also use short description in menu (without country prefix).
 2022-07-16 17:39:42 +02:00
Davide De Rosa
ce280c0826 Fix old entity naming 2022-07-16 17:39:42 +02:00
Davide De Rosa
48d8173871 Drop return in single line functions 2022-07-16 17:39:42 +02:00
Davide De Rosa
58e375ec41 Attach @MainActor where needed 
Some methods were updating UI from non-main thread.
 2022-07-16 17:39:42 +02:00
Davide De Rosa
f33380b4e2 Launch application in background from launcher 
Requires disabling sandbox for launcher to receive arguments.

https://developer.apple.com/documentation/appkit/nsworkspace/openconfiguration/3172708-arguments

Refine some minor things about launcher:

- Pass invoker to NSApp.terminate() calls

- Use legacy version of .openApplication() to drop Concurrency
 2022-07-16 17:39:42 +02:00
Davide De Rosa
3f4b55a003 Implement Mac bundle with system menu 
Use bundle as a means to provide Mac APIs to Catalyst app.

In order to cross the @objc wall set by the Mac Bundle mechanism,
Swift structures cannot be used directly and must be bridged
through ObjC facades.

Create NSMenu in MVVM style and install it on app launch. Make
sure to do it in AppDelegate.applicationDidFinishLaunching(),
because doing it as early as in PassepartoutApp.init() would
crash Mac code.

Use .representedObject to own view models.

With menu in place, app can be sent to background when main window
is closed. Requires multiple documents support for app not to die
instantly.
 2022-07-16 17:39:42 +02:00
Davide De Rosa
0a2d1e9d37 Mitigate fatalError() in properties, fail gracefully 
Do not trigger fatalError() on properties too much because
SwiftUI may read them at any unpredictable time.
 2022-07-08 20:01:53 +02:00
Davide De Rosa
a442603696 Polish bundleConfig with strong type checking 2022-07-05 08:11:31 +02:00
Davide De Rosa
ebe8ae3d29 Retain profiles order, no active on top 2022-07-04 00:32:06 +02:00
Davide De Rosa
e8f65e9db0 Also show active profile as "Disabled" 2022-07-04 00:31:54 +02:00
Davide De Rosa
15dec59692 Comment on app path inferral from launcher 2022-06-26 08:53:10 +02:00
Davide De Rosa
1543eef3c1 Add convenient appId constant 2022-06-25 20:27:24 +02:00
Davide De Rosa
b966826f19 Use main container path as launcher argument 
Rather than "Contents/MacOS/Passepartout", raising a permission
error.

Also add .hides to prevent window from showing on launch.
 2022-06-25 20:16:06 +02:00
Davide De Rosa
df0d40c556 Add launcher target 
- Launch main app in background then die

- Do not launch app if already running

- Launch app binary relative to launcher location
 2022-06-25 16:53:38 +02:00
Davide De Rosa
3cc82cc807 Fix case in Info keys related to launch screen 2022-06-25 16:53:38 +02:00
Davide De Rosa
7ba9879c8c Revisit constants structure 
Move some stuff back to App:

- Constants, and split library-dependent

- InApp entities and constants

Flatten global constants hierarchy.
 2022-06-25 14:36:28 +02:00
Davide De Rosa
9a8477225e Refactor library into domain + impl 2022-06-23 23:31:01 +02:00
Davide De Rosa
8504998bbb Reorganize app-specific shared code into AppShared 2022-06-19 14:41:26 +02:00
Davide De Rosa
85129f17af Prefix store keys with "Passepartout." domain 
Also remove stale preferences from early betas after migrating
relevant ones.

Extend KeyValueStore with removeValue() for this purpose.
 2022-06-19 13:33:49 +02:00
Davide De Rosa
02a9db057f Update TunnelKit 
- Set explicit tunnel log path

- OpenSSL 1.1.1o
 2022-06-19 13:33:49 +02:00
Davide De Rosa
bb1a35acea Set full log path relative to App Group container 
Also rename from Debug.log to App.log
 2022-06-19 13:33:49 +02:00
Davide De Rosa
10b4c321c8 Separate context responsibilities 
- Split Core and App context

- Move .shared instantiation to extension

Context may differ by target.
 2022-06-16 13:42:53 +02:00
Davide De Rosa
14b42fbea5 Persist managers state to generic key-value store 
Move all persisted state out of AppManager to where it really
belongs. To do that, inject a shared KeyValueStore object into
managers that need to persist part of their state in a strongly
typed manner.

Below are persisted states:

- PersistenceManager
    - persistenceAuthor

- ProfileManager
    - activeProfileId

- UpgradeManager (formerly AppManager)
    - didMigrateToV2 (migrate former value)

- VPNManager
    - tunnelLogFormat
    - masksPrivateData

A similar approach is used for app-specific preferences, by using
a strongly typed enum (AppPreference) together with SwiftUI
@AppStorage property wrapper.

Worth moving logging logic into a specific LogManager.

Finally, drop any former view dependency on AppManager, as states
are now accessed through specific managers.
 2022-06-16 13:42:37 +02:00
Davide De Rosa
77ff910adc Update and extend copyright notices 2022-06-16 13:42:21 +02:00
Davide De Rosa
b873e5e279 Strip VPNManager initialization 2022-06-02 20:52:51 +02:00
Davide De Rosa
1fd4fd4689 Fix required capabilities 2022-06-01 21:14:21 +02:00
Davide De Rosa
b768284197 Enforce .sidebar on Mac 
Drops annoying side inset.
 2022-05-24 09:15:27 +02:00
Davide De Rosa
f752594d3c Refactor no autocorrection into raw text style 2022-05-24 08:25:34 +02:00
Davide De Rosa
02213a7c50 Drop truncation hack 2022-05-23 10:10:02 +02:00
Davide De Rosa
83cdd460e4 Attempt beta release 2022-05-21 19:15:48 +02:00
Davide De Rosa
a2d4ed370e Revisit sidebar with per-profile VPN toggles 2022-05-21 19:15:37 +02:00
Davide De Rosa
f700993a52 Refactor global theme consistently 
- Return values rather than apply modifiers

- Use .insetGrouped by default

- Reuse .insetGrouped in StyledPicker

- Enforce .sidebar on iPad
 2022-05-21 19:04:35 +02:00
Davide De Rosa
f0c5ecd84f Handle configuration errors out of VPN status 
On configuration error, retain information about the profile that
triggered the error. For now, present an alert, but with this
information the UI can be easily changed later.
 2022-05-21 19:01:49 +02:00
Davide De Rosa
ae748dd1b3 Fix logo name 2022-05-21 18:55:40 +02:00
Davide De Rosa
46a8fb8a74 Delay presentation of imported file modal 
Fixes navigation bug on iOS 14 preventing modal from dismissing
via close button.
 2022-05-20 16:35:45 +02:00
Davide De Rosa
d6866e8e95 Fix iPad multitasking condition 2022-05-20 11:58:25 +02:00
Davide De Rosa
9735b9ab14 Use consistent case in assets 2022-05-19 10:33:36 +02:00
Davide De Rosa
c88dfc28c4 Simplify a few things of CopySavingButton 
- Make saving handler more readable

- Drop unnecessary protocol
 2022-05-18 14:10:11 +02:00
Davide De Rosa
ddce671c62 Move theme extensions to non-reusable 2022-05-18 11:33:29 +02:00
Davide De Rosa
b1d77cccbc Attempt beta release 2022-05-18 11:18:57 +02:00
Davide De Rosa
4455f66d10 Detect TestFlight on macOS 
Move function to Utils.
 2022-05-18 11:16:31 +02:00
Davide De Rosa
160338e62a Add credits in Mac about 2022-05-17 19:57:19 +02:00
Davide De Rosa
4c2a471b9f Attempt beta release 2022-05-17 19:34:13 +02:00
Davide De Rosa
4edecf123b Fix missing accent color in CI 
Finally? Basically Xcode build settings were referring to new
color name "AccentColor", while color set in repository was
still "accentColor".

Went unnoticed because Mac filesystem is case-insensitive, which
is why Git never committed the name change in the first place.
 2022-05-17 19:34:00 +02:00
Davide De Rosa
6c798c8b19 Bump build 2022-05-17 16:43:14 +02:00
Davide De Rosa
7196aeab0d Trust Ethernet on Mac 2022-05-16 11:19:33 +02:00
Davide De Rosa
f5e01f9768 Wrap/refine a few OS conditionals 2022-05-16 11:19:18 +02:00
Davide De Rosa
16d618df0e Show info menu in ProfileView on iPad/Mac 
Use .navigationBarTrailing to avoid artifact on Catalyst (item
relocates when first clicked).

Rename menu files too.
 2022-05-16 11:18:58 +02:00
Davide De Rosa
6fddbb8bfc Decouple menus from OrganizerView 
Could move .sheet() from parent View to Menu, but no luck with
.fileImporter()
 2022-05-16 11:18:58 +02:00
Davide De Rosa
d89130bc3a Reorganize profile menu into computed properties 2022-05-16 11:18:58 +02:00
Davide De Rosa
e87ad06c5d Drop old observables from profiles list 
List was being reloaded e.g. on ProductManager receipt updates,
but profile in-app eligibility is not a thing anymore.
 2022-05-16 10:59:12 +02:00
Davide De Rosa
137bacb542 Add contextual profile delete 
Without confirmation alert though.
 2022-05-15 22:24:36 +02:00
Davide De Rosa
35ec73570e Use NEHotspotNetwork to fetch current SSID 
Old method did not work on Catalyst.
 2022-05-15 22:24:36 +02:00
Davide De Rosa
743facca6b Improve Catalyst appearance 
- Revert to more "stable" iPad idiom

- Set accent color the proper way

- Use .tint when available

- Unify navigation style by idiom

- Retain navigation bars in sidebar/detail

- Lighten sidebar appearance

- Fix Menu style (dropdown -> button)

- Use native Picker (dropdown)

- Use switch toggles rather than checkboxes

- Replace .actionSheet with .alert

- Increase minimum row height

CAVEAT: on Mac with iPad idiom, having a Section in .sidebar
produces artifacts. Header keeps changing height for no reason.
Retain Section on iPad multitasking only to not break navigation.
 2022-05-15 22:24:36 +02:00
Davide De Rosa
eaaa1fe260 Move device checks to Theme 
Drop unused code along the way.
 2022-05-15 22:24:36 +02:00
Davide De Rosa
d558edf665 Assume test build if appType == .beta 2022-05-15 21:03:32 +02:00
Davide De Rosa
6c87e0a15b Use gray for profile subtitle 2022-05-15 21:03:32 +02:00
Davide De Rosa
683a8e7d82 Attempt beta release 2022-05-05 11:07:49 +02:00
Davide De Rosa
9984c56084 Drop unnecessary async from migration code 
Providers are not fetched at migration time, they only are after
opening a profile (marked non-ready until then).

Still retain Task for migration to be executed asynchronously.
 2022-05-05 11:04:12 +02:00
Davide De Rosa
15a4cc8f75 Change some icons in extra menu 
- Main icon

- Review icon
 2022-05-05 09:58:53 +02:00
Davide De Rosa
b7cccbdd0a Reorg images 2022-05-05 09:51:26 +02:00
Davide De Rosa
cca2dca047 Export providers database in beta 2022-05-05 09:46:12 +02:00
Davide De Rosa
abb23e8234 Fix missing animation loading non-ready profile 
When there is no initial active profile.
 2022-05-05 08:57:02 +02:00
Davide De Rosa
092233b546 Attempt beta release 2022-05-04 23:16:01 +02:00
Davide De Rosa
bafac12be4 Retain in beta profiles created in production 
Drop filter, ability to create profiles in the first place implies
eligibility.
 2022-05-04 23:15:12 +02:00
Davide De Rosa
c2676cbdf6 Attempt beta release 2022-05-04 19:03:22 +02:00
Davide De Rosa
40a3c67b1c Observe updates AFTER setting active profile 
App disconnects VPN on launch otherwise, because active
profile is still nil. Where was the regression introduced?

Also .dropFirst() to skip initial values, but keep in mind that
if VPN is connected and active profile was not properly persisted,
the app will show the VPN as disabled.
 2022-05-04 10:34:28 +02:00
Davide De Rosa
9e9cd018eb Revert "Enable "DNS Settings" capability" 
This reverts commit 75650b1f0a.
 2022-05-04 09:01:27 +02:00
Davide De Rosa
92caf67876 Replace dimming with different icon 2022-05-03 19:24:46 +02:00
Davide De Rosa
4cb18965c9 Set duplicate as current inside ProfileManager 
When setting duplicate as current, batch save original profile and
duplicate in a single call via profilesToSave. This is to avoid a
double call to willUpdateProfiles() when saving Core Data context.

In order to set current profile to one that has not been persisted
yet (the duplicate), we need to resort to a pendingProfiles map
where to look the duplicate up when setting currentProfileId.

Either way, iOS 14 cannot handle updating a "hot" change in a
presented NavigationLink. Changing currentProfileId binding while
in ProfileView messes up navigation completely (multiple push and
pop events). Avoid.
 2022-05-03 18:35:19 +02:00
Davide De Rosa
943bce5515 Bind navigation to ProfileManager directly 
- Do the profile loading inside the model

- Allow setting current profile to a transient profile

- Check .placeholder before saving current profile

XXX: avoid loading active profile on iPad portrait.
 2022-05-03 18:35:17 +02:00
Davide De Rosa
7036ca5f41 Fix handling of non-ready profiles 
- Omit title while isLoading, to not show former profile name

- Animate on isLoading
 2022-05-03 15:54:19 +02:00
Davide De Rosa
b9248cbb89 Animate profile removal 
Fade into WelcomeView.
 2022-05-03 15:44:47 +02:00
Davide De Rosa
ca49d8bfc6 Increase vertical padding in profile rows 2022-05-03 15:43:55 +02:00
Davide De Rosa
8230666ab2 Only use wrapping Section to fix iPad multitasking 2022-05-03 15:43:15 +02:00
Davide De Rosa
3c0e511e84 Split again OrganizerView and ProfilesList 
On iOS 14, Organizer scrolls abruptly on profile selection. It
looks like this was introduced by merging ProfilesList into
OrganizerView.

Try to revert merge to split observation responsibilities.

Drop unused AppManager in +Scene along the way.
 2022-05-03 14:40:41 +02:00
Davide De Rosa
93abaf538b Simplify redundant parts of ProfileManager 
- Drop overthought activeHeader

- Drop willUpdateCurrentProfile, use observable

- Drop willUpdateActiveId, observe value publisher
 2022-05-03 14:36:55 +02:00
Davide De Rosa
e0e3e03781 Fix missing image on iOS 14 2022-05-03 12:46:55 +02:00
Davide De Rosa
d3bd41b251 Do not blink circle while connected 2022-05-02 10:56:40 +02:00
Davide De Rosa
cc681dfeab Refine profile icons and animate if connected 
Assume 3 different profile states:

- Active and connected
- Active
- Inactive
 2022-05-02 10:48:12 +02:00
Davide De Rosa
576eb1512a Fix slow active profile selection on launch 
Regression due to missing .stack navigation style basically.

Restore .onAppear() on NavigationLink.
 2022-05-02 09:53:18 +02:00
Davide De Rosa
75650b1f0a Enable "DNS Settings" capability 
Maybe fixes #182
 2022-05-02 00:04:56 +02:00
Davide De Rosa
63c2ab6bbf Fix missing server permissions for WireGuard 
Prevented working on Catalyst.
 2022-05-02 00:03:55 +02:00
Davide De Rosa
87f2ebfd9e Attempt beta release 2022-05-01 20:44:17 +02:00
Davide De Rosa
acbc1980f9 Ignore non-existing active profile 2022-05-01 20:40:20 +02:00
Davide De Rosa
472b5e4b41 Fix active profile flickering on first launch 
Move .onAppear() handler to main view.
 2022-05-01 20:16:05 +02:00
Davide De Rosa
3571c7db35 Reduce vertical padding in profile rows 2022-05-01 20:06:03 +02:00
Davide De Rosa
14dd920ef1 Drop unused animate on appear delay 2022-05-01 19:52:33 +02:00
Davide De Rosa
48d499569b Use block versions of Section header/footer 2022-05-01 19:48:24 +02:00
Davide De Rosa
d8b19b952a Add missing translations 2022-05-01 19:34:43 +02:00
Davide De Rosa
171c1e1dd4 Omit wrapping Section on Mac 2022-05-01 19:30:56 +02:00
Davide De Rosa
cfc0d4f572 Restore active profile on top 
Flashing on activation was caused by VPNManager.disable() in
ProfileView+VPN, because by setting lastError to nil it would
notify a change to ProfileRow (via VPNStateView) during the
profile row activation animation. That caused the flicker.

Instead, disable VPN first, then start the animation.

Anyway, avoid clearing a nil lastError.
 2022-05-01 19:19:43 +02:00
Davide De Rosa
edc7cdf045 Merge List into OrganizerView 
- Restore wrapping Section as it seems to fix multitasking

- Hide profiles section if empty
 2022-05-01 19:19:31 +02:00
Davide De Rosa
8003b4a92d Observe currentProfile in ProfileView 
ProfileView is not interested in changes in other profiles
notified by ProfileManager. Set isLoading inside
ObservableObject for observable to be self-contained.

Loses observation of profile deletion, but dismiss on removal is
actually handled by OrganizerView, not ProfileView.

Also drop unused presentationMode.
 2022-05-01 19:14:34 +02:00
Davide De Rosa
9af67e12ce Drop profiles Section wrapper 2022-04-29 19:51:18 +02:00
Davide De Rosa
0047d095fb Adjust navigation style to all devices 
- Mac
    - Drop all styles
    - Tweak hide title bar
    - Hide navigation bar

- Restore single section for all profiles
    - Allows using NavigationLink safely
    - Indirectly fixes multitasking
    - Retains selection on profile activation
    - Clean up presentActiveProfile

- Leave active profile in its position
    - Fixes Mac flashing row selection on profile activation

- Unify profile row appearance
    - Use fixed .headline font
    - Add subtitles to inactive profiles
    - Use padding rather than fixed row height

CAVEATS:

- Do not preselect active profile on iPad launch, as doing so
seems to present two ProfileView on top of each other, one from
MainView and one from the NavigationLink.

- Do not touch .listStyle() of master view, as it seems to break
navigation esp. in iPad multitasking.
 2022-04-29 19:29:47 +02:00
Davide De Rosa
4d13d8bf6b Do not observe AppManager, just use for migrations 2022-04-29 18:58:07 +02:00
Davide De Rosa
fc784ffeb1 Import new translations 
3 phrases still missing.
 2022-04-28 22:47:07 +02:00
Davide De Rosa
2c2e794b00 Revert async loadCurrentProfile() 
Make action sync, but internally async (makeProfileReady). If not
doing so, UI on launch will not be able to show active profile
immediately. WelcomeView would appear for a moment.

Observe isReloadingCurrentProfile.

See 2b1efb8fec
 2022-04-28 19:00:36 +02:00
Davide De Rosa
1ef2b8c7a7 Set activeProfileId immediately 
Otherwise on app launch, active profile is rendered in 2 steps.
 2022-04-28 17:56:28 +02:00
Davide De Rosa
03cb05da7e Do not disable providers while updating index 2022-04-27 23:08:46 +02:00
Davide De Rosa
2aa4008a08 Animate profile removal 
Could only notice difference on iPad.
 2022-04-27 18:32:44 +02:00
Davide De Rosa
d4484f3307 Simplify layout of in-app products 2022-04-27 18:32:44 +02:00
Davide De Rosa
2b1efb8fec Make load*Profile() async 
- Handle Task in consumers

- Drop makeReady, always make loaded profile ready

- Rename misleading loadProfile() to profileEx()
 2022-04-27 17:13:03 +02:00
Davide De Rosa
02b2e3194e Add duplicate to profile menu 
Contextually switch current profile to duplicate.
 2022-04-27 16:59:33 +02:00
Davide De Rosa
496abc6c89 Move Siri on top of menu 2022-04-27 16:54:07 +02:00
Davide De Rosa
49a1f1b55c Address VPN toggle losing sync with internal state 
- Update TunnelKit

- Receive TunnelKit notifications on main queue

- Bind VPN toggle to VPNManager directly (implicit animations)

- Update state on VPN didFail

- Set isEnabled = false after uninstalling VPN (not notified)
 2022-04-27 15:53:31 +02:00
Davide De Rosa
e77d78526b Use non-filled icons 2022-04-27 13:40:58 +02:00
Davide De Rosa
cd854f8ebf Group profile actions into menus 
- Organizer
    - Duplicate

- Profile
    - Rename
    - Siri
    - Uninstall (+ confirmation)
    - Delete (+ confirmation)
 2022-04-27 09:53:42 +02:00
Davide De Rosa
1c047b9ce2 Retain profile name (disabled) after importing 
Works around a crash in iPadOS 14 portrait when removing section
containing first responder (profile name TextField). It happened
when submitting profile name via keyboard rather than "Save".
 2022-04-26 22:56:41 +02:00
Davide De Rosa
4a0245d757 Rename AddHostView to .NameView 
In preparation of future additions to flow.
 2022-04-26 22:44:34 +02:00
Davide De Rosa
03fdab4833 Duplicate profile from context menu 2022-04-26 22:39:47 +02:00
Davide De Rosa
1ea380312a Update providers index on add provider appearance 2022-04-26 22:15:39 +02:00
Davide De Rosa
6bff878952 Fix repeating "Default" servers in some providers 
Disambiguate by apiId.
 2022-04-26 22:12:22 +02:00
Davide De Rosa
4b8cff1bb3 Disable padding around LongContentView 
It should actually be an inset. Do it later.
 2022-04-26 21:39:21 +02:00
Davide De Rosa
99e48119f7 Encapsulate calculation of former products 
Use an interface (BuildProducts) that makes understandable and
easily extensibile how some in-app products are inferred by build
number.
 2022-04-26 20:55:18 +02:00
Davide De Rosa
f4714dec58 Fix VPN toggle enabling despite errors 2022-04-26 19:02:12 +02:00
Davide De Rosa
4973a19fda Drop unused method 2022-04-26 10:59:48 +02:00
Davide De Rosa
1ff19b331f Move VPNToggle to standalone view 2022-04-26 10:40:46 +02:00
Davide De Rosa
ccde6a30cf Fix issues with VPN toggle 
- Move rate limit to UI only

- Keep caption constant to "Enabled"
 2022-04-25 23:12:45 +02:00
Davide De Rosa
58cf401883 Share prefix for validating theme methods 2022-04-25 22:44:24 +02:00
Davide De Rosa
5c0e053e7d Review requirements of DNS over TLS (DoT) 
- Make DNS servers optional in TunnelKit

- Allow IP address as DoT server name
 2022-04-25 22:40:09 +02:00
Davide De Rosa
efb9760d6b Redo VPN toggle properly 
- Use local @State for appearance

- On binding set, control VPNManager
 2022-04-25 16:36:07 +02:00
Davide De Rosa
6434008ebd Make destructive buttons standalone 
- Uninstall VPN

- Remove profile (add to ProfileView)

Create DestructiveButton with iOS 15 .role when available.
 2022-04-25 16:34:22 +02:00
Davide De Rosa
ac1239daa8 Add headers to active/inactive profile sections 
Hide inactive section if empty.
 2022-04-25 16:34:13 +02:00
Davide De Rosa
339183c156 Fix phrase wording 2022-04-25 16:30:03 +02:00
Davide De Rosa
29629c5147 Use lighter font for non-active profiles 2022-04-25 15:35:21 +02:00
Davide De Rosa
84790080be Disable autocorrection on profile name 2022-04-25 15:28:55 +02:00
Davide De Rosa
deac70359f Reorganize and fix platform-specific fastlane data 
Reuse all iOS metadata in macOS, except the app icon.
 2022-04-25 11:21:19 +02:00
Davide De Rosa
886d0271ea Restore 'Add' button in NetworkSettings 
Makes it clear that added fields must be submitted in order to
be saved.
 2022-04-23 15:47:02 +02:00
Davide De Rosa
0b1e465143 Share animation type in theme 2022-04-23 12:11:01 +02:00
Davide De Rosa
7eb2b3bd0e Drop button accent on Organizer rows 2022-04-23 11:48:43 +02:00
Davide De Rosa
6aee88e69a Refactor theme styles 
- Hide colors behind styles

- Add "Style" suffix
 2022-04-23 11:48:43 +02:00
Davide De Rosa
dc66f514d9 Restore presentation conditions of active profile 
On iPad it's already loaded in MainView().
 2022-04-23 10:25:31 +02:00
Davide De Rosa
c507c739bd Move WelcomeView to its own view 2022-04-23 10:25:31 +02:00
Davide De Rosa
ad1539023e Split VPN status and data count 2022-04-23 10:25:31 +02:00
Davide De Rosa
1083941eeb Increase font size in Organizer 2022-04-23 10:25:31 +02:00
Davide De Rosa
4037b983cb Move active profile on top to its own section 2022-04-23 10:25:31 +02:00
Davide De Rosa
b37ff03e4b Refactor hidden navlinks and send behind in ZStack 2022-04-23 10:25:31 +02:00
Davide De Rosa
2432f0d97a Rewrite ProfileView as a view of currentProfile 
Do not load profile in View, instead:

- Load active profile on app launch

- Load selected profile on organizer selection
 2022-04-23 10:25:31 +02:00
Davide De Rosa
8838e9d130 Strip a few unnecessary publishers 
- Drop unused AppManager from OrganizerView

- Do not notify ProfileManager subscribers on activeProfileId

Saved active profile is already notified by:

- Core Data
- AppManager
 2022-04-23 10:25:31 +02:00
Davide De Rosa
d8e47cb7c0 Refactor strings and add new ones 
- Move Localizable.strings above to share *.lproj folders

- Reorg menus into contextual/system

- Shorten titles of contextual menus

- Update sharing message with WireGuard

- Drop AlternativeTo

7 phrases left to translate into 9 languages.
 2022-04-22 13:12:42 +02:00
Davide De Rosa
322bdf2993 Serialize active profile immediately 
Otherwise:

- Switch from former active profile A to B
- Connect to now active profile B
- Kill app
- Reopen app
- App shows connected to profile A

Because active profile was not saved immediately on switch.

Unnecessary now to also save it on background persist().
 2022-04-22 10:05:28 +02:00
Davide De Rosa
7095791428 Extend styles for VPN status description 2022-04-22 09:57:13 +02:00
Davide De Rosa
867b415b6b Fix double add menu in Organizer 
Seems to happen when launching with active profile.

Use explicit position.
 2022-04-22 09:52:10 +02:00
Davide De Rosa
c9dfed676e Move VPN status below active profile 
Rather than on the side. Similar to old subtitle table view cell.

Restore data count as well (when available).
 2022-04-22 09:52:10 +02:00
Davide De Rosa
46050e0141 Refactor ProfileView a little bit 
- Make welcome a computed property

- Reuse first header for consistency when loading

- Convert isDeleted to better isExisting (inverted)
 2022-04-21 19:11:22 +02:00
Davide De Rosa
fd7c232ecc Unroll ProfileView toolbar items 
Also leave them visible when disabled.
 2022-04-21 19:03:14 +02:00
Davide De Rosa
992178bcd6 Move toolbar content inline 
For consistency, can search with "toolbar {".
 2022-04-21 16:24:08 +02:00
Davide De Rosa
23d184ae08 Restore pre-scrolling in provider location 
Artifacts are caused by translucent navigation bar, also in other
views. Will fix later.
 2022-04-21 16:03:40 +02:00
Davide De Rosa
e71b22c7c8 Simplify AddProfileView with implicit animations 
- Animate on ViewModel in profile name views

- Animate on providers in provider selection view
 2022-04-21 15:24:16 +02:00
Davide De Rosa
36cd9cfd96 Revert "Explicitly hide navigation bar in WelcomeView" 
This reverts commit aefbfaa588.
 2022-04-21 14:59:56 +02:00
Davide De Rosa
ab7e6359ae Fix profile name reset to initial on error 2022-04-21 14:59:49 +02:00
Davide De Rosa
ed16617288 Fix iOS 14 not preselecting created profile 
When starting from empty profiles.
 2022-04-21 14:59:17 +02:00
Davide De Rosa
759b740d62 Simplify ProfilesList with implicit animations 
By A LOT.
 2022-04-21 14:59:17 +02:00
Davide De Rosa
0a77be6ac5 Animate shortcuts reloading as well 2022-04-21 14:59:17 +02:00
Davide De Rosa
d1c98006d3 Replace ReloadingContent with implicit animations 
Infinite loop on init(), but horrible practice in general.

- DonateView
- PaywallView+Purchase

Also show a ProgressView while rows are loading.

DO NOT animate on .products value because animation won't work
if products are empty and stay empty after refresh. Instead,
observe .isRefreshingProducts.

Lastly, to avoid annoying animation when products are actually
available, do not refresh products if non-empty. They certainly
do not change during the application lifecycle.
 2022-04-21 11:22:07 +02:00
Davide De Rosa
96b199425f Add ProgressView as overlay when possible 
Instead of replacing view entirely (GenericCreditsView).

Make replacement explicit in DebugLogView.

Basically drop View extension.
 2022-04-21 11:19:04 +02:00
Davide De Rosa
aefbfaa588 Explicitly hide navigation bar in WelcomeView 
May remain stale and empty on profile removal.
 2022-04-20 11:50:23 +02:00
Davide De Rosa
e7803fb894 Reuse logic to set Organizer headers 
Refine headers sync on profile removal.
 2022-04-20 11:50:10 +02:00
Davide De Rosa
fff391702d Use 'Save' in profile renaming 
Drop 'Done' label (unused).
 2022-04-20 11:50:10 +02:00
Davide De Rosa
dbc007b184 Restore .navigation for SettingsMenu 2022-04-19 23:20:04 +02:00
Davide De Rosa
1cfe6167e0 Use .cancellationAction placement for close button 2022-04-19 23:11:04 +02:00
Davide De Rosa
5b2ccaa110 Reposition Organizer toolbar 2022-04-19 23:02:19 +02:00
Davide De Rosa
3c2480d3b7 Rewrite ProfilesList without ReloadingContent 
Make sure to update localHeaders contextually with
removeProfiles() to avoid a second update in onChange(). The
equality check in onChange() guards against setting localHeaders
twice.

Not doing so may break animation in swipe-to-delete due to the
overlapping animations (it certainly does break on iOS 14).
 2022-04-19 22:47:06 +02:00
Davide De Rosa
17a383bc9c Redo ReloadingContent with @ObservedObject 
Proper way to listen to changes in elements is observing their
parent.
 2022-04-19 21:22:13 +02:00
Davide De Rosa
923ea923ab Fix active profile not preselected on launch 
Function called multiple times sets isFirstLaunch to true even if
not active profile.
 2022-04-19 21:19:43 +02:00
Davide De Rosa
18e9f7cbb5 Clear profile selection if current profile removed 
Do it before ForEach rearranges NavigationLink elements, because
it may trigger undesired navigation to a deleted profile.

Restore related assertion.
 2022-04-19 21:19:43 +02:00
Davide De Rosa
7128352a9c Fix settings menu not shown on iOS 14 
Change to .navigation placement.
 2022-04-19 21:19:43 +02:00
Davide De Rosa
d7ada78845 Use "standard" file extension for WireGuard 
Official app expects .conf and .zip
 2022-04-19 16:56:39 +02:00
Davide De Rosa
3f9ff50d0e Optimize Catalyst for Mac 
- Fix missing PlugIns in Catalyst build

Hence the VPN failure, there was a "iOS" filter on embed.

- Fix complaint about file access permission

Seems to need R/W when importing VPN configuration files.
 2022-04-19 16:48:42 +02:00
Davide De Rosa
063f0621c1 Unify metadata 
- Fix fastlane env variables

- Use single CHANGELOG.md in project root

- Retain old 1.x changelogs
 2022-04-19 16:17:13 +02:00
Davide De Rosa
bf65f76401 Merge project into iOS + macOS 
Share views with both platforms initially. Will split specific
views step by step.
 2022-04-19 16:14:23 +02:00
Davide De Rosa
adbc086061 Adjust eligibility conditionals to Catalyst 
- Replace os(iOS) with targetEnvironment(macCatalyst)

- Reuse same beta condition on Catalyst (must test to confirm)
 2022-04-19 15:56:41 +02:00
Davide De Rosa
f1aa192c9c Make App/Core iOS/Catalyst only 
- Drop macOS target from Package.swift

- Drop @available attributes
    - UI idiom
    - Intents API
    - Swipe actions in ProviderLocationView

- Review os(iOS)
    - DebugLog, append idiom to tell Mac from iPad

- Drop redundant canImport
 2022-04-19 15:56:41 +02:00
Davide De Rosa
2af28c158d Merge 'Views' folder 2022-04-19 10:12:52 +02:00
Davide De Rosa
20ec8d472f Add close button to modals 
Swipe down only works on iOS portrait and iPadOS.
 2022-04-19 10:10:08 +02:00
Davide De Rosa
991a283de9 Drop black title from VersionView 
Clashes with dark background.
 2022-04-19 09:52:23 +02:00
Davide De Rosa
12c6f40416 Remove ScrollViewReader preventing favorites reload 
Content inside ScrollViewReader does not seem to be reload on
favorites toggle, for reasons I will review later. No big deal as
scrolling was already disabled.
 2022-04-19 09:16:04 +02:00
Davide De Rosa
ab0a2c8cb4 Reuse provider availability idea from 5d85699 2022-04-19 09:03:41 +02:00
Davide De Rosa
480738d126 Make shortcuts contextual in ProfileView 
- Add toolbar item

- Target current profile

- Only list relevant shortcuts to profile
 2022-04-19 08:41:07 +02:00
Davide De Rosa
b1882dcf80 Preselect profile on NavigationLink appearance 
More accurate than ForEach and maybe the only right place.
 2022-04-19 08:39:34 +02:00
Davide De Rosa
5d85699ce4 Delete profile from Organizer 
Swipe to delete. Address a couple things on iPad though:

1. Also check provider availability before showing view

fatalError hit on iPad when navigating from a ready provider
profile to a non-ready one. Similar to when navigating between
different VPN protocols.

2. Suppress assertion on deleted profile

Deleting current profile via swipe seems to re-render a new
NavigationLink with the deleted profile, which results in
loading a deleted profile and hitting the assertion. Not sure if
this is a programming error or a glitch in ForEach.
 2022-04-19 08:38:10 +02:00
Davide De Rosa
18161ed1f1 Group Organizer modals into toolbar menus 
- Drop status / navigation bars colors

- Restore large title on iPad

- Overlay organizer with "No profiles" when empty

- Uninstall VPN from ProfileView
 2022-04-19 08:38:10 +02:00
Davide De Rosa
6533a6beae Disable pre-scrolling in location 
May reveal artifacts in translucent navigation bar.
 2022-04-18 19:51:50 +02:00
Davide De Rosa
017182fe81 Rewrite ReloadingSection to be semantic only 
Use Group instead of Section. Also fix elements not loading if
initially empty.
 2022-04-18 19:51:28 +02:00
Davide De Rosa
f5c87d43c2 Better observe updates explicitly after init 2022-04-18 19:51:07 +02:00
Davide De Rosa
0db3e36bf4 Make network settings consistent 
- Group DNS "Enabled" and protocol into configuration

- Make DNS servers / search domains optional

- Make proxy bypass domains optional

Also refine a comment about future on-demand.
 2022-04-14 07:43:44 +02:00
Davide De Rosa
2565b9f3d0 Lock network settings for builds >= 3000 2022-04-13 21:25:24 +02:00
Davide De Rosa
320513dd38 Dismiss paywall predictably with Binding<Bool> 2022-04-13 21:24:38 +02:00
Davide De Rosa
e7a5d82056 Restore purchases without refreshing receipt first 
Any reason why I was doing that?

Also drop old ProductManager notification.
 2022-04-13 21:24:09 +02:00
Davide De Rosa
0849fe6cc7 Attempt beta release 2022-04-13 19:49:58 +02:00
Davide De Rosa
ad38ca5942 Skip bypass domains for proxy configured with PAC 2022-04-13 19:45:27 +02:00
Davide De Rosa
5874ce4b9d Attempt beta release 2022-04-13 19:40:18 +02:00
Davide De Rosa
addbc181fd Make proxy configuration a 3-state 
- Manual: server, port
- PAC: set PAC URL
- Disabled

BEWARE: breaking change in Profile.
 2022-04-13 19:38:36 +02:00
Davide De Rosa
9055fec394 Fix on-demand rules dropped completely 
Must only ignore custom rules if ineligible.
 2022-04-13 19:12:16 +02:00
Davide De Rosa
8026caa5ef Attempt beta release 2022-04-13 11:20:21 +02:00
Davide De Rosa
4a047ece58 Fix OpenVPN endpoint view not handling UDP4/TCP4 2022-04-13 11:10:33 +02:00
Davide De Rosa
c7f7dd89a1 Attempt beta release 
Update script.
 2022-04-13 10:16:43 +02:00
Davide De Rosa
56fcee98b4 Handle long fields in OpenVPN configuration 
- Use long content for IP settings

- Copy on tap DNS/proxy settings
 2022-04-13 10:13:25 +02:00
Davide De Rosa
1532e8808b [ci skip] Address CI and ASC validation issues 
- Skip tests until fixed wg-go issue

- Add golang step

- Set "Apple Development" at project level

- Set Catalyst platform for gym

- Drop TARGET env variable clashing with WireGuardKit

- Disable SwiftGen script phase

- Fix TunnelKit segfault on archive

- Xcode 13.2.1 compatibility
    Fix some issues with @MainActor
    Use #available instead of #unavailable

- Raise timeout from 10 to 15 minutes

- Update beta description

- Tunnel bundle ids cannot have periods

- CFBundleDisplayName required in tunnels
 2022-04-13 10:00:29 +02:00
Davide De Rosa
926d73fc8a Refine CHANGELOG with issues references 2022-04-12 18:33:27 +02:00
Davide De Rosa
4aba5f46aa Rewrite app in SwiftUI 2022-04-12 15:12:45 +02:00
Davide De Rosa
2c9be6334a [ci skip] Set release date 2022-02-15 09:09:28 +01:00
Davide De Rosa
8f16bf376d Attempt beta release 
Fix naive compile issue.
 2022-02-04 14:18:01 +01:00
Davide De Rosa
e38a2598e2 Attempt beta release 2022-02-04 13:11:01 +01:00
Davide De Rosa
0daed83a14 Update copyright 2022-02-04 12:44:30 +01:00
Davide De Rosa
3c2966c836 Attempt beta release 2022-02-04 12:27:28 +01:00
Davide De Rosa
31361bf0d8 Attempt beta release 2022-02-04 12:19:18 +01:00
Davide De Rosa
2ab709401f Trim whitespaces in text fields 2022-02-04 12:18:44 +01:00
Davide De Rosa
72044a5e41 Fix globbing in "Run Script" phases 
See 549cd17dbd
 2022-01-07 21:55:56 +01:00
Davide De Rosa
4c673338b7 Attempt beta release 2022-01-07 19:00:33 +01:00
Davide De Rosa
d55fb5dc0f Attempt beta release 2022-01-04 09:26:55 +01:00
Davide De Rosa
9ecb90b8f9 Handle --keepalive option 2022-01-04 09:25:13 +01:00
Davide De Rosa
ff9dc3f340 Remove URL from CHANGELOG 2021-12-17 14:47:45 +01:00
Davide De Rosa
05a460d55f Attempt beta release 2021-12-08 16:11:38 +01:00
Davide De Rosa
4f9bbac178 Attempt beta release 2021-12-04 11:53:51 +01:00
Davide De Rosa
97c6a6f356 Attempt beta release 2021-12-03 15:35:44 +01:00
Davide De Rosa
2a5c231d3d
Polish release workflow (#207) 
* Do run tests in beta

- Test and build app in same lane
- Run tests with swift directly
- Set timeout on build only
- Set GYM_OUTPUT_DIRECTORY inline
- Fix bad build number, broken in db075eb
- Ignore updates to CHANGELOG for testing
- Drop unnecessary exports
- Drop unnecessary test env
- Drop unused PLATFORM .env.* variable

* Work around gym issues in CI

- Set custom build paths for proper clean-up
- Disable xcpretty (seems to hang job)

* Add descriptive names to workflow

- Rename beta to release
- Add job names

* Optimize release workflow

- Use a matrix for multiplatform build
- Only preinstall platform-specific certificates
- Output app version/build early for job reuse
- Do not depend app review on public beta release
- Pull latest commits before pushing/tagging

In release, ci/* scripts require Ruby. Make version an argument
of the commit-release.sh script to fix dependency.

* Import secret to notify external testers or not

* [ci skip] Add CHANGELOG preface in local scripts

* [ci skip] Update links to release via CI
 2021-12-03 15:31:19 +01:00
Davide De Rosa
82aaa0b386 Attempt beta release 2021-11-30 16:40:28 +01:00
Davide De Rosa
6d541284a5 Attempt beta release 2021-11-30 12:49:46 +01:00
Davide De Rosa
6d74f06e97 Reload hierarchy on "Refresh infrastructure" 
Date was not refreshed either.
 2021-11-30 10:51:06 +01:00
Davide De Rosa
9df4630254 Bump version 2021-11-30 10:04:05 +01:00
Davide De Rosa
5580dd6901 [ci skip] Set release date 2021-11-30 10:00:07 +01:00
Davide De Rosa
51821660d2 Commit build number with beta 
Pick base build number from env, not project. Can now drop
fetch-depth 0 from workflow, no needs for commits count.
 2021-11-29 19:06:59 +01:00
Davide De Rosa
b00a7a8ade Set beta release 2021-11-27 12:43:19 +01:00
Davide De Rosa
f1009075ab Fix compile error on IntentDispatcher 2021-11-27 12:39:35 +01:00
Davide De Rosa
cb3c2401c7 Fix newer infrastructure discarded over bundle 2021-11-27 12:39:35 +01:00