Commit Graph

766 Commits

Author SHA1 Message Date
Davide De Rosa 867b415b6b Fix double add menu in Organizer
Seems to happen when launching with active profile.

Use explicit position.
2022-04-22 09:52:10 +02:00
Davide De Rosa c9dfed676e Move VPN status below active profile
Rather than on the side. Similar to old subtitle table view cell.

Restore data count as well (when available).
2022-04-22 09:52:10 +02:00
Davide De Rosa 46050e0141 Refactor ProfileView a little bit
- Make welcome a computed property

- Reuse first header for consistency when loading

- Convert isDeleted to better isExisting (inverted)
2022-04-21 19:11:22 +02:00
Davide De Rosa fd7c232ecc Unroll ProfileView toolbar items
Also leave them visible when disabled.
2022-04-21 19:03:14 +02:00
Davide De Rosa 992178bcd6 Move toolbar content inline
For consistency, can search with "toolbar {".
2022-04-21 16:24:08 +02:00
Davide De Rosa 23d184ae08 Restore pre-scrolling in provider location
Artifacts are caused by translucent navigation bar, also in other
views. Will fix later.
2022-04-21 16:03:40 +02:00
Davide De Rosa e71b22c7c8 Simplify AddProfileView with implicit animations
- Animate on ViewModel in profile name views

- Animate on providers in provider selection view
2022-04-21 15:24:16 +02:00
Davide De Rosa 36cd9cfd96 Revert "Explicitly hide navigation bar in WelcomeView"
This reverts commit aefbfaa588.
2022-04-21 14:59:56 +02:00
Davide De Rosa ab7e6359ae Fix profile name reset to initial on error 2022-04-21 14:59:49 +02:00
Davide De Rosa ed16617288 Fix iOS 14 not preselecting created profile
When starting from empty profiles.
2022-04-21 14:59:17 +02:00
Davide De Rosa 759b740d62 Simplify ProfilesList with implicit animations
By A LOT.
2022-04-21 14:59:17 +02:00
Davide De Rosa 0a77be6ac5 Animate shortcuts reloading as well 2022-04-21 14:59:17 +02:00
Davide De Rosa d1c98006d3 Replace ReloadingContent with implicit animations
Infinite loop on init(), but horrible practice in general.

- DonateView
- PaywallView+Purchase

Also show a ProgressView while rows are loading.

DO NOT animate on .products value because animation won't work
if products are empty and stay empty after refresh. Instead,
observe .isRefreshingProducts.

Lastly, to avoid annoying animation when products are actually
available, do not refresh products if non-empty. They certainly
do not change during the application lifecycle.
2022-04-21 11:22:07 +02:00
Davide De Rosa 96b199425f Add ProgressView as overlay when possible
Instead of replacing view entirely (GenericCreditsView).

Make replacement explicit in DebugLogView.

Basically drop View extension.
2022-04-21 11:19:04 +02:00
Davide De Rosa aefbfaa588 Explicitly hide navigation bar in WelcomeView
May remain stale and empty on profile removal.
2022-04-20 11:50:23 +02:00
Davide De Rosa e7803fb894 Reuse logic to set Organizer headers
Refine headers sync on profile removal.
2022-04-20 11:50:10 +02:00
Davide De Rosa fff391702d Use 'Save' in profile renaming
Drop 'Done' label (unused).
2022-04-20 11:50:10 +02:00
Davide De Rosa dbc007b184 Restore .navigation for SettingsMenu 2022-04-19 23:20:04 +02:00
Davide De Rosa 1cfe6167e0 Use .cancellationAction placement for close button 2022-04-19 23:11:04 +02:00
Davide De Rosa 5b2ccaa110 Reposition Organizer toolbar 2022-04-19 23:02:19 +02:00
Davide De Rosa 3c2480d3b7 Rewrite ProfilesList without ReloadingContent
Make sure to update localHeaders contextually with
removeProfiles() to avoid a second update in onChange(). The
equality check in onChange() guards against setting localHeaders
twice.

Not doing so may break animation in swipe-to-delete due to the
overlapping animations (it certainly does break on iOS 14).
2022-04-19 22:47:06 +02:00
Davide De Rosa 17a383bc9c Redo ReloadingContent with @ObservedObject
Proper way to listen to changes in elements is observing their
parent.
2022-04-19 21:22:13 +02:00
Davide De Rosa 923ea923ab Fix active profile not preselected on launch
Function called multiple times sets isFirstLaunch to true even if
not active profile.
2022-04-19 21:19:43 +02:00
Davide De Rosa 18e9f7cbb5 Clear profile selection if current profile removed
Do it before ForEach rearranges NavigationLink elements, because
it may trigger undesired navigation to a deleted profile.

Restore related assertion.
2022-04-19 21:19:43 +02:00
Davide De Rosa 7128352a9c Fix settings menu not shown on iOS 14
Change to .navigation placement.
2022-04-19 21:19:43 +02:00
Davide De Rosa d7ada78845 Use "standard" file extension for WireGuard
Official app expects .conf and .zip
2022-04-19 16:56:39 +02:00
Davide De Rosa 3f9ff50d0e Optimize Catalyst for Mac
- Fix missing PlugIns in Catalyst build

Hence the VPN failure, there was a "iOS" filter on embed.

- Fix complaint about file access permission

Seems to need R/W when importing VPN configuration files.
2022-04-19 16:48:42 +02:00
Davide De Rosa 063f0621c1 Unify metadata
- Fix fastlane env variables

- Use single CHANGELOG.md in project root

- Retain old 1.x changelogs
2022-04-19 16:17:13 +02:00
Davide De Rosa bf65f76401 Merge project into iOS + macOS
Share views with both platforms initially. Will split specific
views step by step.
2022-04-19 16:14:23 +02:00
Davide De Rosa adbc086061 Adjust eligibility conditionals to Catalyst
- Replace os(iOS) with targetEnvironment(macCatalyst)

- Reuse same beta condition on Catalyst (must test to confirm)
2022-04-19 15:56:41 +02:00
Davide De Rosa f1aa192c9c Make App/Core iOS/Catalyst only
- Drop macOS target from Package.swift

- Drop @available attributes
    - UI idiom
    - Intents API
    - Swipe actions in ProviderLocationView

- Review os(iOS)
    - DebugLog, append idiom to tell Mac from iPad

- Drop redundant canImport
2022-04-19 15:56:41 +02:00
Davide De Rosa 2af28c158d Merge 'Views' folder 2022-04-19 10:12:52 +02:00
Davide De Rosa 20ec8d472f Add close button to modals
Swipe down only works on iOS portrait and iPadOS.
2022-04-19 10:10:08 +02:00
Davide De Rosa 991a283de9 Drop black title from VersionView
Clashes with dark background.
2022-04-19 09:52:23 +02:00
Davide De Rosa 12c6f40416 Remove ScrollViewReader preventing favorites reload
Content inside ScrollViewReader does not seem to be reload on
favorites toggle, for reasons I will review later. No big deal as
scrolling was already disabled.
2022-04-19 09:16:04 +02:00
Davide De Rosa ab0a2c8cb4 Reuse provider availability idea from 5d85699 2022-04-19 09:03:41 +02:00
Davide De Rosa 480738d126 Make shortcuts contextual in ProfileView
- Add toolbar item

- Target current profile

- Only list relevant shortcuts to profile
2022-04-19 08:41:07 +02:00
Davide De Rosa b1882dcf80 Preselect profile on NavigationLink appearance
More accurate than ForEach and maybe the only right place.
2022-04-19 08:39:34 +02:00
Davide De Rosa 5d85699ce4 Delete profile from Organizer
Swipe to delete. Address a couple things on iPad though:

1. Also check provider availability before showing view

fatalError hit on iPad when navigating from a ready provider
profile to a non-ready one. Similar to when navigating between
different VPN protocols.

2. Suppress assertion on deleted profile

Deleting current profile via swipe seems to re-render a new
NavigationLink with the deleted profile, which results in
loading a deleted profile and hitting the assertion. Not sure if
this is a programming error or a glitch in ForEach.
2022-04-19 08:38:10 +02:00
Davide De Rosa 18161ed1f1 Group Organizer modals into toolbar menus
- Drop status / navigation bars colors

- Restore large title on iPad

- Overlay organizer with "No profiles" when empty

- Uninstall VPN from ProfileView
2022-04-19 08:38:10 +02:00
Davide De Rosa 6533a6beae Disable pre-scrolling in location
May reveal artifacts in translucent navigation bar.
2022-04-18 19:51:50 +02:00
Davide De Rosa 017182fe81 Rewrite ReloadingSection to be semantic only
Use Group instead of Section. Also fix elements not loading if
initially empty.
2022-04-18 19:51:28 +02:00
Davide De Rosa f5c87d43c2 Better observe updates explicitly after init 2022-04-18 19:51:07 +02:00
Davide De Rosa 0db3e36bf4 Make network settings consistent
- Group DNS "Enabled" and protocol into configuration

- Make DNS servers / search domains optional

- Make proxy bypass domains optional

Also refine a comment about future on-demand.
2022-04-14 07:43:44 +02:00
Davide De Rosa 2565b9f3d0 Lock network settings for builds >= 3000 2022-04-13 21:25:24 +02:00
Davide De Rosa 320513dd38 Dismiss paywall predictably with Binding<Bool> 2022-04-13 21:24:38 +02:00
Davide De Rosa e7a5d82056 Restore purchases without refreshing receipt first
Any reason why I was doing that?

Also drop old ProductManager notification.
2022-04-13 21:24:09 +02:00
Davide De Rosa 0849fe6cc7 Attempt beta release 2022-04-13 19:49:58 +02:00
Davide De Rosa ad38ca5942 Skip bypass domains for proxy configured with PAC 2022-04-13 19:45:27 +02:00
Davide De Rosa 5874ce4b9d Attempt beta release 2022-04-13 19:40:18 +02:00
Davide De Rosa addbc181fd Make proxy configuration a 3-state
- Manual: server, port
- PAC: set PAC URL
- Disabled

BEWARE: breaking change in Profile.
2022-04-13 19:38:36 +02:00
Davide De Rosa 9055fec394 Fix on-demand rules dropped completely
Must only ignore custom rules if ineligible.
2022-04-13 19:12:16 +02:00
Davide De Rosa 8026caa5ef Attempt beta release 2022-04-13 11:20:21 +02:00
Davide De Rosa 4a047ece58 Fix OpenVPN endpoint view not handling UDP4/TCP4 2022-04-13 11:10:33 +02:00
Davide De Rosa c7f7dd89a1 Attempt beta release
Update script.
2022-04-13 10:16:43 +02:00
Davide De Rosa 56fcee98b4 Handle long fields in OpenVPN configuration
- Use long content for IP settings

- Copy on tap DNS/proxy settings
2022-04-13 10:13:25 +02:00
Davide De Rosa 1532e8808b [ci skip] Address CI and ASC validation issues
- Skip tests until fixed wg-go issue

- Add golang step

- Set "Apple Development" at project level

- Set Catalyst platform for gym

- Drop TARGET env variable clashing with WireGuardKit

- Disable SwiftGen script phase

- Fix TunnelKit segfault on archive

- Xcode 13.2.1 compatibility
    Fix some issues with @MainActor
    Use #available instead of #unavailable

- Raise timeout from 10 to 15 minutes

- Update beta description

- Tunnel bundle ids cannot have periods

- CFBundleDisplayName required in tunnels
2022-04-13 10:00:29 +02:00
Davide De Rosa 926d73fc8a Refine CHANGELOG with issues references 2022-04-12 18:33:27 +02:00
Davide De Rosa 4aba5f46aa Rewrite app in SwiftUI 2022-04-12 15:12:45 +02:00
Davide De Rosa 2c9be6334a [ci skip] Set release date 2022-02-15 09:09:28 +01:00
Davide De Rosa 8f16bf376d Attempt beta release
Fix naive compile issue.
2022-02-04 14:18:01 +01:00
Davide De Rosa e38a2598e2 Attempt beta release 2022-02-04 13:11:01 +01:00
Davide De Rosa 0daed83a14 Update copyright 2022-02-04 12:44:30 +01:00
Davide De Rosa 3c2966c836 Attempt beta release 2022-02-04 12:27:28 +01:00
Davide De Rosa 31361bf0d8 Attempt beta release 2022-02-04 12:19:18 +01:00
Davide De Rosa 2ab709401f Trim whitespaces in text fields 2022-02-04 12:18:44 +01:00
Davide De Rosa 72044a5e41 Fix globbing in "Run Script" phases
See 549cd17dbd
2022-01-07 21:55:56 +01:00
Davide De Rosa 4c673338b7 Attempt beta release 2022-01-07 19:00:33 +01:00
Davide De Rosa d55fb5dc0f Attempt beta release 2022-01-04 09:26:55 +01:00
Davide De Rosa 9ecb90b8f9 Handle --keepalive option 2022-01-04 09:25:13 +01:00
Davide De Rosa ff9dc3f340 Remove URL from CHANGELOG 2021-12-17 14:47:45 +01:00
Davide De Rosa 05a460d55f Attempt beta release 2021-12-08 16:11:38 +01:00
Davide De Rosa 4f9bbac178 Attempt beta release 2021-12-04 11:53:51 +01:00
Davide De Rosa 97c6a6f356 Attempt beta release 2021-12-03 15:35:44 +01:00
Davide De Rosa 2a5c231d3d
Polish release workflow (#207)
* Do run tests in beta

- Test and build app in same lane
- Run tests with swift directly
- Set timeout on build only
- Set GYM_OUTPUT_DIRECTORY inline
- Fix bad build number, broken in db075eb
- Ignore updates to CHANGELOG for testing
- Drop unnecessary exports
- Drop unnecessary test env
- Drop unused PLATFORM .env.* variable

* Work around gym issues in CI

- Set custom build paths for proper clean-up
- Disable xcpretty (seems to hang job)

* Add descriptive names to workflow

- Rename beta to release
- Add job names

* Optimize release workflow

- Use a matrix for multiplatform build
- Only preinstall platform-specific certificates
- Output app version/build early for job reuse
- Do not depend app review on public beta release
- Pull latest commits before pushing/tagging

In release, ci/* scripts require Ruby. Make version an argument
of the commit-release.sh script to fix dependency.

* Import secret to notify external testers or not

* [ci skip] Add CHANGELOG preface in local scripts

* [ci skip] Update links to release via CI
2021-12-03 15:31:19 +01:00
Davide De Rosa 82aaa0b386 Attempt beta release 2021-11-30 16:40:28 +01:00
Davide De Rosa 6d541284a5 Attempt beta release 2021-11-30 12:49:46 +01:00
Davide De Rosa 6d74f06e97 Reload hierarchy on "Refresh infrastructure"
Date was not refreshed either.
2021-11-30 10:51:06 +01:00
Davide De Rosa 9df4630254 Bump version 2021-11-30 10:04:05 +01:00
Davide De Rosa 5580dd6901 [ci skip] Set release date 2021-11-30 10:00:07 +01:00
Davide De Rosa 51821660d2 Commit build number with beta
Pick base build number from env, not project. Can now drop
fetch-depth 0 from workflow, no needs for commits count.
2021-11-29 19:06:59 +01:00
Davide De Rosa b00a7a8ade Set beta release 2021-11-27 12:43:19 +01:00
Davide De Rosa f1009075ab Fix compile error on IntentDispatcher 2021-11-27 12:39:35 +01:00
Davide De Rosa cb3c2401c7 Fix newer infrastructure discarded over bundle 2021-11-27 12:39:35 +01:00
Davide De Rosa b5ca84f54e Set beta release 2021-11-25 13:55:40 +01:00
Davide De Rosa d045406bdb Set beta release 2021-11-25 12:27:27 +01:00
Davide De Rosa d07809a135 Add details on "TLS failed" issue 2021-11-25 12:26:53 +01:00
Davide De Rosa 104c856e45 Fix PEM caching PR in TunnelKit 2021-11-25 12:23:28 +01:00
Davide De Rosa fc4401571b Set beta release 2021-11-24 17:05:20 +01:00
Davide De Rosa 46fef91f5c Revert to TunnelKit with OpenSSL
- Remove extra "Frameworks" in .appex
- Restore TLS security level 0
- Disable Bitcode for OpenSSL to link properly
2021-11-24 17:03:41 +01:00
Davide De Rosa f0020dfba6 Bump version 2021-11-19 17:31:29 +01:00
Davide De Rosa fd529752ee Revert iOS target to 12
TunnelKit only requires 12.
2021-11-18 13:10:44 +01:00
Davide De Rosa f9ab445759 Set beta release 2021-11-18 12:22:02 +01:00
Davide De Rosa 1f0b16f42f Bump version 2021-11-18 12:21:36 +01:00
Davide De Rosa 9338f59f18 Revert PEM caching in TunnelKit 2021-11-18 12:15:21 +01:00
Davide De Rosa 2f1f61e414 Drop removed providers 2021-11-16 13:38:48 +01:00
Davide De Rosa 0754a0f199 Set release date 2021-11-16 12:55:17 +01:00
Davide De Rosa c8f351934c Set beta release 2021-11-14 19:42:14 +01:00
Davide De Rosa b3de7f3a73 Bump build 2021-11-14 19:41:07 +01:00
Davide De Rosa 0b65ed4385 Set beta release 2021-11-12 10:31:13 +01:00