Commit Graph

43 Commits

Author SHA1 Message Date
Davide De Rosa
ac1239daa8 Add headers to active/inactive profile sections
Hide inactive section if empty.
2022-04-25 16:34:13 +02:00
Davide De Rosa
29629c5147 Use lighter font for non-active profiles 2022-04-25 15:35:21 +02:00
Davide De Rosa
84790080be Disable autocorrection on profile name 2022-04-25 15:28:55 +02:00
Davide De Rosa
886d0271ea Restore 'Add' button in NetworkSettings
Makes it clear that added fields must be submitted in order to
be saved.
2022-04-23 15:47:02 +02:00
Davide De Rosa
0b1e465143 Share animation type in theme 2022-04-23 12:11:01 +02:00
Davide De Rosa
7eb2b3bd0e Drop button accent on Organizer rows 2022-04-23 11:48:43 +02:00
Davide De Rosa
6aee88e69a Refactor theme styles
- Hide colors behind styles

- Add "Style" suffix
2022-04-23 11:48:43 +02:00
Davide De Rosa
dc66f514d9 Restore presentation conditions of active profile
On iPad it's already loaded in MainView().
2022-04-23 10:25:31 +02:00
Davide De Rosa
c507c739bd Move WelcomeView to its own view 2022-04-23 10:25:31 +02:00
Davide De Rosa
ad1539023e Split VPN status and data count 2022-04-23 10:25:31 +02:00
Davide De Rosa
1083941eeb Increase font size in Organizer 2022-04-23 10:25:31 +02:00
Davide De Rosa
4037b983cb Move active profile on top to its own section 2022-04-23 10:25:31 +02:00
Davide De Rosa
b37ff03e4b Refactor hidden navlinks and send behind in ZStack 2022-04-23 10:25:31 +02:00
Davide De Rosa
2432f0d97a Rewrite ProfileView as a view of currentProfile
Do not load profile in View, instead:

- Load active profile on app launch

- Load selected profile on organizer selection
2022-04-23 10:25:31 +02:00
Davide De Rosa
8838e9d130 Strip a few unnecessary publishers
- Drop unused AppManager from OrganizerView

- Do not notify ProfileManager subscribers on activeProfileId

Saved active profile is already notified by:

- Core Data
- AppManager
2022-04-23 10:25:31 +02:00
Davide De Rosa
d8e47cb7c0 Refactor strings and add new ones
- Move Localizable.strings above to share *.lproj folders

- Reorg menus into contextual/system

- Shorten titles of contextual menus

- Update sharing message with WireGuard

- Drop AlternativeTo

7 phrases left to translate into 9 languages.
2022-04-22 13:12:42 +02:00
Davide De Rosa
322bdf2993 Serialize active profile immediately
Otherwise:

- Switch from former active profile A to B
- Connect to now active profile B
- Kill app
- Reopen app
- App shows connected to profile A

Because active profile was not saved immediately on switch.

Unnecessary now to also save it on background persist().
2022-04-22 10:05:28 +02:00
Davide De Rosa
7095791428 Extend styles for VPN status description 2022-04-22 09:57:13 +02:00
Davide De Rosa
867b415b6b Fix double add menu in Organizer
Seems to happen when launching with active profile.

Use explicit position.
2022-04-22 09:52:10 +02:00
Davide De Rosa
c9dfed676e Move VPN status below active profile
Rather than on the side. Similar to old subtitle table view cell.

Restore data count as well (when available).
2022-04-22 09:52:10 +02:00
Davide De Rosa
46050e0141 Refactor ProfileView a little bit
- Make welcome a computed property

- Reuse first header for consistency when loading

- Convert isDeleted to better isExisting (inverted)
2022-04-21 19:11:22 +02:00
Davide De Rosa
fd7c232ecc Unroll ProfileView toolbar items
Also leave them visible when disabled.
2022-04-21 19:03:14 +02:00
Davide De Rosa
992178bcd6 Move toolbar content inline
For consistency, can search with "toolbar {".
2022-04-21 16:24:08 +02:00
Davide De Rosa
23d184ae08 Restore pre-scrolling in provider location
Artifacts are caused by translucent navigation bar, also in other
views. Will fix later.
2022-04-21 16:03:40 +02:00
Davide De Rosa
e71b22c7c8 Simplify AddProfileView with implicit animations
- Animate on ViewModel in profile name views

- Animate on providers in provider selection view
2022-04-21 15:24:16 +02:00
Davide De Rosa
36cd9cfd96 Revert "Explicitly hide navigation bar in WelcomeView"
This reverts commit aefbfaa588.
2022-04-21 14:59:56 +02:00
Davide De Rosa
ab7e6359ae Fix profile name reset to initial on error 2022-04-21 14:59:49 +02:00
Davide De Rosa
ed16617288 Fix iOS 14 not preselecting created profile
When starting from empty profiles.
2022-04-21 14:59:17 +02:00
Davide De Rosa
759b740d62 Simplify ProfilesList with implicit animations
By A LOT.
2022-04-21 14:59:17 +02:00
Davide De Rosa
0a77be6ac5 Animate shortcuts reloading as well 2022-04-21 14:59:17 +02:00
Davide De Rosa
d1c98006d3 Replace ReloadingContent with implicit animations
Infinite loop on init(), but horrible practice in general.

- DonateView
- PaywallView+Purchase

Also show a ProgressView while rows are loading.

DO NOT animate on .products value because animation won't work
if products are empty and stay empty after refresh. Instead,
observe .isRefreshingProducts.

Lastly, to avoid annoying animation when products are actually
available, do not refresh products if non-empty. They certainly
do not change during the application lifecycle.
2022-04-21 11:22:07 +02:00
Davide De Rosa
96b199425f Add ProgressView as overlay when possible
Instead of replacing view entirely (GenericCreditsView).

Make replacement explicit in DebugLogView.

Basically drop View extension.
2022-04-21 11:19:04 +02:00
Davide De Rosa
aefbfaa588 Explicitly hide navigation bar in WelcomeView
May remain stale and empty on profile removal.
2022-04-20 11:50:23 +02:00
Davide De Rosa
e7803fb894 Reuse logic to set Organizer headers
Refine headers sync on profile removal.
2022-04-20 11:50:10 +02:00
Davide De Rosa
fff391702d Use 'Save' in profile renaming
Drop 'Done' label (unused).
2022-04-20 11:50:10 +02:00
Davide De Rosa
dbc007b184 Restore .navigation for SettingsMenu 2022-04-19 23:20:04 +02:00
Davide De Rosa
5b2ccaa110 Reposition Organizer toolbar 2022-04-19 23:02:19 +02:00
Davide De Rosa
3c2480d3b7 Rewrite ProfilesList without ReloadingContent
Make sure to update localHeaders contextually with
removeProfiles() to avoid a second update in onChange(). The
equality check in onChange() guards against setting localHeaders
twice.

Not doing so may break animation in swipe-to-delete due to the
overlapping animations (it certainly does break on iOS 14).
2022-04-19 22:47:06 +02:00
Davide De Rosa
17a383bc9c Redo ReloadingContent with @ObservedObject
Proper way to listen to changes in elements is observing their
parent.
2022-04-19 21:22:13 +02:00
Davide De Rosa
923ea923ab Fix active profile not preselected on launch
Function called multiple times sets isFirstLaunch to true even if
not active profile.
2022-04-19 21:19:43 +02:00
Davide De Rosa
18e9f7cbb5 Clear profile selection if current profile removed
Do it before ForEach rearranges NavigationLink elements, because
it may trigger undesired navigation to a deleted profile.

Restore related assertion.
2022-04-19 21:19:43 +02:00
Davide De Rosa
7128352a9c Fix settings menu not shown on iOS 14
Change to .navigation placement.
2022-04-19 21:19:43 +02:00
Davide De Rosa
bf65f76401 Merge project into iOS + macOS
Share views with both platforms initially. Will split specific
views step by step.
2022-04-19 16:14:23 +02:00