46050e0141
Refactor ProfileView a little bit
...
- Make welcome a computed property
- Reuse first header for consistency when loading
- Convert isDeleted to better isExisting (inverted)
2022-04-21 19:11:22 +02:00
fd7c232ecc
Unroll ProfileView toolbar items
...
Also leave them visible when disabled.
2022-04-21 19:03:14 +02:00
992178bcd6
Move toolbar content inline
...
For consistency, can search with "toolbar {".
2022-04-21 16:24:08 +02:00
23d184ae08
Restore pre-scrolling in provider location
...
Artifacts are caused by translucent navigation bar, also in other
views. Will fix later.
2022-04-21 16:03:40 +02:00
e71b22c7c8
Simplify AddProfileView with implicit animations
...
- Animate on ViewModel in profile name views
- Animate on providers in provider selection view
2022-04-21 15:24:16 +02:00
36cd9cfd96
Revert "Explicitly hide navigation bar in WelcomeView"
...
This reverts commit aefbfaa588
2022-04-21 14:59:56 +02:00
ab7e6359ae
Fix profile name reset to initial on error
2022-04-21 14:59:49 +02:00
ed16617288
Fix iOS 14 not preselecting created profile
...
When starting from empty profiles.
2022-04-21 14:59:17 +02:00
759b740d62
Simplify ProfilesList with implicit animations
...
By A LOT.
2022-04-21 14:59:17 +02:00
0a77be6ac5
Animate shortcuts reloading as well
2022-04-21 14:59:17 +02:00
d1c98006d3
Replace ReloadingContent with implicit animations
...
Infinite loop on init(), but horrible practice in general.
- DonateView
- PaywallView+Purchase
Also show a ProgressView while rows are loading.
DO NOT animate on .products value because animation won't work
if products are empty and stay empty after refresh. Instead,
observe .isRefreshingProducts.
Lastly, to avoid annoying animation when products are actually
available, do not refresh products if non-empty. They certainly
do not change during the application lifecycle.
2022-04-21 11:22:07 +02:00
96b199425f
Add ProgressView as overlay when possible
...
Instead of replacing view entirely (GenericCreditsView).
Make replacement explicit in DebugLogView.
Basically drop View extension.
2022-04-21 11:19:04 +02:00
aefbfaa588
Explicitly hide navigation bar in WelcomeView
...
May remain stale and empty on profile removal.
2022-04-20 11:50:23 +02:00
e7803fb894
Reuse logic to set Organizer headers
...
Refine headers sync on profile removal.
2022-04-20 11:50:10 +02:00
fff391702d
Use 'Save' in profile renaming
...
Drop 'Done' label (unused).
2022-04-20 11:50:10 +02:00
dbc007b184
Restore .navigation for SettingsMenu
2022-04-19 23:20:04 +02:00
5b2ccaa110
Reposition Organizer toolbar
2022-04-19 23:02:19 +02:00
3c2480d3b7
Rewrite ProfilesList without ReloadingContent
...
Make sure to update localHeaders contextually with
removeProfiles() to avoid a second update in onChange(). The
equality check in onChange() guards against setting localHeaders
twice.
Not doing so may break animation in swipe-to-delete due to the
overlapping animations (it certainly does break on iOS 14).
2022-04-19 22:47:06 +02:00
17a383bc9c
Redo ReloadingContent with @ObservedObject
...
Proper way to listen to changes in elements is observing their
parent.
2022-04-19 21:22:13 +02:00
923ea923ab
Fix active profile not preselected on launch
...
Function called multiple times sets isFirstLaunch to true even if
not active profile.
2022-04-19 21:19:43 +02:00
18e9f7cbb5
Clear profile selection if current profile removed
...
Do it before ForEach rearranges NavigationLink elements, because
it may trigger undesired navigation to a deleted profile.
Restore related assertion.
2022-04-19 21:19:43 +02:00
7128352a9c
Fix settings menu not shown on iOS 14
...
Change to .navigation placement.
2022-04-19 21:19:43 +02:00
bf65f76401
Merge project into iOS + macOS
...
Share views with both platforms initially. Will split specific
views step by step.
2022-04-19 16:14:23 +02:00
Davide De Rosa