From 0c7a9b764446a4e3d64b3a3cb7d87d80208a61dc Mon Sep 17 00:00:00 2001 From: Roopesh Chander Date: Mon, 6 May 2019 11:12:47 +0530 Subject: [PATCH] macOS: Remove custom key event handling --- .../WireGuard/UI/macOS/Application.swift | 29 ------------------- .../ManageTunnelsRootViewController.swift | 24 --------------- 2 files changed, 53 deletions(-) diff --git a/WireGuard/WireGuard/UI/macOS/Application.swift b/WireGuard/WireGuard/UI/macOS/Application.swift index 6e33802..0ce274a 100644 --- a/WireGuard/WireGuard/UI/macOS/Application.swift +++ b/WireGuard/WireGuard/UI/macOS/Application.swift @@ -5,18 +5,6 @@ import Cocoa class Application: NSApplication { - private let characterKeyCommands = [ - "x": #selector(NSText.cut(_:)), - "c": #selector(NSText.copy(_:)), - "v": #selector(NSText.paste(_:)), - "z": #selector(UndoActionRespondable.undo(_:)), - "a": #selector(NSResponder.selectAll(_:)), - "Z": #selector(UndoActionRespondable.redo(_:)), - "w": #selector(NSWindow.performClose(_:)), - "m": #selector(NSWindow.performMiniaturize(_:)), - "q": #selector(AppDelegate.quit) - ] - private var appDelegate: AppDelegate? //swiftlint:disable:this weak_delegate override init() { @@ -28,21 +16,4 @@ class Application: NSApplication { required init?(coder: NSCoder) { fatalError("init(coder:) has not been implemented") } - - override func sendEvent(_ event: NSEvent) { - let modifierFlags = event.modifierFlags.rawValue & NSEvent.ModifierFlags.deviceIndependentFlagsMask.rawValue - - if event.type == .keyDown, - (modifierFlags == NSEvent.ModifierFlags.command.rawValue || modifierFlags == NSEvent.ModifierFlags.command.rawValue | NSEvent.ModifierFlags.shift.rawValue), - let selector = characterKeyCommands[event.charactersIgnoringModifiers ?? ""] { - sendAction(selector, to: nil, from: self) - } else { - super.sendEvent(event) - } - } -} - -@objc protocol UndoActionRespondable { - func undo(_ sender: AnyObject) - func redo(_ sender: AnyObject) } diff --git a/WireGuard/WireGuard/UI/macOS/ViewController/ManageTunnelsRootViewController.swift b/WireGuard/WireGuard/UI/macOS/ViewController/ManageTunnelsRootViewController.swift index b388843..aa6a76d 100644 --- a/WireGuard/WireGuard/UI/macOS/ViewController/ManageTunnelsRootViewController.swift +++ b/WireGuard/WireGuard/UI/macOS/ViewController/ManageTunnelsRootViewController.swift @@ -115,27 +115,3 @@ extension ManageTunnelsRootViewController: TunnelsListTableViewControllerDelegat self.tunnelDetailVC = nil } } - -extension ManageTunnelsRootViewController { - override func keyDown(with event: NSEvent) { - let modifierFlags = event.modifierFlags.rawValue & NSEvent.ModifierFlags.deviceIndependentFlagsMask.rawValue - let isCmdOrCmdShiftDown = (modifierFlags == NSEvent.ModifierFlags.command.rawValue || modifierFlags == NSEvent.ModifierFlags.command.rawValue | NSEvent.ModifierFlags.shift.rawValue) - - if event.specialKey == .delete { - tunnelsListVC?.handleRemoveTunnelAction() - } else if isCmdOrCmdShiftDown { - switch event.charactersIgnoringModifiers { - case "n": - tunnelsListVC?.handleAddEmptyTunnelAction() - case "o": - tunnelsListVC?.handleImportTunnelAction() - case "t": - tunnelDetailVC?.handleToggleActiveStatusAction() - case "e": - tunnelDetailVC?.handleEditTunnelAction() - default: - break - } - } - } -}