From 5ed47c58984904ea3e1906b318075342ce340b20 Mon Sep 17 00:00:00 2001 From: Roopesh Chander Date: Wed, 5 Dec 2018 15:38:19 +0530 Subject: [PATCH] Error presenter: Always handle the passed error --- WireGuard/WireGuard/UI/iOS/ErrorPresenter.swift | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/WireGuard/WireGuard/UI/iOS/ErrorPresenter.swift b/WireGuard/WireGuard/UI/iOS/ErrorPresenter.swift index 1116f61..2ae0cf0 100644 --- a/WireGuard/WireGuard/UI/iOS/ErrorPresenter.swift +++ b/WireGuard/WireGuard/UI/iOS/ErrorPresenter.swift @@ -5,7 +5,7 @@ import UIKit import os.log class ErrorPresenter { - static func errorMessage(for error: Error) -> (String, String)? { + static func errorMessage(for error: Error) -> (String, String) { switch (error) { // TunnelManagementError @@ -43,15 +43,14 @@ class ErrorPresenter { return ("Nothing to export", "There are no tunnels to export") default: - os_log("ErrorPresenter: Error not presented: %{public}@", log: OSLog.default, type: .error, "\(error)") - return nil + return ("Error", error.localizedDescription) } } static func showErrorAlert(error: Error, from sourceVC: UIViewController?, onDismissal: (() -> Void)? = nil, onPresented: (() -> Void)? = nil) { guard let sourceVC = sourceVC else { return } - guard let (title, message) = ErrorPresenter.errorMessage(for: error) else { return } + let (title, message) = ErrorPresenter.errorMessage(for: error) let okAction = UIAlertAction(title: "OK", style: .default) { (_) in onDismissal?() }