From 740350bed5c2317390bfde7db6f57df9720307bf Mon Sep 17 00:00:00 2001 From: Roopesh Chander Date: Fri, 5 Apr 2019 13:43:05 +0530 Subject: [PATCH] TunnelsManager: Fix comparing tunnels with tunnelProviders in reload() --- WireGuard/WireGuard/Tunnel/TunnelsManager.swift | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/WireGuard/WireGuard/Tunnel/TunnelsManager.swift b/WireGuard/WireGuard/Tunnel/TunnelsManager.swift index 19aeaef..b1def4c 100644 --- a/WireGuard/WireGuard/Tunnel/TunnelsManager.swift +++ b/WireGuard/WireGuard/Tunnel/TunnelsManager.swift @@ -78,14 +78,14 @@ class TunnelsManager { let loadedTunnelProviders = managers ?? [] for (index, currentTunnel) in self.tunnels.enumerated().reversed() { - if !loadedTunnelProviders.contains(where: { $0.tunnelConfiguration == currentTunnel.tunnelConfiguration }) { + if !loadedTunnelProviders.contains(where: { $0.isEquivalentTo(currentTunnel) }) { // Tunnel was deleted outside the app self.tunnels.remove(at: index) self.tunnelsListDelegate?.tunnelRemoved(at: index, tunnel: currentTunnel) } } for loadedTunnelProvider in loadedTunnelProviders { - if let matchingTunnel = self.tunnels.first(where: { $0.tunnelConfiguration == loadedTunnelProvider.tunnelConfiguration }) { + if let matchingTunnel = self.tunnels.first(where: { loadedTunnelProvider.isEquivalentTo($0) }) { matchingTunnel.tunnelProvider = loadedTunnelProvider matchingTunnel.refreshStatus() } else { @@ -608,4 +608,15 @@ extension NETunnelProviderManager { localizedDescription = tunnelConfiguration.name objc_setAssociatedObject(self, &NETunnelProviderManager.cachedConfigKey, tunnelConfiguration, objc_AssociationPolicy.OBJC_ASSOCIATION_RETAIN_NONATOMIC) } + + func isEquivalentTo(_ tunnel: TunnelContainer) -> Bool { + switch (isTunnelConfigurationAvailableInKeychain, tunnel.isTunnelConfigurationAvailableInKeychain) { + case (true, true): + return tunnelConfiguration == tunnel.tunnelConfiguration + case (false, false): + return localizedDescription == tunnel.name + default: + return false + } + } }