TunnelsManager: cache access to configuration object

Supposedly we never change it once per object, so we do the objective C
hack of adding it cached to the extension. This prevents 1000s of calls
to the keychain and improves the speed of imports.
This commit is contained in:
Jason A. Donenfeld 2019-02-04 21:30:33 +01:00
parent c79a45f2e2
commit bcd475e0bc
1 changed files with 9 additions and 1 deletions

View File

@ -526,7 +526,15 @@ class TunnelContainer: NSObject {
}
extension NETunnelProviderManager {
private static var cachedConfigKey: UInt8 = 0
var tunnelConfiguration: TunnelConfiguration? {
return (protocolConfiguration as? NETunnelProviderProtocol)?.asTunnelConfiguration(called: localizedDescription)
if let cached = objc_getAssociatedObject(self, &NETunnelProviderManager.cachedConfigKey) as? TunnelConfiguration {
return cached
}
let config = (protocolConfiguration as? NETunnelProviderProtocol)?.asTunnelConfiguration(called: localizedDescription)
if config != nil {
objc_setAssociatedObject(self, &NETunnelProviderManager.cachedConfigKey, config, objc_AssociationPolicy.OBJC_ASSOCIATION_RETAIN_NONATOMIC)
}
return config
}
}