iOS: Should be able to call showTunnelDetail multiple times

And the detail views should not stack up.

Signed-off-by: Roopesh Chander <roop@roopc.net>
This commit is contained in:
Roopesh Chander 2019-05-19 04:05:44 +05:30
parent 88c80d6694
commit c30d491edc
1 changed files with 17 additions and 5 deletions

View File

@ -255,21 +255,21 @@ class TunnelsListTableViewController: UIViewController {
func showTunnelDetail(for tunnel: TunnelContainer, animated: Bool) {
guard let tunnelsManager = tunnelsManager else { return }
guard let splitViewController = splitViewController else { return }
guard let navController = navigationController else { return }
if detailDisplayedTunnel != tunnel {
let tunnelDetailVC = TunnelDetailTableViewController(tunnelsManager: tunnelsManager,
tunnel: tunnel)
let tunnelDetailNC = UINavigationController(rootViewController: tunnelDetailVC)
tunnelDetailNC.restorationIdentifier = "DetailNC"
if animated {
splitViewController.showDetailViewController(tunnelDetailNC, sender: self)
if splitViewController.isCollapsed && navController.viewControllers.count > 1 {
navController.setViewControllers([self, tunnelDetailNC], animated: animated)
} else {
UIView.performWithoutAnimation {
splitViewController.showDetailViewController(tunnelDetailNC, sender: self)
}
splitViewController.showDetailViewController(tunnelDetailNC, sender: self, animated: animated)
}
detailDisplayedTunnel = tunnel
}
self.presentedViewController?.dismiss(animated: false, completion: nil)
}
}
@ -402,3 +402,15 @@ extension TunnelsListTableViewController: TunnelsManagerListDelegate {
}
}
}
extension UISplitViewController {
func showDetailViewController(_ vc: UIViewController, sender: Any?, animated: Bool) {
if animated {
showDetailViewController(vc, sender: sender)
} else {
UIView.performWithoutAnimation {
showDetailViewController(vc, sender: sender)
}
}
}
}