Jason A. Donenfeld
809c64b219
Version bump
2019-01-08 02:13:44 +01:00
Jason A. Donenfeld
a266171157
PacketTunnelSettingsGenerator: use 127.0.0.1 as dummy address
...
It turns out that using 0.0.0.0 somehow conflicts with DNS lookups when
CLAT is in use.
2019-01-08 01:51:12 +01:00
Jason A. Donenfeld
83cc642b34
Avoid dynamic MTU calculations for now
2019-01-07 19:23:39 -05:00
Jason A. Donenfeld
7bf3d7b09d
Update copyright
2019-01-07 19:23:39 -05:00
Jason A. Donenfeld
25676c461f
Version bump
2018-12-28 19:43:11 +01:00
Jason A. Donenfeld
013d603109
Rework DNS and routes in network extension
...
The DNS resolver prior had useless comments, awful nesting, converted
bytes into strings and back into bytes, and generally made no sense.
That's been rewritten now.
But more fundumentally, this commit made the DNS resolver actually
accomplish its objective, by passing AI_ALL to it. It turns out, though,
that the Go library isn't actually using GAI in the way we need for
parsing IP addresses, so we actually need to do another round, this time
with hints flag as zero, so that we get the DNS64 address.
Additionally, since we're now binding sockets to interfaces, we can
entirely remove the excludedRoutes logic.
2018-12-28 19:38:03 +01:00
Jason A. Donenfeld
1de0f5746c
Version bump
...
A Christmas Special, for TestFlight, and possibly for release if things
go well there.
2018-12-26 01:41:22 +01:00
Jason A. Donenfeld
0cc55db4cb
NetworkExtension: rescope socket instead of tearing down socket
2018-12-26 01:17:55 +01:00
Roopesh Chander
a380f17974
minizip: Remove zip encryption code
...
We can now remove -DNOCRYPT cflag while compiling
2018-12-25 12:48:04 +05:30
Roopesh Chander
00c07377ed
Tunnel edit: Fix crash
...
This fixes a crash that happens when you:
1. Scroll to the end of the Edit screen
2. Delete a peer
3. Toggle the Activate On Demand switch
2018-12-24 13:01:21 +05:30
Eric Kuck
00a7eabed2
SwitchCell nits
2018-12-22 15:32:29 -06:00
Eric Kuck
89fd494291
Fix typo for simulator builds
2018-12-22 14:32:39 -06:00
Roopesh Chander
3ca5712ac1
Remove more comments
2018-12-23 00:31:44 +05:30
Jason A. Donenfeld
b68b3785be
Rely on availability of fd only after setting network settings
2018-12-22 18:29:54 +01:00
Jason A. Donenfeld
a60b2a37d0
Retain aggressive socket reestablishment for now
...
This can be reverted once we've done more testing.
2018-12-22 15:45:09 +01:00
Roopesh Chander
2e37d511db
Don't set username on NETunnelProviderProtocol
...
The username corresponds to the Account field in iOS system VPN UI,
but if we don't set it, the field is not shown, so setting it isn't
really required.
2018-12-22 16:13:31 +05:30
Roopesh Chander
09a96ec2a8
TunnelErrors: Add alert text for PacketTunnelProviderError
2018-12-22 16:05:43 +05:30
Roopesh Chander
baf99733f5
TunnelStatus: Absorb NEVPNStatus+CustomStringConvertible
2018-12-22 15:46:28 +05:30
Jason A. Donenfeld
08daec71aa
Also refresh status
2018-12-22 07:07:53 +01:00
Jason A. Donenfeld
470da3ffcc
Reassign tunnelProvider if it changes from outside the app
2018-12-22 06:56:12 +01:00
Eric Kuck
8fb8d9a9d2
All models now Equatable
2018-12-21 22:57:17 -06:00
Jason A. Donenfeld
053c655fc0
Clean up trailing whitespace
2018-12-22 05:30:35 +01:00
Jason A. Donenfeld
27cd93a898
Do not crash if we can't get socket.fileDescriptor
2018-12-22 05:13:04 +01:00
Eric Kuck
3269c54718
Removing a tunnel from iOS's settings is now immediately reflected in app
2018-12-21 21:59:43 -06:00
Jason A. Donenfeld
0b2d91a7f4
Localize remaining strings in network extension
2018-12-22 03:42:01 +01:00
Eric Kuck
4277887146
RTL support
2018-12-21 20:37:22 -06:00
Eric Kuck
1124d4d359
Strongly recommended now appears as placeholder for DNS when needed
2018-12-21 19:52:51 -06:00
Jason A. Donenfeld
d0cc2a8afd
Combine double log invocations
2018-12-22 02:21:07 +01:00
Jason A. Donenfeld
cfdb4ec233
Attempt to strongly recommend things
2018-12-22 01:55:42 +01:00
Jason A. Donenfeld
30cf9a1d1d
Move model helpers to model directory
2018-12-22 01:36:42 +01:00
Eric Kuck
0d841609f6
Fixes mock tunnels
2018-12-21 18:35:01 -06:00
Jason A. Donenfeld
bfb0eb5dae
Do not set copyable back to true on reuse
2018-12-22 01:31:59 +01:00
Jason A. Donenfeld
e1c3d9b57a
Move name from interface to tunnel
2018-12-22 00:28:18 +01:00
Jason A. Donenfeld
41af6d863e
Fix paren typo
...
"I am very anti-paren." --Eric
2018-12-21 23:45:20 +01:00
Jason A. Donenfeld
775e174967
Nuke trailing spaces
2018-12-21 23:34:56 +01:00
Eric Kuck
c62c56da13
providerConfiguration is now a WgQuickConfig
2018-12-21 16:32:08 -06:00
Jason A. Donenfeld
137d453c0d
Do not require NetworkExtension to know its own name
2018-12-21 22:05:47 +01:00
Eric Kuck
d7a27426e9
All migration stuff moved to one gross file
2018-12-21 12:51:14 -06:00
Jason A. Donenfeld
d540c1811c
Simplify versioning of stored data
2018-12-21 18:58:06 +01:00
Jason A. Donenfeld
df698658d2
Get rid of superflous isActivateOnDemandEnabled key
2018-12-21 18:50:32 +01:00
Eric Kuck
f39893685f
Updated NETunnelProvider save format
2018-12-21 16:42:16 +01:00
Jason A. Donenfeld
cab80f8fc0
NE: simplify logic
2018-12-21 15:56:03 +01:00
Roopesh Chander
b02754a7bd
NE: Simplify DNS resolution
2018-12-21 19:24:22 +05:30
Roopesh Chander
6b48cb3095
Localize all the things
2018-12-21 18:34:09 +05:30
Roopesh Chander
01ea8f5f30
Tunnel detail: iPad: Handle deletion of tunnel correctly
2018-12-21 18:02:18 +05:30
Roopesh Chander
939e96e5c1
NE: Update listen port only when first interface changes
...
When handling network path changes, change the listen port
only when the first interface has changed.
2018-12-21 17:32:44 +05:30
Roopesh Chander
115e057d96
NE: Change handling of bad domain names and Activate On Demand
...
The solution implemented in commit b8c331c
causes the tunnel to
remain in 'Activating' state, without the ability to cancel that.
So, in this commit, instead of retrying DNS silently on
Activated-On-Demand tunnels, we fail the startTunnel() silently.
To summarize, if activate-on-demand is on:
- If started from the WireGuard app, show error using lastErrorFile
mechanism, suggesting a way to turn off Activate On Demand
- If not started from WireGuard app, don't call displayMessage()
(don't show error to user) and silently fail starting the tunnel
2018-12-21 15:52:47 +05:30
Eric Kuck
7ce5cb9d58
Added missing param in MockTunnels
2018-12-20 13:51:44 -06:00
Eric Kuck
9c7f27f19f
Enabled more swiftlint rules
2018-12-20 11:22:37 -06:00
Eric Kuck
cba41de73a
Added a String->[String] helper
2018-12-20 10:46:26 -06:00
Roopesh Chander
f141cf83a6
TunnelErrors: Remove unused error
2018-12-20 19:44:57 +05:30
Roopesh Chander
d82aedebbd
Tunnel edit: init() need not take a tunnelConfiguration argument
2018-12-19 18:35:53 +05:30
Roopesh Chander
d36b764e20
NE: Log whether tunnel was activated from the app or not
2018-12-19 18:35:53 +05:30
Roopesh Chander
8f46713b0d
Remove non-helpful comments
2018-12-19 18:35:53 +05:30
Roopesh Chander
61c3928459
Tunnel edit: Fix comment
2018-12-19 18:35:53 +05:30
Roopesh Chander
4c1c1f013c
TunnelsManager: If only Activate On Demand has changed, don't restart tunnel
2018-12-19 18:35:53 +05:30
Roopesh Chander
b8c331c72d
NE: Handle bad domain names and Activate On Demand
...
This combination causes iOS to keep trying to bring up the tunnel,
leading to a lot of displayMessage() alerts.
In this fix, if we get a DNS resolution error in an Activate On Demand
enabled tunnel, we silently retry 9 times (with a 4-second delay before
each retry) and then show the displayMessage() alert.
2018-12-19 15:38:00 +05:30
Roopesh Chander
82ca9f7c5a
NE: No need for two startTunnel() methods
2018-12-19 13:10:42 +05:30
Roopesh Chander
fe69fe57e4
TunnelsManager: Handle waiting on a stale tunnel
...
If we have a stale tunnel on which we don't get status updates we rely
on a timer to update the status (see commit 34a7e5b
). Previously, if
the user tries to activate another tunnel, that resulted in both tunnels
waiting indefinitely. This commit fixes that.
2018-12-19 12:48:10 +05:30
Roopesh Chander
efc593f7da
Remove buttons and text from LaunchScreen.storyboard
...
With state restoration, we're not guaranteed that the
list view will get shown immediately after the launch screen.
So, generalize the launch screen as much as possible.
2018-12-18 23:00:27 +05:30
Roopesh Chander
332e684ad0
s/Observervation/Observation/g;
2018-12-18 23:00:27 +05:30
Roopesh Chander
bc253b1aa8
Tunnel detail: Update restorationIdentifier when tunnel name changes
2018-12-18 19:27:31 +05:30
Roopesh Chander
b1bba11785
TunnelsManager: Add periods to end the system error messages
...
Because they can be part of a multi-sentence message when displayed
in the alert.
2018-12-18 15:47:20 +05:30
Roopesh Chander
92903e5b63
Error handling: Add info on the underlying system error to error alerts
2018-12-17 19:04:17 +05:30
Jason A. Donenfeld
321358271d
Version bump
...
This is our first release to the real app store.
2018-12-17 14:08:17 +01:00
Eric Kuck
d1825d6b6c
Got TunnelsManager back under the max file length by splitting out NEVPNStatus+CustomStringConvertible
2018-12-16 23:51:25 -06:00
Eric Kuck
92781a6eb9
Potential fix for insertRowAtIndexPath crash
2018-12-16 21:11:33 -06:00
Jason A. Donenfeld
395486b950
Improve mock tunnels generation
2018-12-16 01:51:14 +01:00
Roopesh Chander
6d348ab0e6
Provide mock tunnels for the Simulator
...
To help in generation of screenshots for the App Store
2018-12-16 01:15:10 +05:30
Jason A. Donenfeld
6f335f898a
Nuke duplicate file
2018-12-15 06:21:49 +01:00
Jason A. Donenfeld
8547dabce1
Version bump
2018-12-15 05:08:31 +01:00
Eric Kuck
0ea2e0d11b
Fixed editable KeyValueCells being copyable
...
Fixed DNS servers not saving
2018-12-14 21:48:48 -06:00
Jason A. Donenfeld
424c6d1173
Fix confusing indentation
2018-12-15 04:42:46 +01:00
Eric Kuck
66fcdfd13c
KeyValueCells now share code
2018-12-14 20:02:37 -06:00
Eric Kuck
4ae0c4bb17
Reorganized project structure
2018-12-14 17:27:11 -06:00
Eric Kuck
b06a43e2a2
Most similar views now shared between ViewControllers
2018-12-14 17:15:22 -06:00
Jason A. Donenfeld
9a7571051f
Prettier log time format
2018-12-15 00:08:54 +01:00
Jason A. Donenfeld
33d88529c6
Simplify logging tags
...
This was roop's initial idea, and it turns out to be the better one, now
that we can pass cstrings more easily.
2018-12-14 22:53:42 +01:00
Roopesh Chander
34a7e5b558
Fix tunnel remaining in 'Activating' state
...
It uses to remain in 'Activating' state when we don't get a status
update notification, for example, when turning on the tunnel repeatedly
without Internet connectivity.
2018-12-14 17:33:56 +05:30
Roopesh Chander
ce112a3f44
Fix status switch weird state after an error occurs
2018-12-14 16:50:36 +05:30
Jason A. Donenfeld
19f16c3291
Deduplicate functions
2018-12-14 00:01:50 +01:00
Jason A. Donenfeld
628ba73aa3
Simplify filemanager extension
2018-12-13 23:25:18 +01:00
Jason A. Donenfeld
b4348a33d2
Can't -> cannot
2018-12-13 23:17:05 +01:00
Roopesh Chander
e6c1e46b1d
NE: Communicate last error to app through a shared file
2018-12-14 02:24:53 +05:30
Roopesh Chander
206de837d1
TunnelsManager: startActivation() need not take a tunnelConfiguration
2018-12-14 00:40:18 +05:30
Jason A. Donenfeld
b40bbd1cdc
Localize swiftlint
2018-12-13 20:06:37 +01:00
Eric Kuck
a8cbe0d683
Reorganized ViewControllers (split out UIViews and UITableViewCells into their own classes)
...
All swiftlint warnings except one fixed up
2018-12-13 12:58:50 -06:00
Jason A. Donenfeld
a5aaec673a
Avoid escaping heap allocation
2018-12-13 19:43:12 +01:00
Jason A. Donenfeld
45dd86beee
Tidy up str to gostr conversion
2018-12-13 19:36:51 +01:00
Roopesh Chander
65e273c74b
TunnelsManager: Remove mentions of 'internal error'
2018-12-13 23:53:17 +05:30
Roopesh Chander
fb2b423d06
TunnelsManager: Ask to check Internet connectivity in error alert
2018-12-13 23:49:42 +05:30
Roopesh Chander
03680bf3c9
Remove unused code: InternetReachability
2018-12-13 23:45:21 +05:30
Roopesh Chander
57b95e1e01
TunnelsManager: Remove unused variable
2018-12-13 23:44:13 +05:30
Roopesh Chander
738b2dba52
TunnelsManager: Remove assert
2018-12-13 23:43:15 +05:30
Jason A. Donenfeld
d7f91f2888
Simplify C strings
2018-12-13 19:08:38 +01:00
Roopesh Chander
20a23a86da
TunnelsManager: Fix race between multiple startActivation() calls
...
After startActivate() is called on a waiting tunnel, user might turn
on a different tunnel before the waiting tunnel's status gets updated.
This fix prevents that from happening.
2018-12-13 23:34:00 +05:30
Roopesh Chander
872bda6d34
TunnelsManager: Reintroduce waiting for another tunnel to deactivate
2018-12-13 23:21:49 +05:30
Jason A. Donenfeld
a9325289d2
Rewrite Logger
...
This reverts all of Roop's changes to the C code, and then rewrites the
logger logic to be cleaner.
2018-12-13 18:06:37 +01:00
Eric Kuck
825aa95956
More reliable logo sizing
2018-12-13 09:30:13 -06:00
Roopesh Chander
b0df5a53da
TunnelsManager: Report activation errors through the activationDelegate
...
Don't report activation errors through completion handlers
2018-12-13 18:56:07 +05:30