2020-07-05 18:35:36 +00:00
|
|
|
use rocket::http::Header;
|
|
|
|
|
use rocket::local::blocking::Client;
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn test_local_request_clone_soundness() {
|
Test 'secret_key' validation, now on pre-launch.
Prior to this commit, it was not possible to test Rocket crates in
production mode without setting a global secret key or bypassing secret
key checking - the testing script did the latter. The consequence is
that it became impossible to test secret key related failures because
the tests passed regardless.
This commit undoes this. As a consequence, all tests are now aware of
the difference between debug and release configurations, the latter of
which validates 'secret_key' by default. New 'Client::debug()' and
'Client::debug_with()' simplify creating an instance of 'Client' with
configuration in debug mode to avoid undesired test failures.
The summary of changes in this commit are:
* Config 'secret_key' success and failure are now tested.
* 'secret_key' validation was moved to pre-launch from 'Config:from()'.
* 'Config::from()' only extracts the config.
* Added 'Config::try_from()' for non-panicking extraction.
* 'Config' now knows the profile it was extracted from.
* The 'Config' provider sets a profile of 'Config.profile'.
* 'Rocket', 'Client', 'Fairings', implement 'Debug'.
* 'fairing::Info' implements 'Copy', 'Clone'.
* 'Fairings' keeps track of, logs attach fairings.
* 'Rocket::reconfigure()' was added to allow modifying a config.
Internally, the testing script was refactored to properly test the
codebase with the new changes. In particular, it no longer sets a rustc
'cfg' to avoid secret-key checking.
Resolves #1543.
Fixes #1564.
2021-03-09 08:07:43 +00:00
|
|
|
let client = Client::debug_with(vec![]).unwrap();
|
2020-07-05 18:35:36 +00:00
|
|
|
|
|
|
|
|
// creates two LocalRequest instances that shouldn't share the same req
|
|
|
|
|
let r1 = client.get("/").header(Header::new("key", "val1"));
|
|
|
|
|
let mut r2 = r1.clone();
|
|
|
|
|
|
|
|
|
|
// save the iterator, which internally holds a slice
|
|
|
|
|
let mut iter = r1.inner().headers().get("key");
|
|
|
|
|
|
|
|
|
|
// insert headers to force header map reallocation.
|
|
|
|
|
for i in 0..100 {
|
|
|
|
|
r2.add_header(Header::new(i.to_string(), i.to_string()));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Replace the original key/val.
|
|
|
|
|
r2.add_header(Header::new("key", "val2"));
|
|
|
|
|
|
|
|
|
|
// Heap massage: so we've got crud to print.
|
|
|
|
|
let _: Vec<usize> = vec![0, 0xcafebabe, 31337, 0];
|
|
|
|
|
|
|
|
|
|
// Ensure we're good.
|
|
|
|
|
let s = iter.next().unwrap();
|
|
|
|
|
println!("{}", s);
|
|
|
|
|
|
|
|
|
|
// And that we've got the right data.
|
|
|
|
|
assert_eq!(r1.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1"]);
|
|
|
|
|
assert_eq!(r2.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1", "val2"]);
|
|
|
|
|
}
|
