rwf2
/
Rocket
mirror of https://github.com/rwf2/Rocket.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clarify internal sentinel docs.

This commit is contained in:
Sergio Benitez 2021-04-16 18:03:23 -07:00
parent e1307ddf48
commit 08c0701bdc
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/lib/src/sentinel.rs
View File

@ -243,9 +243,15 @@ impl<T: Sentinel> Sentinel for Option<T> {
}
}
// In the next impls, we want to run _both_ sentinels _without_ short
// circuiting, for the logs. Ideally we could check if these are the same type
// or not, but `TypeId` only works with `'static`, and adding those bounds to
// `T` and `E` would reduce the types for which the implementations work, which
// would mean more types that we miss in type applies. When the type _isn't_ an
// alias, however, the existence of these implementations is strictly worse.
impl<T: Sentinel, E: Sentinel> Sentinel for Result<T, E> {
fn abort(rocket: &Rocket<Ignite>) -> bool {
// We want to run _both_, _without_ short-circuiting, for the logs.
let left = T::abort(rocket);
let right = E::abort(rocket);
left || right
@ -254,14 +260,14 @@ impl<T: Sentinel, E: Sentinel> Sentinel for Result<T, E> {
impl<T: Sentinel, E: Sentinel> Sentinel for either::Either<T, E> {
fn abort(rocket: &Rocket<Ignite>) -> bool {
// We want to run _both_, _without_ short-circuiting, for the logs.
let left = T::abort(rocket);
let right = E::abort(rocket);
left || right
}
}
/// A sentinel that never aborts.
/// A sentinel that never aborts. The `Responder` impl for `Debug` will never be
/// called, so it's okay to not abort for failing `T: Sentinel`.
impl<T> Sentinel for crate::response::Debug<T> {
fn abort(_: &Rocket<Ignite>) -> bool {
false