From 3eeae77ed6a7be1c3304a41b7f59b38f6c33c2e6 Mon Sep 17 00:00:00 2001 From: Sergio Benitez Date: Fri, 2 Jun 2017 18:46:31 -0700 Subject: [PATCH] Add tests for 'form_kitchen_sink' example. Closes #62. --- examples/form_kitchen_sink/src/main.rs | 13 +- examples/form_kitchen_sink/src/tests.rs | 182 ++++++++++++++++++++++++ 2 files changed, 191 insertions(+), 4 deletions(-) create mode 100644 examples/form_kitchen_sink/src/tests.rs diff --git a/examples/form_kitchen_sink/src/main.rs b/examples/form_kitchen_sink/src/main.rs index 8583578c..d4f60df3 100644 --- a/examples/form_kitchen_sink/src/main.rs +++ b/examples/form_kitchen_sink/src/main.rs @@ -4,10 +4,13 @@ extern crate rocket; use std::io; + use rocket::request::{Form, FromFormValue}; use rocket::response::NamedFile; use rocket::http::RawStr; +#[cfg(test)] mod tests; + // TODO: Make deriving `FromForm` for this enum possible. #[derive(Debug)] enum FormOption { @@ -55,8 +58,10 @@ fn index() -> io::Result { NamedFile::open("static/index.html") } -fn main() { - rocket::ignite() - .mount("/", routes![index, sink]) - .launch(); +fn rocket() -> rocket::Rocket { + rocket::ignite().mount("/", routes![index, sink]) +} + +fn main() { + rocket().launch(); } diff --git a/examples/form_kitchen_sink/src/tests.rs b/examples/form_kitchen_sink/src/tests.rs new file mode 100644 index 00000000..94e04a3d --- /dev/null +++ b/examples/form_kitchen_sink/src/tests.rs @@ -0,0 +1,182 @@ +use std::fmt; +use super::{rocket, FormInput, FormOption}; + +use rocket::Rocket; +use rocket::testing::MockRequest; +use rocket::http::ContentType; +use rocket::http::Method::*; + +impl fmt::Display for FormOption { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + match *self { + FormOption::A => write!(f, "a"), + FormOption::B => write!(f, "b"), + FormOption::C => write!(f, "c"), + } + } +} + +fn assert_form_eq(rocket: &Rocket, form_str: &str, expected: String) { + let mut req = MockRequest::new(Post, "/") + .header(ContentType::Form) + .body(form_str); + let mut res = req.dispatch_with(&rocket); + assert_eq!(res.body_string(), Some(expected)); +} + +fn assert_valid_form(rocket: &Rocket, input: &FormInput) { + let f = format!("checkbox={}&number={}&type={}&password={}&textarea={}&select={}", + input.checkbox, input.number, input.radio, input.password, + input.text_area, input.select); + assert_form_eq(rocket, &f, format!("{:?}", input)); +} + +fn assert_valid_raw_form(rocket: &Rocket, form_str: &str, input: &FormInput) { + assert_form_eq(rocket, form_str, format!("{:?}", input)); +} + +#[test] +fn test_good_forms() { + let rocket = rocket(); + let mut input = FormInput { + checkbox: true, + number: 310, + radio: FormOption::A, + password: "beep".to_string(), + text_area: "bop".to_string(), + select: FormOption::B + }; + + assert_valid_form(&rocket, &input); + + input.checkbox = false; + assert_valid_form(&rocket, &input); + + input.number = 0; + assert_valid_form(&rocket, &input); + input.number = 120; + assert_valid_form(&rocket, &input); + input.number = 133; + assert_valid_form(&rocket, &input); + + input.radio = FormOption::B; + assert_valid_form(&rocket, &input); + input.radio = FormOption::C; + assert_valid_form(&rocket, &input); + + input.password = "".to_string(); + assert_valid_form(&rocket, &input); + input.password = "----90138490285u2o3hndslkv".to_string(); + assert_valid_form(&rocket, &input); + input.password = "hi".to_string(); + assert_valid_form(&rocket, &input); + + input.text_area = "".to_string(); + assert_valid_form(&rocket, &input); + input.text_area = "----90138490285u2o3hndslkv".to_string(); + assert_valid_form(&rocket, &input); + input.text_area = "hey".to_string(); + assert_valid_form(&rocket, &input); + + input.select = FormOption::A; + assert_valid_form(&rocket, &input); + input.select = FormOption::C; + assert_valid_form(&rocket, &input); + + // checkbox need not be present; defaults to false; accepts 'on' and 'off' + assert_valid_raw_form(&rocket, + "number=133&type=c&password=hi&textarea=hey&select=c", + &input); + + assert_valid_raw_form(&rocket, + "checkbox=off&number=133&type=c&password=hi&textarea=hey&select=c", + &input); + + input.checkbox = true; + assert_valid_raw_form(&rocket, + "checkbox=on&number=133&type=c&password=hi&textarea=hey&select=c", + &input); +} + +fn assert_invalid_form(rocket: &Rocket, vals: &mut [&str; 6]) { + let s = format!("checkbox={}&number={}&type={}&password={}&textarea={}&select={}", + vals[0], vals[1], vals[2], vals[3], vals[4], vals[5]); + assert_form_eq(rocket, &s, format!("Invalid form input: {}", s)); + *vals = ["true", "1", "a", "hi", "hey", "b"]; +} + +fn assert_invalid_raw_form(rocket: &Rocket, form_str: &str) { + assert_form_eq(rocket, form_str, format!("Invalid form input: {}", form_str)); +} + +#[test] +fn check_semantically_invalid_forms() { + let rocket = rocket(); + let mut form_vals = ["true", "1", "a", "hi", "hey", "b"]; + + form_vals[0] = "not true"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[0] = "bing"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[0] = "true0"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[0] = " false"; + assert_invalid_form(&rocket, &mut form_vals); + + form_vals[1] = "-1"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[1] = "1e10"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[1] = "-1-1"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[1] = "NaN"; + assert_invalid_form(&rocket, &mut form_vals); + + form_vals[2] = "A"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[2] = "B"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[2] = "d"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[2] = "100"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[2] = ""; + assert_invalid_form(&rocket, &mut form_vals); + + // password and textarea are always valid, so we skip them + form_vals[5] = "A"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[5] = "b "; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[5] = "d"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[5] = "-a"; + assert_invalid_form(&rocket, &mut form_vals); + form_vals[5] = ""; + assert_invalid_form(&rocket, &mut form_vals); + + // now forms with missing fields + assert_invalid_raw_form(&rocket, "number=10&type=a&password=hi&textarea=hey"); + assert_invalid_raw_form(&rocket, "number=10&radio=a&password=hi&textarea=hey&select=b"); + assert_invalid_raw_form(&rocket, "number=10&password=hi&select=b"); + assert_invalid_raw_form(&rocket, "number=10&select=b"); + assert_invalid_raw_form(&rocket, "password=hi&select=b"); + assert_invalid_raw_form(&rocket, "password=hi"); + assert_invalid_raw_form(&rocket, ""); +} + +#[test] +fn check_structurally_invalid_forms() { + let rocket = rocket(); + assert_invalid_raw_form(&rocket, "==&&&&&&=="); + assert_invalid_raw_form(&rocket, "a&=b"); + assert_invalid_raw_form(&rocket, "="); +} + +#[test] +fn check_bad_utf8() { + unsafe { + let bad_str = ::std::str::from_utf8_unchecked(b"a=\xff"); + assert_form_eq(&rocket(), bad_str, "Form input was invalid UTF8.".into()); + } +}