From 4d83f73f86bfa1894bad8e253d05ae225135afe0 Mon Sep 17 00:00:00 2001
From: Sergio Benitez <sb@sergio.bz>
Date: Tue, 19 Apr 2022 13:58:30 -0700
Subject: [PATCH] Implement 'Eq' for 'MediaType', 'ContentType'.

This also fixes the 'Hash' implementation to match the docs.

Resolves #2132.
---
 core/http/src/header/content_type.rs |  2 +-
 core/http/src/header/media_type.rs   | 19 +++++++++----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/core/http/src/header/content_type.rs b/core/http/src/header/content_type.rs
index 07146869..8c218dc3 100644
--- a/core/http/src/header/content_type.rs
+++ b/core/http/src/header/content_type.rs
@@ -40,7 +40,7 @@ use crate::ext::IntoCollection;
 ///
 /// let response = Response::build().header(ContentType::HTML).finalize();
 /// ```
-#[derive(Debug, Clone, PartialEq, Hash)]
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
 pub struct ContentType(pub MediaType);
 
 macro_rules! content_types {
diff --git a/core/http/src/header/media_type.rs b/core/http/src/header/media_type.rs
index 2db0c284..11332f4f 100644
--- a/core/http/src/header/media_type.rs
+++ b/core/http/src/header/media_type.rs
@@ -467,13 +467,15 @@ impl MediaType {
 
     /// Compares `self` with `other` and returns `true` if `self` and `other`
     /// are exactly equal to each other, including with respect to their
-    /// parameters.
+    /// parameters and their order.
     ///
     /// This is different from the `PartialEq` implementation in that it
-    /// considers parameters. If `PartialEq` returns false, this function is
-    /// guaranteed to return false. Similarly, if this function returns `true`,
-    /// `PartialEq` is guaranteed to return true. However, if `PartialEq`
-    /// returns `true`, this function may or may not return `true`.
+    /// considers parameters. In particular, `Eq` implies `PartialEq` but
+    /// `PartialEq` does not imply `Eq`. That is, if `PartialEq` returns false,
+    /// this function is guaranteed to return false. Similarly, if `exact_eq`
+    /// returns `true`, `PartialEq` is guaranteed to return true. However, if
+    /// `PartialEq` returns `true`, `exact_eq` function may or may not return
+    /// `true`.
     ///
     /// # Example
     ///
@@ -572,16 +574,13 @@ impl PartialEq for MediaType {
     }
 }
 
+impl Eq for MediaType {  }
+
 impl Hash for MediaType {
     #[inline]
     fn hash<H: Hasher>(&self, state: &mut H) {
         self.top().hash(state);
         self.sub().hash(state);
-
-        for (key, val) in self.params() {
-            key.hash(state);
-            val.hash(state);
-        }
     }
 }