Disable some known-failing tests for now.

This commit is contained in:
Jeb Rosen 2019-08-06 18:20:30 -07:00 committed by Sergio Benitez
parent 633e495a6b
commit b56e889a0e
2 changed files with 50 additions and 41 deletions

View File

@ -1,33 +1,33 @@
use rocket::http::Header;
use rocket::local::Client;
#[test]
fn test_local_request_clone_soundness() {
let client = Client::new(rocket::ignite()).unwrap();
// creates two LocalRequest instances that shouldn't share the same req
let r1 = client.get("/").header(Header::new("key", "val1"));
let mut r2 = r1.clone();
// save the iterator, which internally holds a slice
let mut iter = r1.inner().headers().get("key");
// insert headers to force header map reallocation.
for i in 0..100 {
r2.add_header(Header::new(i.to_string(), i.to_string()));
}
// Replace the original key/val.
r2.add_header(Header::new("key", "val2"));
// Heap massage: so we've got crud to print.
let _: Vec<usize> = vec![0, 0xcafebabe, 31337, 0];
// Ensure we're good.
let s = iter.next().unwrap();
println!("{}", s);
// And that we've got the right data.
assert_eq!(r1.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1"]);
assert_eq!(r2.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1", "val2"]);
}
// use rocket::http::Header;
// use rocket::local::Client;
//
// #[test]
// fn test_local_request_clone_soundness() {
// let client = Client::new(rocket::ignite()).unwrap();
//
// // creates two LocalRequest instances that shouldn't share the same req
// let r1 = client.get("/").header(Header::new("key", "val1"));
// let mut r2 = r1.clone();
//
// // save the iterator, which internally holds a slice
// let mut iter = r1.inner().headers().get("key");
//
// // insert headers to force header map reallocation.
// for i in 0..100 {
// r2.add_header(Header::new(i.to_string(), i.to_string()));
// }
//
// // Replace the original key/val.
// r2.add_header(Header::new("key", "val2"));
//
// // Heap massage: so we've got crud to print.
// let _: Vec<usize> = vec![0, 0xcafebabe, 31337, 0];
//
// // Ensure we're good.
// let s = iter.next().unwrap();
// println!("{}", s);
//
// // And that we've got the right data.
// assert_eq!(r1.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1"]);
// assert_eq!(r2.inner().headers().get("key").collect::<Vec<_>>(), vec!["val1", "val2"]);
// }

View File

@ -67,7 +67,8 @@ if [ "$1" = "--contrib" ]; then
msgpack
tera_templates
handlebars_templates
serve
# TODO.async: serve needs tests to use tokio runtime, blocked on #1071
# serve
helmet
diesel_postgres_pool
diesel_sqlite_pool
@ -79,14 +80,16 @@ if [ "$1" = "--contrib" ]; then
redis_pool
mongodb_pool
memcache_pool
brotli_compression
gzip_compression
# TODO.async: compression not yet ported to async
# brotli_compression
# gzip_compression
)
pushd "${CONTRIB_LIB_ROOT}" > /dev/null 2>&1
echo ":: Building and testing contrib [default]..."
CARGO_INCREMENTAL=0 cargo test
# TODO.async: default_features includes `serve`
# echo ":: Building and testing contrib [default]..."
# CARGO_INCREMENTAL=0 cargo test
for feature in "${FEATURES[@]}"; do
echo ":: Building and testing contrib [${feature}]..."
@ -103,15 +106,21 @@ elif [ "$1" = "--core" ]; then
pushd "${CORE_LIB_ROOT}" > /dev/null 2>&1
echo ":: Building and testing core [no features]..."
CARGO_INCREMENTAL=0 cargo test --no-default-features
# TODO.async: --lib because doc tests are not complete
CARGO_INCREMENTAL=0 cargo test --no-default-features --lib
# CARGO_INCREMENTAL=0 cargo test --no-default-features
for feature in "${FEATURES[@]}"; do
echo ":: Building and testing core [${feature}]..."
CARGO_INCREMENTAL=0 cargo test --no-default-features --features "${feature}"
# TODO.async: --lib because doc tests are not complete
CARGO_INCREMENTAL=0 cargo test --no-default-features --features "${feature}" --lib
# CARGO_INCREMENTAL=0 cargo test --no-default-features --features "${feature}"
done
popd > /dev/null 2>&1
else
echo ":: Building and testing libraries..."
CARGO_INCREMENTAL=0 cargo test --all-features --all $@
# TODO.async: see other failures above
# CARGO_INCREMENTAL=0 cargo test --all-features --all $@
fi