mirror of
https://github.com/rwf2/Rocket.git
synced 2024-12-31 23:02:37 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
60 lines
1.6 KiB
Rust
60 lines
1.6 KiB
Rust
#[macro_use] extern crate rocket;
|
|
|
|
use rocket::request::FlashMessage;
|
|
use rocket::response::Flash;
|
|
|
|
const FLASH_MESSAGE: &str = "Hey! I'm a flash message. :)";
|
|
|
|
#[post("/")]
|
|
fn set() -> Flash<&'static str> {
|
|
Flash::success("This is the page.", FLASH_MESSAGE)
|
|
}
|
|
|
|
#[get("/unused")]
|
|
fn unused(flash: Option<FlashMessage<'_>>) -> Option<()> {
|
|
flash.map(|_| ())
|
|
}
|
|
|
|
#[get("/use")]
|
|
fn used(flash: Option<FlashMessage<'_>>) -> Option<String> {
|
|
flash.map(|flash| flash.msg().into())
|
|
}
|
|
|
|
mod flash_lazy_remove_tests {
|
|
use rocket::local::blocking::Client;
|
|
use rocket::http::Status;
|
|
|
|
#[test]
|
|
fn test() {
|
|
use super::*;
|
|
|
|
// Ensure the cookie's not there at first.
|
|
let client = Client::debug_with(routes![set, unused, used]).unwrap();
|
|
let response = client.get("/unused").dispatch();
|
|
assert_eq!(response.status(), Status::NotFound);
|
|
|
|
// Set the flash cookie.
|
|
client.post("/").dispatch();
|
|
|
|
// Try once.
|
|
let response = client.get("/unused").dispatch();
|
|
assert_eq!(response.status(), Status::Ok);
|
|
|
|
// Try again; should still be there.
|
|
let response = client.get("/unused").dispatch();
|
|
assert_eq!(response.status(), Status::Ok);
|
|
|
|
// Now use it.
|
|
let response = client.get("/use").dispatch();
|
|
assert_eq!(response.into_string(), Some(FLASH_MESSAGE.into()));
|
|
|
|
// Now it should be gone.
|
|
let response = client.get("/unused").dispatch();
|
|
assert_eq!(response.status(), Status::NotFound);
|
|
|
|
// Still gone.
|
|
let response = client.get("/use").dispatch();
|
|
assert_eq!(response.status(), Status::NotFound);
|
|
}
|
|
}
|