mirror of
https://github.com/rwf2/Rocket.git
synced 2024-12-31 23:02:37 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
48 lines
1.5 KiB
Rust
48 lines
1.5 KiB
Rust
#[macro_use] extern crate rocket;
|
|
|
|
use rocket::request::Request;
|
|
use rocket::http::{Cookie, CookieJar};
|
|
|
|
#[catch(404)]
|
|
fn not_found(request: &Request) -> &'static str {
|
|
request.cookies().add(Cookie::new("not_found", "404"));
|
|
"404 - Not Found"
|
|
}
|
|
|
|
#[get("/")]
|
|
fn index(cookies: &CookieJar<'_>) -> &'static str {
|
|
cookies.add(Cookie::new("index", "hi"));
|
|
"Hello, world!"
|
|
}
|
|
|
|
mod tests {
|
|
use super::*;
|
|
use rocket::local::blocking::Client;
|
|
use rocket::fairing::AdHoc;
|
|
|
|
#[test]
|
|
fn error_catcher_sets_cookies() {
|
|
let rocket = rocket::ignite()
|
|
.mount("/", routes![index])
|
|
.register(catchers![not_found])
|
|
.attach(AdHoc::on_request("Add Cookie", |req, _| Box::pin(async move {
|
|
req.cookies().add(Cookie::new("fairing", "woo"));
|
|
})));
|
|
|
|
let client = Client::debug(rocket).unwrap();
|
|
|
|
// Check that the index returns the `index` and `fairing` cookie.
|
|
let response = client.get("/").dispatch();
|
|
let cookies = response.cookies();
|
|
assert_eq!(cookies.iter().count(), 2);
|
|
assert_eq!(cookies.get("index").unwrap().value(), "hi");
|
|
assert_eq!(cookies.get("fairing").unwrap().value(), "woo");
|
|
|
|
// Check that the catcher returns only the `not_found` cookie.
|
|
let response = client.get("/not-existent").dispatch();
|
|
let cookies = response.cookies();
|
|
assert_eq!(cookies.iter().count(), 1);
|
|
assert_eq!(cookies.get("not_found").unwrap().value(), "404");
|
|
}
|
|
}
|