mirror of
https://github.com/rwf2/Rocket.git
synced 2025-01-05 17:22:36 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
66 lines
1.8 KiB
Rust
66 lines
1.8 KiB
Rust
#[macro_use] extern crate rocket;
|
|
|
|
use rocket::form::Form;
|
|
|
|
#[post("/", data = "<form>")]
|
|
fn index(form: Form<String>) -> String {
|
|
form.into_inner()
|
|
}
|
|
|
|
mod limits_tests {
|
|
use rocket;
|
|
use rocket::local::blocking::Client;
|
|
use rocket::http::{Status, ContentType};
|
|
use rocket::data::Limits;
|
|
|
|
fn rocket_with_forms_limit(limit: u64) -> rocket::Rocket {
|
|
let mut config = rocket::Config::debug_default();
|
|
config.limits = Limits::default().limit("form", limit.into());
|
|
rocket::custom(config).mount("/", routes![super::index])
|
|
}
|
|
|
|
#[test]
|
|
fn large_enough() {
|
|
let client = Client::debug(rocket_with_forms_limit(128)).unwrap();
|
|
let response = client.post("/")
|
|
.body("value=Hello+world")
|
|
.header(ContentType::Form)
|
|
.dispatch();
|
|
|
|
assert_eq!(response.into_string(), Some("Hello world".into()));
|
|
}
|
|
|
|
#[test]
|
|
fn just_large_enough() {
|
|
let client = Client::debug(rocket_with_forms_limit(17)).unwrap();
|
|
let response = client.post("/")
|
|
.body("value=Hello+world")
|
|
.header(ContentType::Form)
|
|
.dispatch();
|
|
|
|
assert_eq!(response.into_string(), Some("Hello world".into()));
|
|
}
|
|
|
|
#[test]
|
|
fn much_too_small() {
|
|
let client = Client::debug(rocket_with_forms_limit(4)).unwrap();
|
|
let response = client.post("/")
|
|
.body("value=Hello+world")
|
|
.header(ContentType::Form)
|
|
.dispatch();
|
|
|
|
assert_eq!(response.status(), Status::PayloadTooLarge);
|
|
}
|
|
|
|
#[test]
|
|
fn contracted() {
|
|
let client = Client::debug(rocket_with_forms_limit(10)).unwrap();
|
|
let response = client.post("/")
|
|
.body("value=Hello+world")
|
|
.header(ContentType::Form)
|
|
.dispatch();
|
|
|
|
assert_eq!(response.status(), Status::PayloadTooLarge);
|
|
}
|
|
}
|