mirror of
https://github.com/rwf2/Rocket.git
synced 2025-01-06 01:32:36 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
57 lines
1.4 KiB
Rust
57 lines
1.4 KiB
Rust
#[macro_use] extern crate rocket;
|
|
|
|
use rocket::Rocket;
|
|
use rocket::http::Status;
|
|
use rocket::local::blocking::Client;
|
|
|
|
#[get("/panic")]
|
|
fn panic_route() -> &'static str {
|
|
panic!("Panic in route")
|
|
}
|
|
|
|
#[catch(404)]
|
|
fn panic_catcher() -> &'static str {
|
|
panic!("Panic in catcher")
|
|
}
|
|
|
|
#[catch(500)]
|
|
fn ise() -> &'static str {
|
|
"Hey, sorry! :("
|
|
}
|
|
|
|
#[catch(500)]
|
|
fn double_panic() {
|
|
panic!("so, so sorry...")
|
|
}
|
|
|
|
fn rocket() -> Rocket {
|
|
rocket::ignite()
|
|
.mount("/", routes![panic_route])
|
|
.register(catchers![panic_catcher, ise])
|
|
}
|
|
|
|
#[test]
|
|
fn catches_route_panic() {
|
|
let client = Client::debug(rocket()).unwrap();
|
|
let response = client.get("/panic").dispatch();
|
|
assert_eq!(response.status(), Status::InternalServerError);
|
|
assert_eq!(response.into_string().unwrap(), "Hey, sorry! :(");
|
|
|
|
}
|
|
#[test]
|
|
fn catches_catcher_panic() {
|
|
let client = Client::debug(rocket()).unwrap();
|
|
let response = client.get("/noroute").dispatch();
|
|
assert_eq!(response.status(), Status::InternalServerError);
|
|
assert_eq!(response.into_string().unwrap(), "Hey, sorry! :(");
|
|
}
|
|
|
|
#[test]
|
|
fn catches_double_panic() {
|
|
let rocket = rocket().register(catchers![double_panic]);
|
|
let client = Client::debug(rocket).unwrap();
|
|
let response = client.get("/noroute").dispatch();
|
|
assert_eq!(response.status(), Status::InternalServerError);
|
|
assert!(!response.into_string().unwrap().contains(":("));
|
|
}
|