mirror of
https://github.com/rwf2/Rocket.git
synced 2024-12-29 05:42:35 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
56 lines
1.1 KiB
Rust
56 lines
1.1 KiB
Rust
use rocket;
|
|
|
|
use rocket::{get, routes};
|
|
use rocket::form::{FromForm, FromFormField};
|
|
use rocket::response::Responder;
|
|
|
|
#[derive(FromFormField)]
|
|
enum Thing {
|
|
A,
|
|
B,
|
|
C,
|
|
}
|
|
|
|
impl std::fmt::Display for Thing {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
match *self {
|
|
Thing::A => write!(f, "a"),
|
|
Thing::B => write!(f, "b"),
|
|
Thing::C => write!(f, "c"),
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(FromForm)]
|
|
struct ThingForm {
|
|
thing: Thing,
|
|
}
|
|
|
|
#[derive(Responder)]
|
|
struct DerivedResponder {
|
|
data: String,
|
|
}
|
|
|
|
#[get("/")]
|
|
fn index() -> DerivedResponder {
|
|
DerivedResponder { data: "hello".to_string() }
|
|
}
|
|
|
|
#[get("/?<params..>")]
|
|
fn number(params: ThingForm) -> DerivedResponder {
|
|
DerivedResponder { data: params.thing.to_string() }
|
|
}
|
|
|
|
#[test]
|
|
fn test_derive_reexports() {
|
|
use rocket::local::blocking::Client;
|
|
|
|
let client = Client::debug_with(routes![index, number]).unwrap();
|
|
|
|
let response = client.get("/").dispatch();
|
|
assert_eq!(response.into_string().unwrap(), "hello");
|
|
|
|
let response = client.get("/?thing=b").dispatch();
|
|
assert_eq!(response.into_string().unwrap(), "b");
|
|
}
|