mirror of
https://github.com/rwf2/Rocket.git
synced 2025-01-02 15:52:41 +00:00
4e06ee64aa
Prior to this commit, it was not possible to test Rocket crates in production mode without setting a global secret key or bypassing secret key checking - the testing script did the latter. The consequence is that it became impossible to test secret key related failures because the tests passed regardless. This commit undoes this. As a consequence, all tests are now aware of the difference between debug and release configurations, the latter of which validates 'secret_key' by default. New 'Client::debug()' and 'Client::debug_with()' simplify creating an instance of 'Client' with configuration in debug mode to avoid undesired test failures. The summary of changes in this commit are: * Config 'secret_key' success and failure are now tested. * 'secret_key' validation was moved to pre-launch from 'Config:from()'. * 'Config::from()' only extracts the config. * Added 'Config::try_from()' for non-panicking extraction. * 'Config' now knows the profile it was extracted from. * The 'Config' provider sets a profile of 'Config.profile'. * 'Rocket', 'Client', 'Fairings', implement 'Debug'. * 'fairing::Info' implements 'Copy', 'Clone'. * 'Fairings' keeps track of, logs attach fairings. * 'Rocket::reconfigure()' was added to allow modifying a config. Internally, the testing script was refactored to properly test the codebase with the new changes. In particular, it no longer sets a rustc 'cfg' to avoid secret-key checking. Resolves #1543. Fixes #1564.
51 lines
1.4 KiB
Rust
51 lines
1.4 KiB
Rust
#[macro_use] extern crate rocket;
|
|
|
|
use rocket::{Request, Data};
|
|
use rocket::local::blocking::Client;
|
|
use rocket::data::{self, FromData};
|
|
use rocket::http::ContentType;
|
|
use rocket::form::Form;
|
|
|
|
// Test that the data parameters works as expected.
|
|
|
|
#[derive(FromForm)]
|
|
struct Inner<'r> {
|
|
field: &'r str
|
|
}
|
|
|
|
struct Simple<'r>(&'r str);
|
|
|
|
#[async_trait]
|
|
impl<'r> FromData<'r> for Simple<'r> {
|
|
type Error = std::io::Error;
|
|
|
|
async fn from_data(req: &'r Request<'_>, data: Data) -> data::Outcome<Self, Self::Error> {
|
|
<&'r str>::from_data(req, data).await.map(Simple)
|
|
}
|
|
}
|
|
|
|
#[post("/f", data = "<form>")]
|
|
fn form<'r>(form: Form<Inner<'r>>) -> &'r str { form.into_inner().field }
|
|
|
|
#[post("/s", data = "<simple>")]
|
|
fn simple<'r>(simple: Simple<'r>) -> &'r str { simple.0 }
|
|
|
|
#[test]
|
|
fn test_data() {
|
|
let rocket = rocket::ignite().mount("/", routes![form, simple]);
|
|
let client = Client::debug(rocket).unwrap();
|
|
|
|
let response = client.post("/f")
|
|
.header(ContentType::Form)
|
|
.body("field=this%20is%20here")
|
|
.dispatch();
|
|
|
|
assert_eq!(response.into_string().unwrap(), "this is here");
|
|
|
|
let response = client.post("/s").body("this is here").dispatch();
|
|
assert_eq!(response.into_string().unwrap(), "this is here");
|
|
|
|
let response = client.post("/s").body("this%20is%20here").dispatch();
|
|
assert_eq!(response.into_string().unwrap(), "this%20is%20here");
|
|
}
|